Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055992Openbravo ERPA. Platformpublic2024-07-12 09:132024-09-04 12:46
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055992: Parts of OpenIDAuthentication API should be exposed to extending classes to facilitate data retrieval
DescriptionSome parts of the OpenIDAuthentication API need to be exposed to extending classes to be able to retrieve email and some other data.

This is intended for Forge SSO development, but not limited to it.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0057859 closed eugen_hamuraru POS2 OpenId connect use a different token claim from email to identify the user 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-07-12 09:13cbernerNew Issue
2024-07-12 09:13cbernerAssigned To => cberner
2024-07-12 09:13cbernerModules => Core
2024-07-12 09:13cbernerTriggers an Emergency Pack => No
2024-07-12 09:17hgbotNote Added: 0166925
2024-07-15 10:36alostaleTypedefect => feature request
2024-09-04 12:46hgbotResolutionopen => fixed
2024-09-04 12:46hgbotStatusnew => closed
2024-09-04 12:46hgbotFixed in Version => PR24Q4
2024-09-04 12:46hgbotNote Added: 0168726
2024-09-04 12:46hgbotNote Added: 0168727
2025-02-06 17:53caristuRelationship addedrelated to 0057859

Notes
(0166925)
hgbot   
2024-07-12 09:17   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1300 [^]
(0168726)
hgbot   
2024-09-04 12:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: baac2a9e4bdd4d47b9115e99364965cd98a2e229
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 04-09-2024 10:46:45
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/baac2a9e4bdd4d47b9115e99364965cd98a2e229 [^]

Fixes FR-55992: Parts of OpenIDAuthentication API should be exposed to facilitate data retrieval

For some authentication providers that extend OpenIDAuthenticationManager the API has been exposed at the minimal necessary level(protected or package-protected).

The exposed API is also minimal, just what's necessary to be able to retrieve other user data or email directly through OpenID token authentication.

Some parts have been refactored to common methods to simplify code readability.

---
M src/org/openbravo/authentication/AuthenticationType.java
M src/org/openbravo/authentication/oauth2/OAuth2LoginButtonGenerator.java
M src/org/openbravo/authentication/oauth2/OpenIDAuthenticationManager.java
---
(0168727)
hgbot   
2024-09-04 12:46   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1300 [^]