Openbravo Issue Tracking System - POS2
View Issue Details
0055925POS2POSpublic2024-07-05 10:042024-07-30 11:11
avicente 
SABARINATH P 
normalmajoralways
closedfixed 
5
 
24Q4 
No
0055925: [User Input] User Input pop up is not open when 1. Convert to Return, 2. Add the product to the ticket
User Input pop up for 'Return Ticket' is not open if the actions are excecuted in the order: 1. Convert to Return, 2. Add the product to the ticket.

See video https://drive.google.com/file/d/194Xlx9UxCxZjXTL_JFc_HD9XThp9DEng/view?usp=sharing [^]
See video https://drive.google.com/file/d/194Xlx9UxCxZjXTL_JFc_HD9XThp9DEng/view?usp=sharing [^]

1. To Define a ‘User Input’ with a list of values in BO.
2. To Define a ‘User Action Input’ for the action ‘Return Ticket’ and the previously defined ‘User Input’ in BO.
3. Login in POS.
4. Click on ‘Convert to return’.
5. Add a product.

Current Result:
- The User Input pop up for 'Return Ticket' is not open.

Expected Result:
- The User Input pop up for 'Return Ticket' should be open when 1. Convert to Return, 2. Add the product to the ticket.
I think that one possible solution for this could be to add a pre hook in the AddProduct user action which:

Identifies if the ticket is a return
If it is a return, asks for the inputs (not the ones linked to the AddProduct but those that are requested for the user action that makes the ticket a return). See here an example that shows a user action requesting the inputs of a different user action. If ticket is not a return, nothing is done: just return the payload without changes.

Include the information of the inputs properly in the payload. → Check that the information is correctly synchronized in the backend (Approval History and Input History subtabs).


** https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SetLineReturnInputs.js#L35 [^]
No tags attached.
Issue History
2024-07-05 10:04avicenteNew Issue
2024-07-05 10:04avicenteAssigned To => Triage Platform Base
2024-07-05 10:04avicenteTriggers an Emergency Pack => No
2024-07-05 10:08avicenteSummary[User Input] User Input pop up is not open => [User Input] User Input pop up is not open when 1. Convert to Return, 2. Add the product to the ticket
2024-07-05 13:39avicenteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28194#r28194
2024-07-05 14:59avicenteAssigned ToTriage Platform Base => guilleaer
2024-07-05 15:02avicenteAssigned Toguilleaer =>
2024-07-05 15:02avicenteCategoryCore => POS
2024-07-05 15:04guilleaerAssigned To => Retail
2024-07-05 15:04guilleaerStatusnew => acknowledged
2024-07-06 07:13SABARINATH PAssigned ToRetail => SABARINATH P
2024-07-06 07:13SABARINATH PStatusacknowledged => scheduled
2024-07-08 08:50guilleaerProposed Solution updated
2024-07-08 09:04guilleaerProposed Solution updated
2024-07-16 15:39hgbotNote Added: 0167020
2024-07-29 14:54hgbotNote Added: 0167445
2024-07-30 11:11hgbotNote Added: 0167484
2024-07-30 11:11hgbotResolutionopen => fixed
2024-07-30 11:11hgbotStatusscheduled => closed
2024-07-30 11:11hgbotFixed in Version => 24Q4
2024-07-30 11:11hgbotNote Added: 0167485
2024-07-30 11:11hgbotNote Added: 0167486
2024-07-30 11:11hgbotNote Added: 0167487

Notes
(0167020)
hgbot   
2024-07-16 15:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2800 [^]
(0167445)
hgbot   
2024-07-29 14:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/289 [^]
(0167484)
hgbot   
2024-07-30 11:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2800 [^]
(0167485)
hgbot   
2024-07-30 11:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 84c4462d743f594d7864ef46acc0bddd53143d06
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 30-07-2024 09:10:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/84c4462d743f594d7864ef46acc0bddd53143d06 [^]

Fixed ISSUE-55925: Return line reason while adding product to return ticket.

---
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/inputsAndApprovalsForReturnTicket.js
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/SetLineQuantityButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/LinesCreatorInfrastructure.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/TicketUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
---
(0167486)
hgbot   
2024-07-30 11:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: e002fb6c79667b2e02aca224653c1a6575016319
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 30-07-2024 09:09:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/e002fb6c79667b2e02aca224653c1a6575016319 [^]

Related ISSUE-55925: Resolved CI failure on including OBPOS2_ReturnBlindTicket userAction.

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLineHeaderPopover/__test__/TicketMenuLineHeaderPopover.test.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/AddProductHooks.test.js
---
(0167487)
hgbot   
2024-07-30 11:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/289 [^]