Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055878Retail ModulesRetail APIpublic2024-07-01 13:382024-07-19 06:30
ReporterAgatheBertin 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055878: API ProductListsForLabels - Organization
DescriptionAPI ProductListsForLabels

When importing, we have to set an organization (Organization of the product list for labels)

But, we can only integrate the object using the NAME of the organization

We should be able to use the searchKey of the organization
Steps To ReproduceUse the SearchKey of the organiztion and you get the error "Error while importing an item: No entry found in Organization with name = 0000001203"


[{"client":"CCC","organization":"0000001203","name":"Test ABE1234","searchKey":"Test ABE1234","active":true,"printDate":"2024-02-07","products":[{"product":"477715"},{"product":"581301"},{"product":"182496"},{"product":"477720"},{"product":"549207"},{"product":"581297"}]}]
Proposed SolutionAllow to import with the search Key of the organization.


JWE:
Import will check first SearchKey and if not then organization name (to keep retrocompatbility)

Export will be done just by searchKey
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0056044RR24Q3.1 closed sreehari API ProductListsForLabels - Organization 
depends on backport 0056045RR24Q2.2 closed sreehari API ProductListsForLabels - Organization 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-07-01 13:38AgatheBertinNew Issue
2024-07-01 13:38AgatheBertinAssigned To => Triage Platform Conn
2024-07-01 13:38AgatheBertinOBNetwork customer => OBPS
2024-07-01 13:38AgatheBertinTriggers an Emergency Pack => No
2024-07-08 10:14alostaleAssigned ToTriage Platform Conn => Retail
2024-07-10 10:29jorgewederagoProposed Solution updated
2024-07-10 10:29jorgewederagoStatusnew => acknowledged
2024-07-15 07:17sreehariAssigned ToRetail => sreehari
2024-07-15 07:18sreehariStatusacknowledged => scheduled
2024-07-16 13:41hgbotMerge Request Status => open
2024-07-16 13:41hgbotNote Added: 0167014
2024-07-17 10:54guillermogilStatusscheduled => feedback
2024-07-17 10:55guillermogilStatusfeedback => scheduled
2024-07-17 11:02hgbotMerge Request Statusopen => approved
2024-07-17 11:03hgbotResolutionopen => fixed
2024-07-17 11:03hgbotStatusscheduled => closed
2024-07-17 11:03hgbotNote Added: 0167059
2024-07-17 11:03hgbotNote Added: 0167060
2024-07-18 11:21sreehariNote Added: 0167117
2024-07-18 11:21sreehariStatusclosed => new
2024-07-18 11:21sreehariResolutionfixed => open
2024-07-18 11:21sreehariStatusnew => scheduled
2024-07-18 12:07hgbotNote Added: 0167122
2024-07-19 06:30hgbotResolutionopen => fixed
2024-07-19 06:30hgbotStatusscheduled => closed
2024-07-19 06:30hgbotNote Added: 0167141
2024-07-19 06:30hgbotNote Added: 0167142

Notes
(0167014)
hgbot   
2024-07-16 13:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/4 [^]
(0167059)
hgbot   
2024-07-17 11:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api [^]
Changeset: 0a4c25ddb10a1d9a6d979a59f825f313565580dd
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-07-2024 09:03:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/commit/0a4c25ddb10a1d9a6d979a59f825f313565580dd [^]

Fixes ISSUE-55878: Changed organization name to searchKey on the API

---
A src/org/openbravo/pos2/product/label/printing/api/mappings/ImportProductListsForLabelsJavaPropertyMappingHandler.java
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0167060)
hgbot   
2024-07-17 11:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/4 [^]
(0167117)
sreehari   
2024-07-18 11:21   
when wrong organization is sent in the request, it throws error but also creates record with * org
(0167122)
hgbot   
2024-07-18 12:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/5 [^]
(0167141)
hgbot   
2024-07-19 06:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api [^]
Changeset: 190a247e44a98a76c494ccd471548487752c7052
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 19-07-2024 04:30:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/commit/190a247e44a98a76c494ccd471548487752c7052 [^]

Fixes ISSUE-55878: Record being created in case org not found
Removed log and thrown related exceptions instead

---
M src/org/openbravo/pos2/product/label/printing/api/mappings/ImportProductListsForLabelsJavaPropertyMappingHandler.java
---
(0167142)
hgbot   
2024-07-19 06:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/5 [^]