Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055868POS2POSpublic2024-06-28 13:162024-08-21 09:06
Reporternicolasuriz 
Assigned ToSABARINATH P 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055868: Cash management events of type "Refund" is not taking into account the Max and Min Amount fields in the POS.
DescriptionWhen a Cash Management event of type Refund is configured with a minimum and maximum amount, the POS is not taking into account those field and it lets you refund without that validation.

Set a Cash management event of type refund for the Credit notes, and the payment method to use in the refund will be cash. Set the minimun to 20 and the maximum to 50.
Steps To Reproduce1. Login POS.
2. Do a sales for an amount higher than 50€.
3. Do a verified return of that ticket and refund it in Credit Note (a new Gift Card instance of type Based on Credit Note is created with the balance of the return)
4. Go to the menu entry from POS "Gift Cards / Credit Notes / Gift Certificates", find the previous Credit note created and click on the "eyes" in order to see the Credit Note details.
5. Click on "Refund" button and confirm the Popup to end with the process.
Proposed SolutionThe maximum and minimum amount at cash management event should have a validation in POS in order to control the min and max amount possible to be refunded of a Credit Note in this case.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-06-28 13:16nicolasurizNew Issue
2024-06-28 13:16nicolasurizAssigned To => Retail
2024-06-28 13:16nicolasurizTriggers an Emergency Pack => No
2024-07-01 08:57guilleaerStatusnew => acknowledged
2024-07-02 12:05SABARINATH PAssigned ToRetail => SABARINATH P
2024-07-02 12:05SABARINATH PStatusacknowledged => scheduled
2024-07-02 15:33hgbotNote Added: 0166613
2024-08-08 15:03hgbotResolutionopen => fixed
2024-08-08 15:03hgbotStatusscheduled => resolved
2024-08-08 15:03hgbotNote Added: 0167870
2024-08-08 15:03hgbotNote Added: 0167871
2024-08-08 15:12javierRodriguezStatusresolved => closed
2024-08-09 10:27hgbotStatusclosed => resolved
2024-08-09 10:27hgbotNote Added: 0167904
2024-08-09 12:59marvintmStatusresolved => closed
2024-08-09 12:59marvintmFixed in Version => 24Q4
2024-08-09 15:38hgbotNote Added: 0167932
2024-08-09 15:38hgbotNote Added: 0167933
2024-08-14 13:04guilleaerStatusclosed => new
2024-08-14 13:04guilleaerResolutionfixed => open
2024-08-14 13:04guilleaerFixed in Version24Q4 =>
2024-08-14 13:04guilleaerStatusnew => scheduled
2024-08-19 08:37hgbotNote Added: 0168192
2024-08-19 13:40hgbotNote Added: 0168215
2024-08-19 13:46hgbotNote Added: 0168216
2024-08-21 09:06hgbotNote Added: 0168294
2024-08-21 09:06hgbotResolutionopen => fixed
2024-08-21 09:06hgbotStatusscheduled => closed
2024-08-21 09:06hgbotNote Added: 0168295

Notes
(0166613)
hgbot   
2024-07-02 15:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/352 [^]
(0167870)
hgbot   
2024-08-08 15:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: a865a6376a8e845dbd7dd7be91effd8c723ede2c
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 08-08-2024 13:01:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/a865a6376a8e845dbd7dd7be91effd8c723ede2c [^]

Fixed ISSUE-55868: Min & max cashmgmnt event taken into account on refund credit note

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/master/CashMgmtEvents.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.scss
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/__test__/GiftCardDialogFormHandler.test.js
---
(0167871)
hgbot   
2024-08-08 15:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/352 [^]
(0167904)
hgbot   
2024-08-09 10:27   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 93fd63840885048ec55c05f3e86c7888477ec60c
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 09-08-2024 13:57:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/93fd63840885048ec55c05f3e86c7888477ec60c [^]

Revert "Fixed ISSUE-55868: Min & max cashmgmnt event taken into account on refund credit note"

This reverts commit a865a6376a8e845dbd7dd7be91effd8c723ede2c.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/master/CashMgmtEvents.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.scss
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/__test__/GiftCardDialogFormHandler.test.js
---
(0167932)
hgbot   
2024-08-09 15:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2849 [^]
(0167933)
hgbot   
2024-08-09 15:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/365 [^]
(0168192)
hgbot   
2024-08-19 08:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/368 [^]
(0168215)
hgbot   
2024-08-19 13:40   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2849 [^]
(0168216)
hgbot   
2024-08-19 13:46   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/365 [^]
(0168294)
hgbot   
2024-08-21 09:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/368 [^]
(0168295)
hgbot   
2024-08-21 09:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 402a9fa01803e802291e20f40e2a0fd3dd52aafb
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 20-08-2024 18:27:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/402a9fa01803e802291e20f40e2a0fd3dd52aafb [^]

Fixed ISSUE-55868: Min & max cashmgmnt event taken into account on refund credit note

---
A src/org/openbravo/retail/giftcards/master/CashMgmtEventsProperties.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/master/CashMgmtEvents.java
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/__test__/GiftCardDialogFormHandler.test.js
---