Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055792POS2POSpublic2024-06-19 09:582024-08-26 07:52
Reporterucarrion 
Assigned ToRajesh_18 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055792: Incorrect 'Final Price' in the discount menu while applying a new line price
DescriptionThe discount menu displays a 'Final Price' section where the expected final price (after the discount application) is informed. This price is incorrect if the applied discount is a defined line amount.
Steps To Reproduce-Precondition: to have a 'User defined amount' discount enabled for the target environment.
-Login the POS.
-Add a line.
-Click/tap on the line. In the contextual menu, select 'Discount'.
-In the discount menu, select the 'User defined amount' discount.
-Insert a value on the pad.
-Check that the final price is not the expected one.

Video: https://vimeo.com/962063199/8778765c52?share=copy [^]
Proposed SolutionThe final price should be the one inserted in the pad.
Additional Information
TagsNo tags attached.
Relationships
related to defect 005511024Q2 closed Rajesh_18 User Defined Line Amount discount setting 0 price 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-06-19 09:58ucarrionNew Issue
2024-06-19 09:58ucarrionAssigned To => Retail
2024-06-19 09:58ucarrionTriggers an Emergency Pack => No
2024-06-19 10:00ucarrionSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28119#r28119
2024-06-19 10:06ucarrionRelationship addedrelated to 0055110
2024-06-19 11:10lmonrealIssue Monitored: martinsdan
2024-06-24 11:32marvintmStatusnew => acknowledged
2024-06-24 11:48SABARINATH PAssigned ToRetail => SABARINATH P
2024-06-24 11:48Rajesh_18Assigned ToSABARINATH P => Rajesh_18
2024-06-24 11:48SABARINATH PStatusacknowledged => scheduled
2024-06-28 14:56hgbotNote Added: 0166480
2024-08-26 07:50hgbotResolutionopen => fixed
2024-08-26 07:50hgbotStatusscheduled => closed
2024-08-26 07:51hgbotFixed in Version => 24Q4
2024-08-26 07:51hgbotNote Added: 0168422
2024-08-26 07:51hgbotNote Added: 0168423
2024-08-26 07:52marvintmNote Added: 0168424

Notes
(0166480)
hgbot   
2024-06-28 14:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2764 [^]
(0168422)
hgbot   
2024-08-26 07:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 55c745aeabf81fc78af03d324e66a32e50c98dd9
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 23-08-2024 06:00:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/55c745aeabf81fc78af03d324e66a32e50c98dd9 [^]

Fixed ISSUE-55792: In Discount window, Final price is changed based on the discount amount
* User Defined Line discount amount cannot be greater than the product price
* If two product are selected and User Defined Line discount is applied, if the discount amt greater than any one of the product price then warning message is shown to the user.
* Example Avalanche price is 150 and Hiking Boots price is 170. if we try to apply 160 as discount amount, we cannot apply it a warning notification is shown.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
---
(0168423)
hgbot   
2024-08-26 07:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2764 [^]
(0168424)
marvintm   
2024-08-26 07:52   
Tested several cases with the "User Defined Line Amount" rule, testing both lower and greater amounts than the total line amount. In all cases it was working correctly. Besides this, confirmed that "User defined" amount and percentage discounts were also still working correctly.