0055758: Unique UPC in product - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0055758

Modules

Unique Product UPC

public

2024-06-12 19:05

2024-07-08 13:56

Reporter

sdossantos

Assigned To

Triage Omni OMS

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

1.1.2

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0055758: Unique UPC in product

Description

If I configure the same upc that is in the header on the same product, it fails. This should work because it is the same product.

Steps To Reproduce

1- Add upc in the tab of the multiupc, the same upc in the header of the product
We see the error

Attached the image

Proposed Solution

at line 79
// Check UPC in Product
final OBQuery<Product> productQuery = OBDal.getInstance()
.createQuery(Product.class,
"as e where e.uPCEAN = :upcValue and e.organization.id = :orgId");
productQuery.setNamedParameter("upcValue", newUpc);
productQuery.setNamedParameter("orgId", orgId);
productQuery.setFilterOnReadableOrganization(false);
productQuery.setMaxResult(10);
List<Product> listProduct = productQuery.list();
if (listProduct.size() > 0) {
Product p = listProduct.get(0);
for (Product product : listProduct) {
if(!p.getId().equals(product.getId()))
{
listProductName.add(product.getName());
}
}
}

if (listProductName.size() > 0) {
throw new OBException(String.format(OBMessageUtils.messageBD("OBMUPC_DUPLICATED_UPC"),
String.join(", ", listProductName)));
}
}

Additional Information

Tags

No tags attached.

Relationships

causes

defect

0056292

closed

kousalya_r

Retail Modules

MultiUPC Validation is not working

Attached Files