Openbravo Issue Tracking System - POS2
View Issue Details
0055749POS2POSpublic2024-06-12 13:162024-09-06 12:19
nicolasuriz 
sreehari 
highmajoralways
closedfixed 
5
 
24Q4 
marvintm
No
0055749: The sales representative is being automatically added to a Verified Return when it should be empty.
The sales representative is being automatically added to a Verified Return when it should be empty.

By configuration at touchpoint type level:
1. Sales Representative mandatory = No
2. Sales Representative in New Orders = Keep it blank
3. Sales Representative in Local Drafts when switching user = Keep both header and lines Sales Representative
1. Login POS
2. Add a product to the ticket and check that the Sales representative is empty.
3. Fully pay/deliver and synchronize the ticket.
4. Open the previous ticket and do a Verified Return.
5. The Sales Representative is added to the ticket and orderline and it is displayed in the orderline level in the screen.
It should remain empty as it is in the sales orders case with this configuration.

And as it is logical, the sales representative normally is thought to the sales orders, not the returns, so if the original sales order has the field Sales representative empty, it should happen the same with the returns.
No tags attached.
depends on backport 005640024Q3.1 closed sreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
depends on backport 005640124Q2.3 closed sreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
causes defect 0056270 closed sreehari The Sales Representation saved as null in shipment and invoice lines throws FK exception 
Issue History
2024-06-12 13:16nicolasurizNew Issue
2024-06-12 13:16nicolasurizAssigned To => Retail
2024-06-12 13:16nicolasurizTriggers an Emergency Pack => No
2024-06-13 12:59marvintmStatusnew => acknowledged
2024-06-17 07:25sreehariAssigned ToRetail => sreehari
2024-06-17 07:25sreehariStatusacknowledged => scheduled
2024-06-18 09:14hgbotNote Added: 0166050
2024-08-13 20:57hgbotResolutionopen => fixed
2024-08-13 20:57hgbotStatusscheduled => closed
2024-08-13 20:57hgbotNote Added: 0168052
2024-08-13 20:57hgbotFixed in Version => 24Q4
2024-08-13 20:57hgbotNote Added: 0168053
2024-08-17 09:52sreehariRelationship addedcauses 0056270
2024-09-06 12:18marvintmStatusclosed => new
2024-09-06 12:18marvintmResolutionfixed => open
2024-09-06 12:18marvintmFixed in Version24Q4 =>
2024-09-06 12:19marvintmStatusnew => scheduled
2024-09-06 12:19marvintmStatusscheduled => resolved
2024-09-06 12:19marvintmFixed in Version => 24Q4
2024-09-06 12:19marvintmResolutionopen => fixed
2024-09-06 12:19marvintmReview Assigned To => marvintm
2024-09-06 12:19marvintmStatusresolved => closed

Notes
(0166050)
hgbot   
2024-06-18 09:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2732 [^]
(0168052)
hgbot   
2024-08-13 20:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2732 [^]
(0168053)
hgbot   
2024-08-13 20:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 111409aa501e50d733b8b0c375a2bcbd071ad192
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 13-08-2024 18:57:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^]

Fixes ISSUE-55749: Removed salesRep from Ticket and Lines

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/SetDefaultSalesRepresentative.test.js
---