0055738: Extra Greeting being generated in case name = " "

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0055738

Retail Modules

Retail API

public

2024-06-11 13:15

2024-06-21 10:02

Reporter

guillermogil

Assigned To

Triage Platform Conn

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0055738: Extra Greeting being generated in case name = " "

Description

Extra Greeting being generated in case name = " " everytime a BP integration is being sent.
This is happening with new BPs and with updates therefore tones of records in c_greeting are being generated.

It seems that there is some case with "" or " " that are not being treated as strings although it is the identifier for the API.

Steps To Reproduce

With postman sent the following request twice (it is the standard one but with the name of the greeting as " "):
{
    "client": "The White Valley Group",
    "organization": "The White Valley Group",
    "active": true,
    "searchKey": "TestBP",
    "commercialName": "TestBP",
    "fiscalName": "TestBP",
    "description":"TestBP",
    "bpCategory": "Customer",
    "currency": "EUR",
    "paymentMethod": "Cash",
    "paymentTerms": "Treinta días",
    "priceList": "The White Valley Group Sale Price List",
    "customerConsent": false,
    "creditLineLimit": 0,
    "currentBalance": 0,
    "invoiceTerms": "I",
    "greeting": {
        "name": " "
    },
    "locations": [
        {
            "address": "Pau Claris 138 1-2",
            "city": "Barcelona",
            "zipCode": "08009",
            "country": "ES",
            "name": ".Barcelona, Pau Claris 138 1-2"
        }
    ],
    "contactInformation": [
        {
            "firstName": "TestBP",
            "lastName": "TestBP",
            "active": true,
            "phone": "65986597",
            "email": "TestBP@TestBP.com"
        }
    ],
    "businessPartnerType": "PR",
    "isCustomer": true,
    "isVendor": true,
    "purchasePriceList": {
        "organization": "The White Valley Group",
        "name": "The White Valley Group Purchase Price List"
    },
    "poPaymentMethod": {
        "organization": "0",
        "name": "Cash"
    },
    "poPaymentTerms": "30d",
    "poFinancialAccount": {
        "organization": "White Valley Spain S.A",
        "name": "Bank Account 1 - White Valley Spain"
    },
    "poMaturityDate1": 100,
    "poMaturityDate2": 50,
    "poMaturityDate3": 60,
    "taxCategory": {
        "organization": "The White Valley Group",
        "name": "Arrendamientos con retención"
    }
}

Proposed Solution

Additional Information