Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055620POS2POSpublic2024-05-29 17:332024-06-06 15:16
Reporterdorian_robillard 
Assigned Tosreehari 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date2024-05-29
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c3ae4f5ebc7931d459a852f68aa10684d5708713?merge_request_iid=2444 [^]
Triggers an Emergency PackNo
Summary0055620: When closing till and counting safebox, an EWI is created
DescriptionWhen closing till and counting safebox, an EWI is created : org.openbravo.base.exception.OBException: Cashup cannot be processed since error occurred in CashClose: null
Steps To ReproduceIn livebuilds
1) Go to the backoffice
2) Open safebox window
3) Active count on remove flag in the safebox VBSB01
4) Connect to the till https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBSSB1 [^]
5) Attach Safebox VBS01
6) Close till
7) In the pop up count safe box, click on yes
8) Count safebox
9) Go to the backoffice and open Error while importing window
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0054548 closed sreehari [Cash Up - Keep Amount] Configuration not taken into account properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-05-29 17:33dorian_robillardNew Issue
2024-05-29 17:33dorian_robillardAssigned To => Triage Platform Base
2024-05-29 17:33dorian_robillardTriggers an Emergency Pack => No
2024-05-29 17:46victor_perezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28055#r28055
2024-05-30 07:21marvintmAssigned ToTriage Platform Base => Retail
2024-05-30 07:21marvintmCategoryCore => POS
2024-05-30 07:21marvintmStatusnew => acknowledged
2024-05-30 09:20sreehariAssigned ToRetail => sreehari
2024-05-30 09:20sreehariStatusacknowledged => scheduled
2024-05-31 11:34sreehariRegression level => Pre packaging ( pi )
2024-05-31 11:34sreehariRegression date => 2024-05-29
2024-05-31 11:34sreehariRegression introduced in release => pi
2024-05-31 11:34sreehariRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c3ae4f5ebc7931d459a852f68aa10684d5708713?merge_request_iid=2444 [^]
2024-05-31 11:34sreehariRelationship addedcaused by 0054548
2024-05-31 15:18hgbotNote Added: 0165412
2024-06-06 15:15hgbotNote Added: 0165667
2024-06-06 15:16hgbotResolutionopen => fixed
2024-06-06 15:16hgbotStatusscheduled => closed
2024-06-06 15:16hgbotFixed in Version => 24Q3
2024-06-06 15:16hgbotNote Added: 0165668
2024-06-06 15:16hgbotNote Added: 0165669

Notes
(0165412)
hgbot   
2024-05-31 15:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2690 [^]
(0165667)
hgbot   
2024-06-06 15:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2690 [^]
(0165668)
hgbot   
2024-06-06 15:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 33f746f509dfe1f5e9bed1a390db7c22cbdc4f0b
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 06-06-2024 13:15:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/33f746f509dfe1f5e9bed1a390db7c22cbdc4f0b [^]

Fixes ISSUE-55620: Added safebox logic when changing cashupMode
*during countSafeBox when changing the cashupMode changes the finish action to OBPOS2_FinishCashup
*so instead OBPOS2_FinishCountSafebox action OBPOS2_FinishCashup is called which caused the import error

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/MatchCountedWithExpected.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetCountedAmount.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetSelectedPaymentMethod.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
---
(0165669)
hgbot   
2024-06-06 15:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bb3abc1042f1de1de72ca665d921b26cbfa1965a
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 06-06-2024 13:15:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bb3abc1042f1de1de72ca665d921b26cbfa1965a [^]

Fixes ISSUE-55620: Fixed jest test failure

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/UpdateCountedAmountUserAction.test.js
---