Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
0055336Openbravo LocalizationsLocalization Francepublic2024-04-26 11:272024-05-16 10:46
kousalya_r 
 
normalmajorhave not tried
closedfixed 
5
 
 
0055336: Cross Store Warehouse list should not check role's readable orgs
When the POS is loading the Warehouses that are visible in the stock view it is using the readable orgs to load the cross store warehouses. This can lead to strange situations were it is possible to see warehouses from different legal entities but not others from your legal.

The POS loads 3 different warehouse lists:

"warehouses" -> with the "on hand" warehouses of the store.

"crossStoreWarehouses" -> with all the warehouses of the same "cross store organization" that belongs to stores the user role has access to.

"otherWarehouses" -> based on the "included other warehouses" field.

when only those defined is selected it checks the “Cross Channel Warehouse” tab

when All excluding defined is selected. It checks the “Cross Channel Warehouse” tab to remove those warehouses. But it also removes store warehouses from 1st list and Cross Store warehouses from 2nd list with NO check of the readable orgs.

In TRU this leads to missing warehouses in the stock view in the following scenario:

All stores withing the legal entity share the same Cross Store organization. So in a store from Spain it is possible to execute a cross sale to any spanish store.

The want to be able to see stocks from ALL the stores, including other country warehouses (in Spain they can see Portuguese stores stock). So in the organization we set the “Included Other Warehoueses” to All excluding defined.

Store roles only have access to their store organization.

With above configuration in a store from Spain we can see Portuguese stores (even F&B client warehouses). But since role does only have access to its store organization it is not possible to see other stores from Spain.

 

We consider that filtering the Cross Store Warehouse list by the readable organizations of the role is an error. We have already configured the Cross Store Organization and the enabled required cross store flags. So if a role can do Cross Sales it should be able to see all the cross store organizations regardless the readable organizations.

 

On the other side any store/warehouse filtered out from the “Cross Store Warehouse” list should appear in the “Other Warehouses” list if the store has the “All excluding defined” option selected.

*
https://gitlab.com/openbravo/customers/TRU/org.openbravo.retail.posterminal/-/commit/d4e20aeaa40c1f434e094bda7ffa285b3364d429 [^]
No tags attached.
Issue History
2024-04-26 11:27kousalya_rNew Issue
2024-04-26 11:34hgbotNote Added: 0163805
2024-05-16 10:46hgbotNote Added: 0164711
2024-05-16 10:46hgbotResolutionopen => fixed
2024-05-16 10:46hgbotStatusnew => closed
2024-05-16 10:46hgbotFixed in Version => RR24Q3
2024-05-16 10:46hgbotNote Added: 0164712

Notes
(0163805)
hgbot   
2024-04-26 11:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1546 [^]
(0164711)
hgbot   
2024-05-16 10:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1546 [^]
(0164712)
hgbot   
2024-05-16 10:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: cc92955e2e1ff0865eb88a55a38a6affecc971e0
Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com>
Date: 16-05-2024 08:46:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/cc92955e2e1ff0865eb88a55a38a6affecc971e0 [^]

Fixes ISSUE-55336: Do not check readable orgs to show cross store warehouses

---
M src/org/openbravo/retail/posterminal/term/CrossStoreWarehouses.java
---