Openbravo Issue Tracking System - POS2
View Issue Details
0055262POS2POSpublic2024-04-19 08:302024-04-23 09:01
ebecerra 
ebecerra 
normalmajorhave not tried
closedfixed 
5
 
 
No
0055262: CRM Connector: Inconsistence in the API when filtering customers or addresses
Nowadays in the CRM without coding the API for filtering customers and addresses have different patterns in the URL

- getBusinessPartnerAddresses
URL: <baseURL>/addresses/{id BP}/filter?obOrganization=orgSK&obTerminal=termSearchKey&obUser=usrUsername&filter1….


- getBusinessPartners
URL: <baseURL>/customers/?obOrganization=orgSK&obTerminal=termSearchKey&obUser=usrUsername

The "filter" used in the path for "getBusinessPartnerAddresses" must be removed.
N/A
1. In the module: org.openbravo.mobile.core

   In file ExternalBusinessPartnerRepository.js: In the method: getBusinessPartnerAddresses remove "filter" from

      return OB.App.ExternalBusinessPartnerAPI.getFilteredItemsFromExternalSystem(
        externalSystem,
        `addresses/${bp.getKey()}/filter`,
        filters
      );

2. In module: org.openbravo.retail.samplebpintegration
   
   In the class: CRMNoCodingUtils in the method: writeResponseForReadAddress remove the check "filter" condition (see the implementation of writeResponseForReadCustomer)


3. Update the CRM documentation
No tags attached.
Issue History
2024-04-19 08:30ebecerraNew Issue
2024-04-19 08:30ebecerraAssigned To => Retail
2024-04-19 08:30ebecerraTriggers an Emergency Pack => No
2024-04-22 10:10ebecerraAssigned ToRetail => ebecerra
2024-04-22 10:10ebecerraStatusnew => acknowledged
2024-04-22 10:43hgbotNote Added: 0163508
2024-04-22 10:48hgbotNote Added: 0163513
2024-04-23 08:58guilleaerStatusacknowledged => scheduled
2024-04-23 09:01hgbotNote Added: 0163565
2024-04-23 09:01hgbotNote Added: 0163566
2024-04-23 09:01hgbotResolutionopen => fixed
2024-04-23 09:01hgbotStatusscheduled => closed
2024-04-23 09:01hgbotNote Added: 0163567
2024-04-23 09:01hgbotFixed in Version => RR24Q3
2024-04-23 09:01hgbotNote Added: 0163568

Notes
(0163508)
hgbot   
2024-04-22 10:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/696 [^]
(0163513)
hgbot   
2024-04-22 10:48   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/merge_requests/19 [^]
(0163565)
hgbot   
2024-04-23 09:01   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration [^]
Changeset: c86025cf9fbb80c7939a6f44534f921cae5e49ac
Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com>
Date: 23-04-2024 07:01:28
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/commit/c86025cf9fbb80c7939a6f44534f921cae5e49ac [^]

Related ISSUE-55262: Adapt CRM without coding sample CRM to an API change (Remove "filter" from API call getBusinessPartnerAddresses).

---
M src/org/openbravo/retail/samplebpintegration/crmnocoding/CRMNoCodingUtils.java
---
(0163566)
hgbot   
2024-04-23 09:01   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/merge_requests/19 [^]
(0163567)
hgbot   
2024-04-23 09:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/696 [^]
(0163568)
hgbot   
2024-04-23 09:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 260d7624f008625e0203288cd2e45da9d87f2ecf
Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com>
Date: 23-04-2024 07:01:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/260d7624f008625e0203288cd2e45da9d87f2ecf [^]

Fixed ISSUE-55262: Remove keyword "filter" from URL of API call (getBusinessPartnerAddresses) in CRM Connector

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerRepository.js
---