Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055255Retail ModulesRetail APIpublic2024-04-18 19:262024-04-25 17:20
Reporterdcontrera 
Assigned Todcontrera 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055255: Orderloader API - Change taxes list management
DescriptionThis json is needed when importing orders with order loader (not standard json object)

"taxLines": {

"taxeratename": {

"rate": 20,

"netAmount": 64.58,

"taxAmount": 12.92,

"amount": 12.92,

"net": 64.58

}

},

the taxe rate should be a value not a key field :

"taxLines": [

{ "taxe":"taxeratename" or better taxeratesearchkey

"rate": 20,

"netAmount": 64.58,

"taxAmount": 12.92,

"amount": 12.92,

"net": 64.58

}

]
Steps To ReproduceIt’s important to implement this change in a way that doesn’t break currently API. We need to support both the new and the old format for taxes.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-04-18 19:26dcontreraNew Issue
2024-04-18 19:26dcontreraAssigned To => dcontrera
2024-04-18 19:26dcontreraTriggers an Emergency Pack => No
2024-04-19 02:37hgbotNote Added: 0163418
2024-04-23 21:57hgbotNote Added: 0163622
2024-04-25 17:19hgbotResolutionopen => fixed
2024-04-25 17:19hgbotStatusnew => resolved
2024-04-25 17:19hgbotFixed in Version => RR24Q3
2024-04-25 17:19hgbotNote Added: 0163763
2024-04-25 17:19hgbotNote Added: 0163764
2024-04-25 17:19hgbotNote Added: 0163765
2024-04-25 17:19hgbotNote Added: 0163766
2024-04-25 17:19hgbotNote Added: 0163767
2024-04-25 17:19hgbotNote Added: 0163768
2024-04-25 17:19hgbotNote Added: 0163769
2024-04-25 17:20hgbotNote Added: 0163770
2024-04-25 17:20hgbotStatusresolved => closed
2024-04-25 17:20hgbotNote Added: 0163771
2024-04-25 17:20hgbotNote Added: 0163772

Notes
(0163418)
hgbot   
2024-04-19 02:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1535 [^]
(0163622)
hgbot   
2024-04-23 21:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/95 [^]
(0163763)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 180df8d09a0488735e99761d060ce26ded03ed64
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 25-04-2024 11:01:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/180df8d09a0488735e99761d060ce26ded03ed64 [^]

RM-11635 Fixed ISSUE-55255: Order loader modified to support new format for taxes.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/TicketPropertyMapping.java
---
(0163764)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1f3a357871fe75e92fe2fe70fef5f4e7fe2911f6
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 25-04-2024 11:01:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1f3a357871fe75e92fe2fe70fef5f4e7fe2911f6 [^]

RM-11635 Fixed ISSUE-55255: Fix to new format for taxes.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0163765)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ec30d8eeb25bbcf19c507b930e5ae47437244ab3
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 25-04-2024 11:01:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ec30d8eeb25bbcf19c507b930e5ae47437244ab3 [^]

RM-11635 Fixed ISSUE-55255: Fix to new format for taxes and Swagger modified.

---
M api/org.openbravo.retail.posterminal-orderloader.yml
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0163766)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1559cc3373c7f6399c4df1fab8afba31250d7841
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 25-04-2024 11:01:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1559cc3373c7f6399c4df1fab8afba31250d7841 [^]

RM-11635 Related to ISSUE-55255: Fixed tax property name

---
M api/org.openbravo.retail.posterminal-orderloader.yml
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0163767)
hgbot   
2024-04-25 17:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1535 [^]
(0163768)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6616eb9a447b12a9df1cf851029f4ade273b0d11
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 25-04-2024 11:01:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6616eb9a447b12a9df1cf851029f4ade273b0d11 [^]

RM-11635 Fixed ISSUE-55255: Fix index order loader.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0163769)
hgbot   
2024-04-25 17:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 488bd6cb7ee834e11072494ff04b9dedf3ad506e
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 25-04-2024 17:17:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/488bd6cb7ee834e11072494ff04b9dedf3ad506e [^]

RM-11635 Related to ISSUE-55255: Keep previous method for backwards compatibility

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0163770)
hgbot   
2024-04-25 17:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 235dc1850f76adf57fb2702b4e36a49ec2728d33
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 25-04-2024 17:19:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/235dc1850f76adf57fb2702b4e36a49ec2728d33 [^]

Fixed ISSUE-55255 Fixed RM-11635 Support better format for taxes in OrderLoader

---
M api/org.openbravo.retail.posterminal-orderloader.yml
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/TicketPropertyMapping.java
---
(0163771)
hgbot   
2024-04-25 17:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^]
Changeset: f694c34f6c1b3e7cac221a6a3b6373ea519ce900
Author: dante.contrera <dante.contrera@smfconsulting.es>
Date: 23-04-2024 16:57:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/f694c34f6c1b3e7cac221a6a3b6373ea519ce900 [^]

RM-11635 Fixed ISSUE-55255: Postman collection examples updated.

---
M examples/Retail API.postman_collection.json
---
(0163772)
hgbot   
2024-04-25 17:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/95 [^]