Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0055222 | Retail Modules | Retail API | public | 2024-04-17 14:30 | 2024-09-18 07:25 |
|
| Reporter | azzeddine_meftoh | |
| Assigned To | alostale | |
| Priority | high | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | main | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0055222: Price API - importing price for deactivated product |
| Description | When importing a price for a deativated product we get the error :
ERROR: duplicate key value violates unique constraint "m_productprice_pricelist_ve_un" |
| Steps To Reproduce | Import a price for a product with the API
Deactivate the product
Import against a price for this product with the API for the same pricelist version |
| Proposed Solution | Remove filters for active products |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0053912 | | closed | SABARINATH P | Retail Modules | API PriceList ERROR updating inactive product | | related to | defect | 0056207 | | closed | alostale | Modules | Pricelist API : The product price active flag is not updated |
|
| Attached Files |  issue55222-lb.mkv (1,904,785) 2024-09-03 13:36
https://issues.openbravo.com/file_download.php?file_id=20124&type=bug
request.json (1,802) 2024-09-03 15:37
https://issues.openbravo.com/file_download.php?file_id=20126&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-04-17 14:30 | azzeddine_meftoh | New Issue | |
| 2024-04-17 14:30 | azzeddine_meftoh | Assigned To | => Triage Platform Conn |
| 2024-04-17 14:30 | azzeddine_meftoh | Triggers an Emergency Pack | => No |
| 2024-04-17 14:49 | victor_perez | Severity | minor => major |
| 2024-04-18 10:29 | jorgewederago | Assigned To | Triage Platform Conn => Retail |
| 2024-04-18 10:29 | jorgewederago | Status | new => acknowledged |
| 2024-04-18 10:37 | adrianromero | Note Added: 0163352 | |
| 2024-04-18 10:37 | adrianromero | Status | acknowledged => closed |
| 2024-04-18 10:37 | adrianromero | Resolution | open => no change required |
| 2024-06-27 09:39 | marvintm | Assigned To | Retail => Triage Platform Conn |
| 2024-06-27 09:39 | marvintm | Note Added: 0166405 | |
| 2024-06-27 09:39 | marvintm | Status | closed => new |
| 2024-06-27 09:39 | marvintm | Resolution | no change required => open |
| 2024-06-28 10:19 | caristu | Note Added: 0166459 | |
| 2024-06-28 10:19 | caristu | Assigned To | Triage Platform Conn => azzeddine_meftoh |
| 2024-06-28 10:19 | caristu | Status | new => feedback |
| 2024-08-12 12:08 | marvintm | Status | feedback => closed |
| 2024-08-12 12:08 | marvintm | Resolution | open => unable to reproduce |
| 2024-09-03 13:30 | martinsdan | Assigned To | azzeddine_meftoh => Triage Platform Conn |
| 2024-09-03 13:30 | martinsdan | Status | closed => new |
| 2024-09-03 13:30 | martinsdan | Resolution | unable to reproduce => open |
| 2024-09-03 13:34 | martinsdan | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=28402#r28402 |
| 2024-09-03 13:34 | martinsdan | Proposed Solution updated | |
| 2024-09-03 13:36 | martinsdan | File Added: issue55222-lb.mkv | |
| 2024-09-03 13:36 | martinsdan | Note Added: 0168700 | |
| 2024-09-03 13:43 | adrianromero | Note Added: 0168702 | |
| 2024-09-03 15:37 | martinsdan | File Added: request.json | |
| 2024-09-03 15:39 | martinsdan | Note Added: 0168708 | |
| 2024-09-06 10:48 | rafaroda | Priority | normal => high |
| 2024-09-09 10:28 | alostale | Note Added: 0168919 | |
| 2024-09-09 10:29 | alostale | Relationship added | related to 0053912 |
| 2024-09-09 10:29 | alostale | Assigned To | Triage Platform Conn => alostale |
| 2024-09-09 11:15 | hgbot | Note Added: 0168923 | |
| 2024-09-09 11:18 | alostale | Status | new => scheduled |
| 2024-09-09 14:19 | Rick1212 | Note Added: 0168955 | |
| 2024-09-10 10:28 | shuehner | Note Deleted: 0168955 | |
| 2024-09-12 11:36 | alostale | Relationship added | related to 0056207 |
| 2024-09-18 07:25 | hgbot | Resolution | open => fixed |
| 2024-09-18 07:25 | hgbot | Status | scheduled => closed |
| 2024-09-18 07:25 | hgbot | Note Added: 0169298 | |
| 2024-09-18 07:25 | hgbot | Note Added: 0169299 | |
|
Notes |
|
|
|
This is the expected behaviour when trying to import any Openbravo entity with the same keys as another existing deactivated entity.
Deactivated entities are maintanined in the database for reference and reporting purposes but cannot be used in new processes or selected, etc... and as consequence:
* Deactivated records cannot be updated by the import API and kept deactivated
* Deactivated records cannot be reactivated and updated as a result of an import API request
* Openbravo cannot create a new activated record due the database constraints that can end in an inconsistent database with two records with the same keys, one activated and the other deactivated. |
|
|
|
|
After further discussion, it is clear that this is a problem when trying to use the API to maintain masterdata entities so that the POS can correctly consume them. So we need to fix it somehow.
The final approach that will be used to handle this case is still to be decided by platform team. They will review it and then propose changes to handle this case. |
|
|
|
|
|
We are not able to reproduce the issue with the provided steps. In this type of cases a request example usually helps. |
|
|
|
|
|
I reopened the issue, updated the steps to reproduce and added a video. |
|
|
|
|
This issue is registered as RM-16449 [NOZ] Being able to activate/deactivate a price in a pricelist version by API
That is candidate for October Sprint. |
|
|
|
|
|
I added the json used to reproduce the problem in livebuilds. |
|
|
|
|
|
This is happening if org.openbravo.commercialoperations.api module is installed. |
|
|
|
(0168923)
|
|
hgbot
|
|
2024-09-09 11:15
|
|
|
|
|
(0169298)
|
|
hgbot
|
|
2024-09-18 07:25
|
|
|
|
|
(0169299)
|
|
hgbot
|
|
2024-09-18 07:25
|
|
|