Openbravo Issue Tracking System - POS2
View Issue Details
0055210POS2POSpublic2024-04-16 12:012024-05-15 10:57
malsasua 
Triage Omni OMS 
highmajoralways
closedfixed 
5
 
 
No
0055210: [OPECOM] multiple executions of the same commercial operation
It is possible to have multiple activate executions of the same commercial operations
. create a new commercial operation with
. click in Activate
. close window
. open window and click in Activate button again
-> the activation was done twice:
executing this query, you can check the number of records are duplicated:
select count(1) from obcomop_com_oper_prodpri op , m_productprice_exc e where op.obcomop_com_operation_id='OPECOM_ID' and op.obcomop_com_oper_prodpri_id =e.em_obcomop_com_oper_prodpri_id
No tags attached.
png Screenshot from 2024-04-26 17-59-28.png (348,514) 2024-04-29 08:51
https://issues.openbravo.com/file_download.php?file_id=19724&type=bug
Issue History
2024-04-16 12:01malsasuaNew Issue
2024-04-16 12:01malsasuaAssigned To => Retail
2024-04-16 12:01malsasuaTriggers an Emergency Pack => No
2024-04-16 12:57aferrazAssigned ToRetail => Triage Omni OMS
2024-04-25 12:46frank_gonzalezNote Added: 0163741
2024-04-29 08:51kousalya_rNote Added: 0163871
2024-04-29 08:51kousalya_rFile Added: Screenshot from 2024-04-26 17-59-28.png
2024-04-29 08:52kousalya_rNote Edited: 0163871bug_revision_view_page.php?bugnote_id=0163871#r27901
2024-04-29 09:55malsasuaNote Added: 0163877
2024-05-02 08:18hgbotNote Added: 0163973
2024-05-14 21:43hgbotResolutionopen => fixed
2024-05-14 21:43hgbotStatusnew => closed
2024-05-14 21:43hgbotNote Added: 0164575
2024-05-14 21:43hgbotNote Added: 0164576
2024-05-15 10:57hgbotNote Added: 0164644

Notes
(0163741)
frank_gonzalez   
2024-04-25 12:46   
Jira: https://openbravo.atlassian.net/browse/RM-13514 [^]
(0163871)
kousalya_r   
2024-04-29 08:51   
(edited on: 2024-04-29 08:52)
The issue is not reproducible. I activate the commercial operations and close window and open again I get Reopen option only not Activate option.
Screenshot is attached

(0163877)
malsasua   
2024-04-29 09:55   
it is reproducible with a big volume of data. You need to close the window and open it again before the process finishes
(0163973)
hgbot   
2024-05-02 08:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/70 [^]
(0164575)
hgbot   
2024-05-14 21:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: abff0a92945b672e5fe6cd569e849cfeeb116ba8
Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com>
Date: 14-05-2024 19:43:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/abff0a92945b672e5fe6cd569e849cfeeb116ba8 [^]

Fixes ISSUE-55210: Added processing column to avoid duplicate activation

---
M src-db/database/model/tables/OBCOMOP_COM_OPERATION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-test/org/openbravo/commercialoperations/process/ReopenCommercialOperationProcessTest.java
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
M src-test/org/openbravo/commercialoperations/process/ValidateCommercialOperationProcessTest.java
M src/org/openbravo/commercialoperations/process/CommercialOperationActionProcess.java
---
(0164576)
hgbot   
2024-05-14 21:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/merge_requests/70 [^]
(0164644)
hgbot   
2024-05-15 10:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations [^]
Changeset: bc03ee4107aeca0e0bde8280f1ef52db932cf233
Author: jonalegria <jon.alegria@openbravo.com>
Date: 15-05-2024 10:57:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations/-/commit/bc03ee4107aeca0e0bde8280f1ef52db932cf233 [^]

Fixes ISSUE-55210: Fixing tests

---
M src-test/org/openbravo/commercialoperations/process/ReopenCommercialOperationProcessTest.java
M src-test/org/openbravo/commercialoperations/process/StopCommercialOperationProcessTest.java
---