Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055184Retail ModulesWeb POSpublic2024-04-12 12:012024-04-25 13:43
Reporterjonae 
Assigned Tokousalya_r 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055184: Customer name and taxID are updatable in the customer collection data in PT
DescriptionWithin the PT localization, there is a validation for which some of the customer data cannot be updated as it must be key:

If the customer file contains taxID, this taxID cannot be updated if for this customer any sale has been fiscalized. Which means, the taxID is the key data for this customer.

If the customer file DOES NOT contain taxID, the customer name cannot be updated if for this customer any sale has been fiscalized.

Currently, in the customer data collection popup, both the customer name and taxID can be updated. For Portugal this could be problematic.

if will be possible for the seller to enter any data do not taken from the customer assigned to the sale, for those cases when such particular data is not available, for instance the address or the Tax ID of the customer.

it will not be possible for the seller to change the “Name” and the “Tax ID” retrieved from the customer assigned to the sale, unless:

there is a validation error of the PT Tax ID provided, so the correct one can be introduced by the seller (as we can not 100% trust the validity of the PT Tax ID provided)

there is a valid “PT Tax ID” assigned to the customer, as that is the only use case where the name of a customer can be changed.
Steps To Reproduce- In a new ticket
- Choose an existant customer
- Pay it
- The name and taxid are editable
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0055319RR24Q2 closed kousalya_r Customer name and taxID are updatable in the customer collection data in PT 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-04-12 12:01jonaeNew Issue
2024-04-12 12:01jonaeAssigned To => kousalya_r
2024-04-12 12:09hgbotNote Added: 0163150
2024-04-15 08:16hgbotNote Added: 0163170
2024-04-18 08:06hgbotResolutionopen => fixed
2024-04-18 08:06hgbotStatusnew => closed
2024-04-18 08:06hgbotNote Added: 0163347
2024-04-18 08:06hgbotNote Added: 0163348
2024-04-18 08:06hgbotNote Added: 0163349
2024-04-18 11:53hgbotNote Added: 0163359
2024-04-18 11:53hgbotNote Added: 0163360
2024-04-25 13:41jonaeStatusclosed => new
2024-04-25 13:41jonaeResolutionfixed => open
2024-04-25 13:42jonaeProjectOpenbravo Localizations => Retail Modules
2024-04-25 13:42jonaeTriggers an Emergency Pack => No
2024-04-25 13:42jonaeCategoryLocalization Portugal => Web POS
2024-04-25 13:43jonaeStatusnew => scheduled
2024-04-25 13:43jonaeNote Added: 0163752
2024-04-25 13:43jonaeStatusscheduled => resolved
2024-04-25 13:43jonaeResolutionopen => fixed
2024-04-25 13:43jonaeStatusresolved => closed

Notes
(0163150)
hgbot   
2024-04-12 12:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/67 [^]
(0163170)
hgbot   
2024-04-15 08:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/merge_requests/73 [^]
(0163347)
hgbot   
2024-04-18 08:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: fe2657fade7d7d5762d1d0cb4abb223c261ff619
Author: jonalegria <jon.alegria@openbravo.com>
Date: 17-04-2024 11:54:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/fe2657fade7d7d5762d1d0cb4abb223c261ff619 [^]

Fixes ISSUE-55184: Making the input readonly by information received from the API

---
M web-jspack/org.openbravo.events.client/src/components/RequestString.jsx
---
(0163348)
hgbot   
2024-04-18 08:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: 65d2d4c363f2a11232ca2fc5be3bde55553c1d4f
Author: jonalegria <jon.alegria@openbravo.com>
Date: 17-04-2024 11:54:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/65d2d4c363f2a11232ca2fc5be3bde55553c1d4f [^]

Fixes ISSUE-55184: Adding pos1 support and adding readonly logic to list type

---
M web/org.openbravo.events.client/source/components/stringprocess.js
---
(0163349)
hgbot   
2024-04-18 08:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/67 [^]
(0163359)
hgbot   
2024-04-18 11:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization [^]
Changeset: 3c10e58492e919d6940b9aa2e7842a87c4db8d7d
Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com>
Date: 18-04-2024 09:53:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/commit/3c10e58492e919d6940b9aa2e7842a87c4db8d7d [^]

Fixed ISSUE-55184: Disable Fields when customer has valid data

---
M web/org.openbravo.localization.portugal.fiscalization/source/events/PTFISFiscalizationEventHandler.js
---
(0163360)
hgbot   
2024-04-18 11:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.portugal.fiscalization/-/merge_requests/73 [^]
(0163752)
jonae   
2024-04-25 13:43   
Reopened to create backport for 24Q2