Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055161Retail ModulesRetail API Discountpublic2024-04-10 18:522024-04-22 09:54
Reporterdcontrera 
Assigned Todcontrera 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0055161: Use promotion search key in coupon import API instead of promotion name
DescriptionUse promotion search key in coupon import API instead of promotion name
Steps To ReproduceDiscounts and Promotions || Search Key is hidden by default.

Other customers as TRU/PRN are already using the existing property with the promotion name, so that to change will impact them.

GDA Proposal: one property used to checks both columns. It can be implemented using java property mapping. See a similar implementation for inventory line import accepts product's UPC or SearchKey.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-04-10 18:52dcontreraNew Issue
2024-04-10 18:52dcontreraAssigned To => dcontrera
2024-04-10 18:52dcontreraOBNetwork customer => No
2024-04-10 18:52dcontreraTriggers an Emergency Pack => No
2024-04-10 18:54hgbotMerge Request Status => open
2024-04-10 18:54hgbotNote Added: 0163067
2024-04-22 09:54hgbotMerge Request Statusopen => approved
2024-04-22 09:54hgbotResolutionopen => fixed
2024-04-22 09:54hgbotStatusnew => closed
2024-04-22 09:54hgbotNote Added: 0163492
2024-04-22 09:54hgbotNote Added: 0163493

Notes
(0163067)
hgbot   
2024-04-10 18:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/13 [^]
(0163492)
hgbot   
2024-04-22 09:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api [^]
Changeset: a910cd77be096c9c302d95c9b23e53c3c2d222ac
Author: Dante Contrera <dante.contrera@smfconsulting.es>
Date: 22-04-2024 07:54:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/commit/a910cd77be096c9c302d95c9b23e53c3c2d222ac [^]

Fixed ISSUE-55161: Java mapping added for Coupons to use searchkey/name of the promotion.

---
A src/org/openbravo/retail/discounts/coupons/api/mappings/coupon/ImportCouponJavaPropertyMappingHandler.java
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0163493)
hgbot   
2024-04-22 09:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/13 [^]