Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055134Openbravo ERP01. General setuppublic2024-04-09 09:362024-04-22 12:16
ReporterLeyre 
Assigned Tomeriem_azaf 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2023-09-17
Regression introduced in releasePR23Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/fcd246dff378226fbc702ed953da646619b6c35f [^]
Triggers an Emergency PackNo
Summary0055134: It is possible to active more terminals that are allowed in the instance.
DescriptionIt is possible to active more terminals that are allowed in the instance.
Steps To ReproduceAs system administator:
1. Open the "Instance Activation" window and confirm the maximum number of allowed active POS terminals in the instance. In my case, for example, 3.
2. Confirm that there are less active terminals than the maximum allowed. In my case 1.

Change the role:
3. Open the "Channel - Touchpoint" window.
2. Select more terminals than the allowed in the instance and click on the button "Activate or deactivate the current(selected) record(s)". See attached image.

Result: It is possible to active more terminals than allowed. Additionally, if you change to "System Administrator" role and navigate to the "Instance Activation" window, even if you click the refresh button, the data is not refershed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0053872 closed Rajesh_18 Retail Modules [Promos] - Deactivation of several records KO in some cases 
depends on backport 0055150PR24Q2 closed Triage Platform Base Openbravo ERP It is possible to active more terminals that are allowed in the instance. 
depends on backport 0055151PR24Q1.2 closed Triage Platform Base Openbravo ERP It is possible to active more terminals that are allowed in the instance. 
caused by feature request 0053407 closed meriem_azaf Openbravo ERP Multi-record activation/deactivation 
Attached Filespng image.png (190,088) 2024-04-09 09:36
https://issues.openbravo.com/file_download.php?file_id=19632&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-04-09 09:36LeyreNew Issue
2024-04-09 09:36LeyreAssigned To => Triage Omni OMS
2024-04-09 09:36LeyreFile Added: image.png
2024-04-09 09:36LeyreModules => Core
2024-04-09 09:36LeyreTriggers an Emergency Pack => No
2024-04-09 09:50aferrazAssigned ToTriage Omni OMS => Triage Platform Base
2024-04-10 08:23AugustoMauchRegression level => Production - Confirmed Stable
2024-04-10 08:23AugustoMauchRegression date => 2023-09-17
2024-04-10 08:23AugustoMauchRegression introduced in release => PR23Q4
2024-04-10 08:23AugustoMauchRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/fcd246dff378226fbc702ed953da646619b6c35f [^]
2024-04-10 08:23AugustoMauchRelationship addedcaused by 0053407
2024-04-10 08:23AugustoMauchStatusnew => scheduled
2024-04-11 10:26meriem_azafAssigned ToTriage Platform Base => meriem_azaf
2024-04-11 10:27meriem_azafReview Assigned To => AugustoMauch
2024-04-11 10:27meriem_azafRelationship addedduplicate of 0055164
2024-04-11 10:27meriem_azafStatusscheduled => closed
2024-04-11 10:27meriem_azafResolutionopen => duplicate
2024-04-11 10:48ngarciaRelationship addedduplicate of 0053872
2024-04-11 11:07LeyreNote Added: 0163088
2024-04-11 11:07LeyreStatusclosed => new
2024-04-11 11:20LeyreNote Deleted: 0163088
2024-04-11 11:28LeyreNote Added: 0163090
2024-04-12 09:33hgbotNote Added: 0163129
2024-04-17 11:14hgbotResolutionduplicate => fixed
2024-04-17 11:14hgbotStatusnew => closed
2024-04-17 11:14hgbotFixed in Version => PR24Q3
2024-04-17 11:14hgbotNote Added: 0163317
2024-04-17 11:14hgbotNote Added: 0163318
2024-04-17 13:05LeyreNote Added: 0163334
2024-04-17 13:05LeyreStatusclosed => new
2024-04-22 12:14AugustoMauchStatusnew => scheduled
2024-04-22 12:16AugustoMauchStatusscheduled => closed

Notes
(0163090)
Leyre   
2024-04-11 11:28   
With the patch related to the issue 53872:

https://gitlab.com/openbravo/product/openbravo/-/commit/ca43604951e4b318b53ced51a406cc7a31b9bd61 [^]

The problem is reproducible.
(0163129)
hgbot   
2024-04-12 09:33   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1196 [^]
(0163317)
hgbot   
2024-04-17 11:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: a74182b20d3c34efe3587d9920c8acf7112014fb
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-04-2024 11:14:22
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a74182b20d3c34efe3587d9920c8acf7112014fb [^]

Fixes ISSUE-55134: Event handlers get accurate info on the number of active records

The problem was that when enabling/disabling recordsa using the EnableOrDisableMultipleRecords process, the
event handlers were not receiving accurate info on the number of currently active records if data was flushed
updated updating them all.

In order to prevent this problem, now data is flushed after updating each records. This results in a slower execution
of the process but it is still reasonable fast (changing the active flag of 100 records took <100ms)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/EnableOrDisableMultipleRecords.java
---
(0163318)
hgbot   
2024-04-17 11:14   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1196 [^]
(0163334)
Leyre   
2024-04-17 13:05   
The patch fixes the problem in the "Touchpoint" window, now it is not possible to activate more terminals than allowed in the instance and a new error message appears

But if you navigate to the "Instance Activation" window as a "System Administrator" role, the data is updated incorrectly: WebPOS Terminals and Active WebPOS Terminals = the maximum allowed in both cases.