Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0055075POS2POSpublic2024-04-01 06:392024-06-10 17:11
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPre packaging ( pi )
Regression date2024-03-05
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5f0b3e44d9662fac5cafe19f6560d5dadf969162 [^]
Triggers an Emergency PackNo
Summary0055075: Rounding & Change payment not calculated properly in payment subtotals
DescriptionWhen rounding payment configured for payment method, rounding payment & change payment is not added/calculated in payment subtotals
Steps To ReproduceBackoffice
1) Enable "Rounding Payment" for Cash in VBS-4
POS2 - VBS4
1) Add Product "Avalance Tranceiver"
2) Pay and Split Check
3) Pay with Cash 100 for first subtotal
4) Rounding payment is not added and change is not calculated correctly
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005510324Q2 closed sreehari Rounding payment not calculated properly in payment subtotals 
depends on backport 005558424Q2 closed ranjith_qualiantech_com Rounding & Change payment not calculated properly in payment subtotals 
caused by defect 0054782 closed ranjith_qualiantech_com Give change with payment method other than Cash 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-04-01 06:39ranjith_qualiantech_comNew Issue
2024-04-01 06:39ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2024-04-01 06:39ranjith_qualiantech_comOBNetwork customer => No
2024-04-01 06:39ranjith_qualiantech_comTriggers an Emergency Pack => No
2024-04-01 13:09ranjith_qualiantech_comStatusnew => scheduled
2024-04-02 06:59ranjith_qualiantech_comRelationship addedcaused by 0054782
2024-04-02 07:01ranjith_qualiantech_comRegression level => Pre packaging ( pi )
2024-04-02 07:01ranjith_qualiantech_comRegression date => 2024-03-05
2024-04-02 07:01ranjith_qualiantech_comRegression introduced in release => pi
2024-04-02 07:01ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5f0b3e44d9662fac5cafe19f6560d5dadf969162 [^]
2024-04-02 07:01ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27749#r27749
2024-04-02 08:03hgbotMerge Request Status => open
2024-04-02 08:03hgbotNote Added: 0162764
2024-04-02 08:03hgbotNote Added: 0162765
2024-04-02 08:03hgbotNote Added: 0162766
2024-04-05 07:34ranjith_qualiantech_comStatusscheduled => acknowledged
2024-04-05 07:34ranjith_qualiantech_comStatusacknowledged => scheduled
2024-04-05 08:26ranjith_qualiantech_comSummaryRounding payment not calculated properly in payment subtotals => Rounding & Change payment not calculated properly in payment subtotals
2024-04-05 08:26ranjith_qualiantech_comDescription Updatedbug_revision_view_page.php?rev_id=27766#r27766
2024-05-07 16:32lorenzofidalgoTarget Version => 24Q2
2024-05-24 14:11migueldejuanaTarget Version24Q2 =>
2024-05-24 14:11migueldejuanaStatusscheduled => acknowledged
2024-05-24 14:12migueldejuanaStatusacknowledged => scheduled
2024-06-10 14:28hgbotMerge Request Statusopen => approved
2024-06-10 17:11hgbotNote Added: 0165738
2024-06-10 17:11hgbotNote Added: 0165739
2024-06-10 17:11hgbotResolutionopen => fixed
2024-06-10 17:11hgbotStatusscheduled => closed
2024-06-10 17:11hgbotFixed in Version => 24Q3
2024-06-10 17:11hgbotNote Added: 0165740
2024-06-10 17:11hgbotNote Added: 0165741
2024-06-10 17:11hgbotNote Added: 0165742
2024-06-10 17:11hgbotNote Added: 0165743
2024-06-10 17:11hgbotNote Added: 0165744
2024-06-10 17:11hgbotNote Added: 0165745
2024-06-10 17:11hgbotNote Added: 0165746
2024-06-10 17:11hgbotNote Added: 0165747

Notes
(0162764)
hgbot   
2024-04-02 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1523 [^]
(0162765)
hgbot   
2024-04-02 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/84 [^]
(0162766)
hgbot   
2024-04-02 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2534 [^]
(0165738)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5bb389cfb2357fdc17201bd8d10767036acd79e2
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 12:29:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5bb389cfb2357fdc17201bd8d10767036acd79e2 [^]

Related to ISSUE-55075: Added payment rounding if payment has subtotals
* When adding payment rounding, pendingAmount should be used for rounding calculation
  if ticket has payment subtotals

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
---
(0165739)
hgbot   
2024-06-10 17:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1523 [^]
(0165740)
hgbot   
2024-06-10 17:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4e8b96a0125a26544ed9b92df9da73f645cb031e
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 11:44:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4e8b96a0125a26544ed9b92df9da73f645cb031e [^]

Fixed ISSUE-55075: Added payment rounding in payment subtotals
* Payment rounding should be displayed in payment subtotals
  and rounding amount should be included in change calculation

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFunctions.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/UpdatePaymentInfoFromPayments.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/PaymentDisplay.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/PaymentDisplay.test.js
---
(0165741)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2280bd70d1174ba17c25633a844b4c685b5e698f
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 11:44:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2280bd70d1174ba17c25633a844b4c685b5e698f [^]

Related to ISSUE-55075: Change amount should be calculated for negative ticket
* In Payment subtotal, Change amount should be calculated for negative ticket

---
M web-jspack/org.openbravo.pos2/src/model/ticket/UpdatePaymentInfoFromPayments.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/UpdatePaymentInfoFromPayments.test.js
---
(0165742)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7023f2ca2dc81d499b4af002e19afa36dcaa23ae
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 11:44:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7023f2ca2dc81d499b4af002e19afa36dcaa23ae [^]

Related to ISSUE-55075: Fixed minor issues in payment subtotals
* Added pointer cursor for Payment subtotal change payments
* Invalid amount error should be shown in multicurrency change popup
  if value is empty

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFooter.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/Dialogs/MultiCurrencyChange/MultiCurrencyChangeDialog/MultiCurrencyChangeDialog.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/CalculateChange.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SplitFromOrder.js
---
(0165743)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2a1d9854e58bdfa509a080853db7d5c90ef3c503
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 11:44:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2a1d9854e58bdfa509a080853db7d5c90ef3c503 [^]

Related to ISSUE-55075: Updated cypress test for payment subtotals
* Updated cypress tests due to changes in VBS-4 payments

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/changePayments.spec.js
---
(0165744)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cf89e7e185808bdefc8329f48d3ad077d3c03c0c
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 10-06-2024 11:44:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cf89e7e185808bdefc8329f48d3ad077d3c03c0c [^]

Related to ISSUE-55075: Added PaymentRounding validation when checking Extra payments
* When completing payment with subtotals, Payment Rounding sould be execluded
  when ckecking the extra payments

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
---
(0165745)
hgbot   
2024-06-10 17:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2534 [^]
(0165746)
hgbot   
2024-06-10 17:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 4dbea461c086c358b771ef5a82f0740c2cc08fa1
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 07-06-2024 15:25:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/4dbea461c086c358b771ef5a82f0740c2cc08fa1 [^]

Related to ISSUE-55075: Added cash rounding payment method for touchpoint VBS-4
* Updated Change Less than from 1 to 10 for VBS-4 Cash Payment method
* Added Rounding payment for Cash Payment method

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_ROUNDING.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0165747)
hgbot   
2024-06-10 17:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/84 [^]