Openbravo Issue Tracking System - POS2
View Issue Details
0055047POS2POSpublic2024-03-25 14:572024-05-29 07:15
jfvaringot 
SABARINATH P 
immediatemajoralways
closedfixed 
5
 
24Q3 
approved
OBPS
No
0055047: POS2 - Approvals on discounts issues
Having 2 discounts, one with and one without approval.

As soon as the 'with approval' is added to the ticket, all other discounts need to be approved too, even if they are not configured to.
On Backoffice : https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql [^]
1. Create 1 discount :
1.a. Type : Discretionary Fixed Percentage
1.b. Percentage discount : 30
1.c. Approval needed : unchecked

2. Create 1 discount :
2.a. Type : Discretionary Fixed Percentage
2.b. Percentage discount : 70
2.c. Approval needed : checked

3. On role 'VallBlancaUser', add UserAction : 'Apply Discretionary and Optional Discount' (Approval Required)
4. On role 'The White Valley Group Admin', add UserAction 'Apply Discretionary and Optional Discount' (Can Use and Approve)

On POS2 : https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]

TEST 1 :
1. Connect with Vallblanca user
2. Add an item A
3. Apply the 30% discount -> no approval needed.
4. Add an item B
5. Apply the 70% discount -> approval needed => approve it with Openbravo user
6. Add an item C
7. Apply the 30% discount -> approval needed => SHOULD NOT BE NEEDED

TEST 2 :
1. Connect with Vallblanca user
2. Add an item A
3. Apply the 70% discount -> approval needed.
4. Add an item B
5. Apply the 30% discount -> approval neede => SHOULD NOT BE NEEDED
Approbation should be asked only on discounts for which the 'Approval needed' is checked.

No tags attached.
Issue History
2024-03-25 14:57jfvaringotNew Issue
2024-03-25 14:57jfvaringotAssigned To => Retail
2024-03-25 14:57jfvaringotTriggers an Emergency Pack => No
2024-04-10 12:51victor_perezOBNetwork customer => OBPS
2024-04-11 10:11guilleaerStatusnew => acknowledged
2024-04-11 12:54SABARINATH PAssigned ToRetail => SABARINATH P
2024-04-12 07:14SABARINATH PStatusacknowledged => scheduled
2024-04-12 08:12hgbotMerge Request Status => open
2024-04-12 08:12hgbotNote Added: 0163124
2024-05-07 16:09lorenzofidalgoTarget Version => 24Q2
2024-05-24 08:06marvintmTarget Version24Q2 =>
2024-05-28 16:23hgbotMerge Request Statusopen => approved
2024-05-29 07:15hgbotResolutionopen => fixed
2024-05-29 07:15hgbotStatusscheduled => closed
2024-05-29 07:15hgbotFixed in Version => 24Q3
2024-05-29 07:15hgbotNote Added: 0165244
2024-05-29 07:15hgbotNote Added: 0165245

Notes
(0163124)
hgbot   
2024-04-12 08:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2564 [^]
(0165244)
hgbot   
2024-05-29 07:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 959b7b49bdd6166704f5ea76fa4d4fc57d414490
Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com>
Date: 28-05-2024 13:35:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/959b7b49bdd6166704f5ea76fa4d4fc57d414490 [^]

Fixed ISSUE-55047: Approval popup for discount displayed only for configured discount.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js
---
(0165245)
hgbot   
2024-05-29 07:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2564 [^]