Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0054972 | Openbravo ERP | 01. General setup | public | 2024-03-15 14:31 | 2024-05-09 09:22 |
|
| Reporter | ngarcia | |
| Assigned To | AugustoMauch | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0054972: A record in a non editable tab can be deleted by a role if it includes an editable field |
| Description | A record in a non editable tab can be deleted by a role if it includes an editable field |
| Steps To Reproduce | In any Openbravo environment (only backoffice needed)
Go to Role window and set the User window as editable (Editable = 'Y' in Window access tab) to the current logged in role and the "User - User" tab as non editable (Editable = 'N' in Tab Access subtab)
Log out and log in
Go to User window, check that a record cannot be created. Check as well that existing records cannot be removed, and that none of the fields are editable.
Go back to Role window and add "Username - User - User" field as editable (Editable = 'Y' in Field access subtab)
Log out and log in
Open again the User window and notice that the New Record button is enabled (this is OK as only the username field can be edited), but the Delete current record button is enabled as well, and it should not be |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-03-15 14:31 | ngarcia | New Issue | |
| 2024-03-15 14:31 | ngarcia | Assigned To | => Triage Omni OMS |
| 2024-03-15 14:31 | ngarcia | Modules | => Core |
| 2024-03-15 14:31 | ngarcia | Triggers an Emergency Pack | => No |
| 2024-03-15 14:39 | aferraz | Assigned To | Triage Omni OMS => Triage Platform Base |
| 2024-04-08 12:17 | AugustoMauch | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=27779#r27779 |
| 2024-04-08 12:17 | AugustoMauch | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=27780#r27780 |
| 2024-04-08 12:24 | AugustoMauch | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=27781#r27781 |
| 2024-04-08 12:24 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2024-04-08 12:24 | AugustoMauch | Status | new => scheduled |
| 2024-04-08 15:30 | hgbot | Note Added: 0162923 | |
| 2024-04-08 15:31 | AugustoMauch | Status | scheduled => resolved |
| 2024-04-08 15:31 | AugustoMauch | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1186/diffs?commit_id=3d8784a0767e809fbcdea9dfc89e19bb63e2ca73 [^] |
| 2024-04-08 15:31 | AugustoMauch | Resolution | open => fixed |
| 2024-04-12 11:55 | hgbot | Status | resolved => closed |
| 2024-04-12 11:55 | hgbot | Fixed in Version | => PR24Q3 |
| 2024-04-12 11:55 | hgbot | Note Added: 0163148 | |
| 2024-04-12 11:55 | hgbot | Note Added: 0163149 | |
| 2024-05-09 09:22 | hgbot | Note Added: 0164354 | |
| 2024-05-09 09:22 | hgbot | Note Added: 0164355 | |
| 2024-05-09 09:22 | hgbot | Fixed in Version | PR24Q3 => PR23Q4.4 |
| 2024-05-09 09:22 | hgbot | Note Added: 0164356 | |
|
Notes |
|
|
(0162923)
|
|
hgbot
|
|
2024-04-08 15:30
|
|
|
|
|
(0163148)
|
|
hgbot
|
|
2024-04-12 11:55
|
|
|
|
|
(0163149)
|
|
hgbot
|
|
2024-04-12 11:55
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5b1b3ca32f8b418d226c7626679e7ae270028b3b
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 12-04-2024 09:53:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5b1b3ca32f8b418d226c7626679e7ae270028b3b [^]
Fixes ISSUE-54972: Non-editable tabs should not allow record deletion
Tabs configured to be non-editable should not allow to delete records, even if some of its specific fields can be edited. If some
fields can be edited then it will be possible to edit those rows in existing records, or to create new records if all mandatory
fields are editable
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
|
|
|
|
(0164354)
|
|
hgbot
|
|
2024-05-09 09:22
|
|
|
|
|
(0164355)
|
|
hgbot
|
|
2024-05-09 09:22
|
|
|
|
|
(0164356)
|
|
hgbot
|
|
2024-05-09 09:22
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2617a4419fc4c8aaf68d0319b96b0c4449fd61fe
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 07-05-2024 15:57:05
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2617a4419fc4c8aaf68d0319b96b0c4449fd61fe [^]
Fixes ISSUE-54972: Non-editable tabs should not allow record deletion
Tabs configured to be non-editable should not allow to delete records, even if some of its specific fields can be edited. If some
fields can be edited then it will be possible to edit those rows in existing records, or to create new records if all mandatory
fields are editable
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
|
|