0054931: Error page is not shown if the error occurs during registry process

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054931

POS2

Core

public

2024-01-02 13:07

2024-03-21 18:29

Reporter

jarmendariz

Assigned To

cberner

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

24Q1.2

Fixed in Version

24Q1.1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0054931: Error page is not shown if the error occurs during registry process

Description

In case the application has a blocking error, an error page defined in ErrorFallback.jsx is shown, but this page shows the company logo using the CompanyLogo component. If this error occurs during the registration process, where the State is not available yet, the Error page won't be shown and the user will encounter a blank screen.

Steps To Reproduce

1- Force an error during the registration process. This can be achieved by adding the following in checkIsRegistered() function in Registry.js:

function checkIsRegistered(registry, name, type) {
  if (!_.has(registry, name) || name === 'OBC2_Logout') {
    throw Error(`${type} ${name} is not registered`);
  }
}

2- Open POS2 application in the browser. Instead of rendering the login page or the error page, a blank screen will appear and the following errors in the browser's console:

Uncaught Error: could not find react-redux context value; please ensure the component is wrapped in a <Provider>
    at useReduxContext (useReduxContext.js:24:1)
    at useSelector (useSelector.js:125:1)
    at CompanyLogo (CompanyLogo.jsx:31:1)
...

Proposed Solution

Adding a check in CompanyLogo to show no logo if the state information is not available, preventing the error situation. This way the error page will be shown at least even if it has no logo.

Additional Information