Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054914POS2POSpublic2024-03-12 06:082024-03-27 06:44
Reporterranjith_qualiantech_com 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054914: Multi currency change option should be available for Payment Subtotals
DescriptionMulti currency change option should be available for Payment Subtotals as same as like Payments.
Steps To ReproduceJira: https://openbravo.atlassian.net/browse/RM-11762 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-03-12 06:08ranjith_qualiantech_comNew Issue
2024-03-12 06:08ranjith_qualiantech_comAssigned To => ranjith_qualiantech_com
2024-03-12 06:08ranjith_qualiantech_comTriggers an Emergency Pack => No
2024-03-12 06:17ranjith_qualiantech_comStatusnew => scheduled
2024-03-19 11:12hgbotNote Added: 0162349
2024-03-24 16:48hgbotNote Added: 0162558
2024-03-24 16:48hgbotNote Added: 0162559
2024-03-27 06:44hgbotResolutionopen => fixed
2024-03-27 06:44hgbotStatusscheduled => closed
2024-03-27 06:44hgbotNote Added: 0162665
2024-03-27 06:44hgbotFixed in Version => 24Q2
2024-03-27 06:44hgbotNote Added: 0162666
2024-03-27 06:44hgbotNote Added: 0162667
2024-03-27 06:44hgbotNote Added: 0162668
2024-03-27 06:44hgbotNote Added: 0162669
2024-03-27 06:44hgbotNote Added: 0162670
2024-03-27 06:44hgbotNote Added: 0162671
2024-03-27 06:44hgbotNote Added: 0162672
2024-03-27 06:44hgbotNote Added: 0162673
2024-03-27 06:44hgbotNote Added: 0162674
2024-03-27 06:44hgbotNote Added: 0162675
2024-03-27 06:44hgbotNote Added: 0162676
2024-03-27 06:44hgbotNote Added: 0162677

Notes
(0162349)
hgbot   
2024-03-19 11:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2512 [^]
(0162558)
hgbot   
2024-03-24 16:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/91 [^]
(0162559)
hgbot   
2024-03-24 16:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/82 [^]
(0162665)
hgbot   
2024-03-27 06:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2512 [^]
(0162666)
hgbot   
2024-03-27 06:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 623d5166a04e3129b37621bae1773fdbe4a6531d
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/623d5166a04e3129b37621bae1773fdbe4a6531d [^]

Fixed ISSUE-54914: Added Multicurrency change support in Payment subtotals

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentAmount.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFooter.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/PaymentPanelTitle.jsx
---
(0162667)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0f1b7a03dc361d7bab5902aed93d320ae74e5e50
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0f1b7a03dc361d7bab5902aed93d320ae74e5e50 [^]

Related to ISSUE-54914: Updated changePayments logic for payment subtotals
* Update calculateChange function to support payment subtotals.
* Replaced changePayments "previousTicketChange" logic with changePayments amount
* Added function "getChangePaymentsLabel" to generate label from changePayments
* Added function "generateChangePayment" to generate changePayments

---
M web-jspack/org.openbravo.pos2/src/model/ticket/CalculateChange.js
---
(0162668)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1326266b22d6e43b40e552273d0260359ce89c09
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1326266b22d6e43b40e552273d0260359ce89c09 [^]

Related to ISSUE-54914: Updated MultiCurrencyChangeDialog to support payment subtotal
* When setting max value in MultiCurrencyChange Dialog,
  other change payment has to be adjusted.

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/Dialogs/MultiCurrencyChange/MultiCurrencyChange.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/Dialogs/MultiCurrencyChange/MultiCurrencyChangeDialog/MultiCurrencyChangeDialog.jsx
---
(0162669)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0857ad17087353de4b8e08602ac1cdd89873e5f4
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0857ad17087353de4b8e08602ac1cdd89873e5f4 [^]

Related to ISSUE-54914: Updated SetTicketChangePayments action to support payment subtotals
* Used generateChangePayment function to update changePayments

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetTicketChangePayments.js
---
(0162670)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7d51aa2cda69c0a12a21d4cce0938234640576f3
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7d51aa2cda69c0a12a21d4cce0938234640576f3 [^]

Related to ISSUE-54914: Update Payment subtotal CSS to support multicurrency change

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentAmount.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentList.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalAction.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFooter.scss
---
(0162671)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0e00fa7b2e6b3375e0c53efc1b0b8ffa6a95d4e6
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0e00fa7b2e6b3375e0c53efc1b0b8ffa6a95d4e6 [^]

Related to ISSUE-54914: Added test to support multicurrency change for payment subtotals

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/__test__/SubtotalFooter.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/__test__/PaymentPanelTitle.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/CalculateChange.test.js
---
(0162672)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0fd57f13f359f1a434f78cc4334e58b5264b4789
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0fd57f13f359f1a434f78cc4334e58b5264b4789 [^]

Related to ISSUE-54914: Added cypress tests for multicurrency change in payment subtotals

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/changePayments.spec.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/SubtotalFooter.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/Dialogs/MultiCurrencyChange/MultiCurrencyChangeDialog/MultiCurrencyChangeDialog.jsx
---
(0162673)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 32cff661c6727ade0b4abde23bde99f2e095ae3e
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 27-03-2024 05:44:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/32cff661c6727ade0b4abde23bde99f2e095ae3e [^]

Related to ISSUE-54914: Added Payment key instead of identifier for currnecy change result

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/changePayments.spec.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelTitle/Dialogs/MultiCurrencyChange/MultiCurrencyChangeDialog/MultiCurrencyChangeDialog.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetTicketChangePayments.js
---
(0162674)
hgbot   
2024-03-27 06:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/91 [^]
(0162675)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 812f4a2401edf694c6ef620a7bb583ab21becd25
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 26-03-2024 16:05:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/812f4a2401edf694c6ef620a7bb583ab21becd25 [^]

Related to ISSUE-54914: Updated Cash AED to AUD in Touchpoint VBS-4

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_CURRENCYROUNDING.xml
---
(0162676)
hgbot   
2024-03-27 06:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/82 [^]
(0162677)
hgbot   
2024-03-27 06:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 25cc97f12eb0957ded2746f98b4ecd41930d8696
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 22-03-2024 10:09:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/25cc97f12eb0957ded2746f98b4ecd41930d8696 [^]

Related to ISSUE-54914: Added Currency rounding for AUD Currency in Vallblanca store

---
M referencedata/sampledata/The_White_Valley_Group/FIN_FINANCIAL_ACCOUNT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT.xml
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---