0005487: Check if database and user exists before cleaning/creating

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0005487

Openbravo ERP

Y. DBSourceManager

public

2008-10-09 13:27

2025-01-09 03:52

Reporter

gforcada

Assigned To

marvintm

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0005487: Check if database and user exists before cleaning/creating

Description

While trying to install Openbravo 2.40 I found this:

      [sql] Executing commands
      [sql] Failed to execute: DROP DATABASE openbravo240
      [sql] org.postgresql.util.PSQLException: ERROR: database "openbravo240" does not exist
      [sql] 0 of 1 SQL statements executed successfully

I didn't have used a database named openbravo240 it displays an error while trying to clean it

      [sql] Failed to execute: DROP ROLE tad
      [sql] org.postgresql.util.PSQLException: ERROR: role "tad" cannot be dropped because some objects depend on it
      [sql] Detail: owner of database openbravo
      [sql] 1963 objects in database openbravo
      [sql] 0 of 1 SQL statements executed successfully

prepare.database:

POSTGRE.structure:
      [sql] Executing commands
      [sql] Failed to execute: CREATE ROLE tad LOGIN PASSWORD 'TAD' SUPERUSER CREATEDB CREATEROLE VALID UNTIL 'infinity'
      [sql] org.postgresql.util.PSQLException: ERROR: role "tad" already exists
      [sql] 1 of 2 SQL statements executed successfully

I have a previous installation the user already exists so revoking permissions and creating gives errors.

I mark this issue as minor since this errors doesn't block the installation, but they should be fixed.

Steps To Reproduce

Create a new installation with a new database name and with a previously created postgreSQL user.

Proposed Solution

Before cleaning the database it should be checked if the database exists.

And before revoking and creating the user it should be checked if the user already exists.

Additional Information