Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054856POS2POSpublic2024-03-06 12:062024-03-27 11:58
Reporterjustin_patterson 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054856: RM-11688 - Enhancements in the Subscriptions to manage consent/no consent, active/unactive
DescriptionEnhancements in the Subscriptions to manage consent/no consent, active/unactive
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-03-06 12:06justin_pattersonNew Issue
2024-03-06 12:06justin_pattersonAssigned To => Retail
2024-03-06 12:06justin_pattersonTriggers an Emergency Pack => No
2024-03-06 12:08hgbotNote Added: 0161757
2024-03-06 12:13hgbotNote Added: 0161758
2024-03-07 18:27hgbotNote Added: 0161865
2024-03-08 12:34hgbotNote Added: 0161891
2024-03-19 17:07hgbotNote Added: 0162374
2024-03-19 17:10hgbotNote Added: 0162375
2024-03-26 13:58hgbotResolutionopen => fixed
2024-03-26 13:58hgbotStatusnew => closed
2024-03-26 13:58hgbotNote Added: 0162643
2024-03-26 13:58hgbotNote Added: 0162644
2024-03-26 13:58hgbotNote Added: 0162645
2024-03-26 13:58hgbotNote Added: 0162646
2024-03-26 13:58hgbotNote Added: 0162647
2024-03-26 13:58hgbotNote Added: 0162648
2024-03-26 13:58hgbotNote Added: 0162650
2024-03-26 13:58hgbotNote Added: 0162652
2024-03-26 13:58hgbotNote Added: 0162654
2024-03-27 11:43hgbotNote Added: 0162695
2024-03-27 11:43hgbotNote Added: 0162696
2024-03-27 11:58hgbotNote Added: 0162700
2024-03-27 11:58hgbotNote Added: 0162701
2024-03-27 11:58hgbotNote Added: 0162702
2024-03-27 11:58hgbotNote Added: 0162703

Notes
(0161757)
hgbot   
2024-03-06 12:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/merge_requests/5 [^]
(0161758)
hgbot   
2024-03-06 12:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/merge_requests/2 [^]
(0161865)
hgbot   
2024-03-07 18:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/57 [^]
(0161891)
hgbot   
2024-03-08 12:34   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/87 [^]
(0162374)
hgbot   
2024-03-19 17:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs.api/-/merge_requests/10 [^]
(0162375)
hgbot   
2024-03-19 17:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/16 [^]
(0162643)
hgbot   
2024-03-26 13:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty [^]
Changeset: fcb8084b9f96a9bf13fad73fd3bc7507589996d9
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 26-03-2024 12:58:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/commit/fcb8084b9f96a9bf13fad73fd3bc7507589996d9 [^]

Fixes FR-54856: Enhancements in the Subscriptions to manage consent/no consent, active/unactive
    -Add new column
    -Modify main check in discountsByLoyaltyUtils.test.js to account for new
    consentCatDiscounts property on business partner's
    business partner's subscription status to make sure consent is given
    before applying discounts
    -Added corresponding logic to tests

---
A src-db/database/model/modifiedTables/OBLP_STATUS.xml
A src/org/openbravo/retail/discounts/loyalty/master/LoyaltySubscriptionPropertyExtension.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web-test/model/business-logic/discounts-engine/utils/discountsByLoyaltyUtils.test.js
M web/org.openbravo.retail.discounts.loyalty/app/model/business-logic/discounts-engine/utils/discountsByLoyaltyUtils.js
---
(0162644)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/merge_requests/5 [^]
(0162645)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/merge_requests/2 [^]
(0162646)
hgbot   
2024-03-26 13:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty [^]
Changeset: 2dfafec14d823794d3c5c0afc977b387710d72b5
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 26-03-2024 12:58:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/commit/2dfafec14d823794d3c5c0afc977b387710d72b5 [^]

Fixes FR-54856: Enhancements in the Subscriptions to manage consent/no consent, active/unactive
    -Add new column
    -Modify main check in registerOTFRulesFilterHook.js to account for new
    consentCatGenCoupon property on business partner's
    subscription status to make sure consent is given
    before applying OTF Coupons
    -Added corresponding logic to tests

---
A src-db/database/model/modifiedTables/OBLP_STATUS.xml
A src/org/openbravo/retail/discounts/coupons/otf/loyalty/master/LoyaltyStatusPropertyExtension.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web-jspack/org.openbravo.retail.discounts.coupons.otf.loyalty/src/model/global/__test__/registerFilterOTFRulesHook.test.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf.loyalty/src/model/global/actions/registerOTFRulesFilterHook.js
---
(0162647)
hgbot   
2024-03-26 13:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 7ca282d191364db86a5d07c45d2a465c3d32182d
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 26-03-2024 12:58:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/7ca282d191364db86a5d07c45d2a465c3d32182d [^]

Fixes FR-54856: Enhancements in the Subscriptions to manage consent/no consent, active/unactive
-Exposed obrlpLoyaltyProgramStatusIds on the Business Partner MasterData model
-Added new property to CRM dataset
-Added status ids to Business Partner model in Enyo

---
M referencedata/standard/Loyalty_Properties_for_the_Openbravo_Customers_CRM_Connector.xml
M src-db/database/sourcedata/AD_DATASET.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src/org/openbravo/retail/loyalty/programs/master/BusinessPartnerProperties.java
M web/org.openbravo.retail.loyalty.programs/js/model/businesspartner.js
---
(0162648)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/57 [^]
(0162650)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/16 [^]
(0162652)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs.api/-/merge_requests/10 [^]
(0162654)
hgbot   
2024-03-26 13:58   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/87 [^]
(0162695)
hgbot   
2024-03-27 11:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/merge_requests/3 [^]
(0162696)
hgbot   
2024-03-27 11:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/merge_requests/6 [^]
(0162700)
hgbot   
2024-03-27 11:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty [^]
Changeset: 13fc4887d63fdfc100051ed06baa39c6d52ee33c
Author: Jorge Wederago <j.wederago@orisha.com>
Date: 27-03-2024 11:38:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/commit/13fc4887d63fdfc100051ed06baa39c6d52ee33c [^]

Related to ISSUE-54856: Enhancements in the Subscriptions to manage consent/no consent, active/unactive
*Fix AD_Element

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0162701)
hgbot   
2024-03-27 11:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf.loyalty/-/merge_requests/3 [^]
(0162702)
hgbot   
2024-03-27 11:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty [^]
Changeset: 0276bfed4fa5504fe00351b4adb5dc7556b3524e
Author: Jorge Wederago <j.wederago@orisha.com>
Date: 27-03-2024 11:38:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/commit/0276bfed4fa5504fe00351b4adb5dc7556b3524e [^]

Related to ISSUE-54856: Enhancements in the Subscriptions to manage consent/no consent, active/unactive
> *Fix AD_Element

---
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0162703)
hgbot   
2024-03-27 11:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.loyalty/-/merge_requests/6 [^]