Openbravo Issue Tracking System - POS2
View Issue Details
0054846POS2POSpublic2024-03-05 15:022024-04-25 08:23
ucarrion 
javierRodriguez 
highmajoralways
closedfixed 
5
 
24Q3 
guilleaer
No
0054846: Unexpected popup while refunding a gift card
The popup I get while performing the refund of a gift card is NOT the one expected. It seems like it is displaying a random one.
Videos below:
https://vimeo.com/919603869/a0918cc7fa?share=copy [^]
https://vimeo.com/919604846/6773566cde?share=copy [^]
The expected popup once in the gift card refunding if the return reson one (including return reason and the product condition).
No tags attached.
depends on backport 005531024Q2 closed javierRodriguez POS2 Unexpected popup while refunding a gift card 
related to defect 0054690 closed javierRodriguez Retail Modules implement giftcard refund in pos2 
Issue History
2024-03-05 15:02ucarrionNew Issue
2024-03-05 15:02ucarrionAssigned To => Retail
2024-03-05 15:02ucarrionTriggers an Emergency Pack => No
2024-03-05 15:02ucarrionIssue Monitored: avicente
2024-03-11 16:55guilleaerStatusnew => scheduled
2024-03-11 16:55guilleaerAssigned ToRetail => javierRodriguez
2024-03-12 15:40javierRodriguezNote Added: 0162030
2024-03-12 15:40javierRodriguezStatusscheduled => closed
2024-03-12 18:04avicenteNote Added: 0162037
2024-03-12 18:04avicenteStatusclosed => new
2024-03-18 17:46avicenteNote Added: 0162307
2024-04-08 08:45guilleaerStatusnew => scheduled
2024-04-22 09:32hgbotResolutionopen => fixed
2024-04-22 09:32hgbotStatusscheduled => resolved
2024-04-22 09:32hgbotNote Added: 0163488
2024-04-22 09:32guilleaerReview Assigned To => guilleaer
2024-04-22 09:32guilleaerStatusresolved => closed
2024-04-22 09:32guilleaerFixed in Version => 24Q3
2024-04-22 09:34guilleaerRelationship addedrelated to 0054690
2024-04-25 08:23guilleaerStatusclosed => new
2024-04-25 08:23guilleaerResolutionfixed => open
2024-04-25 08:23guilleaerFixed in Version24Q3 =>
2024-04-25 08:23guilleaerStatusnew => scheduled
2024-04-25 08:23guilleaerStatusscheduled => resolved
2024-04-25 08:23guilleaerFixed in Version => 24Q3
2024-04-25 08:23guilleaerResolutionopen => fixed
2024-04-25 08:23guilleaerStatusresolved => closed

Notes
(0162030)
javierRodriguez   
2024-03-12 15:40   
Refund gift card user action is launching other user action (add product, set line price, etc) and, for the moment, it is not possible to skip some requested data such as the reason flow.

Due to that, the issue is not valid until the skip reason feature is implemented
(0162037)
avicente   
2024-03-12 18:04   
Hi Javier,

Please contact me, I'll explain the bug. A wrong user action input is displayed. It must be the same that for any return.

Regards,
Amaya
(0162307)
avicente   
2024-03-18 17:46   
After discusing, there are two approach to get the return reasons pop up when refund a gift card,

1) When a gift card refund is done in POS, to use the user action 'Convert to Return' instead add product, set line price, etc...
2) Create a new user action 'Gift Card Refund' + use the user actions defined for returns for the new one.
(0163488)
hgbot   
2024-04-22 09:32   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 67780f727254f959f20c5e9bb89fb5b2cd33fb29
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 22-04-2024 07:31:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/67780f727254f959f20c5e9bb89fb5b2cd33fb29 [^]

Fixed ISSUE-54846: Refactor refund giftcard user action

---
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/RefundGiftCard.js
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/__test__/RefundGiftCard.test.js
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/user-actions/RefundGiftCard.js
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/user-actions/__test__/RefundGiftCard.test.js
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
M web-jspack/org.openbravo.retail.giftcards/src/services/gift-card/cancelGiftCard.js
---