Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054845POS2POSpublic2024-03-05 14:522024-03-25 09:00
ReporterjavierRodriguez 
Assigned ToRajesh_18 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054845: inconsistency between new tickets and loaded tickets regarding isConfigurable attribute
DescriptionIf the user creates a brand new ticket and an item is added, the new line has an attribute called isConfigurable.
If the user completes the ticket and then the ticket is loaded again, the isConfigurable attribute is not included inside the line.

After this explanation, I will explain what happened with this regression: https://issues.openbravo.com/view.php?id=54810 [^]

Due to the gift card refund project, it was necessary to do a little change in product configuration checker. The developer did some manual tests with draft orders and everything looks correct.

After this, the developer sent the project to try-pos2 and everything was green so, apparently, it was possible to merge the project.

Finally, some core functionality was broken due to the merge. For example verified return and cancel and replace.
Steps To Reproduce- create a new ticket
- add a product
- check the line has isConfigurable attribute
- complete the ticket


- load the ticket previously created
- KO, the line has not isConfigurable attribute
Proposed SolutionIn this particular case, isConfigurable attribute should bee in the load ticket line but in general, loaded tickets should be as equal as possible as a draft ticket.

Apart from that, it is necessary to create cypress test to check basic core flows. For the moment, return a verified ticket and cancel and replace.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-03-05 14:52javierRodriguezNew Issue
2024-03-05 14:52javierRodriguezAssigned To => Retail
2024-03-05 14:52javierRodriguezTriggers an Emergency Pack => No
2024-03-05 15:06jorgewederagoIssue Monitored: jorgewederago
2024-03-05 15:26guilleaerNote Added: 0161670
2024-03-06 16:54guilleaerStatusnew => acknowledged
2024-03-08 06:33Rajesh_18Assigned ToRetail => Rajesh_18
2024-03-08 10:25Rajesh_18Statusacknowledged => scheduled
2024-03-13 13:01hgbotNote Added: 0162084
2024-03-18 16:13hgbotResolutionopen => fixed
2024-03-18 16:13hgbotStatusscheduled => resolved
2024-03-18 16:13hgbotFixed in Version => 24Q2
2024-03-18 16:13hgbotNote Added: 0162287
2024-03-18 16:13hgbotNote Added: 0162288
2024-03-18 16:18javierRodriguezStatusresolved => closed
2024-03-22 11:14hgbotNote Added: 0162547
2024-03-25 09:00hgbotNote Added: 0162566
2024-03-25 09:00hgbotNote Added: 0162567

Notes
(0161670)
guilleaer   
2024-03-05 15:26   
Retail team considers this issue important. This is the reason to add a due date
(0162084)
hgbot   
2024-03-13 13:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2494 [^]
(0162287)
hgbot   
2024-03-18 16:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 312fb6937786cfe18c6c6bb3b686d03db0b9776d
Author: Rajesh Senthilkumar <rajesh.senthilkumar.ext@openbravo.com>
Date: 18-03-2024 15:13:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/312fb6937786cfe18c6c6bb3b686d03db0b9776d [^]

Fixed ISSUE-54845: Added isConfigurable property for loaded orders

---
A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/verifiedReturns.spec.js
A web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/e2eFixtures/VerifiedReturns.json
A web-jspack/org.openbravo.pos2/src/model/global/__test__/AddProductConfigurationToTicket.test.js
A web-jspack/org.openbravo.pos2/src/model/global/actions/AddProductConfigurationToTicket.js
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/cancelAndReplace.spec.js
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/ticket.js
M web-jspack/org.openbravo.pos2/src-test/cypress/runAllSpecs/runFeaturesSpecsPOS2.spec.js
M web-jspack/org.openbravo.pos2/src/model/global/GlobalExtension.js
---
(0162288)
hgbot   
2024-03-18 16:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2494 [^]
(0162547)
hgbot   
2024-03-22 11:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2518 [^]
(0162566)
hgbot   
2024-03-25 09:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2518 [^]
(0162567)
hgbot   
2024-03-25 09:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9dd4aa049ec328aae642e06ecb0a7031160874eb
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 25-03-2024 07:59:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9dd4aa049ec328aae642e06ecb0a7031160874eb [^]

Fixed ISSUE-54845: Refactored Cypress test for cancel and replace

---
M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/cancelAndReplace.spec.js
---