Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054801POS2Corepublic2024-02-29 13:322024-03-12 08:42
Reportersofia_rodriguez 
Assigned Tojarmendariz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelQA functional test
Regression date2024-02-26
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/01c9d899e4fab5431f3ab1d2d87c92297fcf464d#b0355695de6e0c5a8b39c93ebb663b546919496b_85_84 [^]
Triggers an Emergency PackNo
Summary0054801: Error while forcing "Close Tills" from Backend
DescriptionAn error pop up is diplayed when trying to force the closing of a till from the backend (Column "Open Till" = YES).

This error is preventing the user from closing the till.
Steps To Reproduce1. Open the "Terminals and Tills status" window in the backend
2. Select a line with the field "Open Till" = YES
3. Click on the "Close Till" button and the on the "OK" button from the confirmation pop up.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0051321 closed jarmendariz Openbravo ERP Improve CSRF coverage to cover some missing POST requests 
has duplicate defect 0054904 closed Retail Retail Modules "Save Again" does not work when trying to reprcoess an -errors while importing- 
has duplicate defect 0054905 closed Triage Platform Base Retail Modules Error message while closing tills in Terminal&Tills 
Attached Files? Error forcing close till.mp4 (1,659,129) 2024-02-29 13:32
https://issues.openbravo.com/file_download.php?file_id=19506&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-02-29 13:32sofia_rodriguezNew Issue
2024-02-29 13:32sofia_rodriguezAssigned To => Triage Platform Base
2024-02-29 13:32sofia_rodriguezFile Added: Error forcing close till.mp4
2024-02-29 13:32sofia_rodriguezTriggers an Emergency Pack => No
2024-03-11 10:27AugustoMauchRelationship addedcaused by 0051321
2024-03-11 10:28AugustoMauchRegression level => QA functional test
2024-03-11 10:28AugustoMauchRegression date => 2024-02-26
2024-03-11 10:28AugustoMauchRegression introduced in release => pi
2024-03-11 10:28AugustoMauchRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/01c9d899e4fab5431f3ab1d2d87c92297fcf464d#b0355695de6e0c5a8b39c93ebb663b546919496b_85_84 [^]
2024-03-11 10:32AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2024-03-11 10:32AugustoMauchAssigned ToAugustoMauch => jarmendariz
2024-03-11 10:55AugustoMauchRelationship addedhas duplicate 0054904
2024-03-11 10:57AugustoMauchStatusnew => scheduled
2024-03-11 10:57AugustoMauchRelationship addedhas duplicate 0054905
2024-03-11 13:56hgbotNote Added: 0161960
2024-03-11 15:34hgbotNote Added: 0161964
2024-03-11 16:15hgbotNote Added: 0161972
2024-03-11 17:04hgbotNote Added: 0161977
2024-03-12 08:39hgbotNote Added: 0161984
2024-03-12 08:39hgbotNote Added: 0161985
2024-03-12 08:41hgbotNote Added: 0161986
2024-03-12 08:41hgbotNote Added: 0161987
2024-03-12 08:42hgbotNote Added: 0161988
2024-03-12 08:42hgbotNote Added: 0161989
2024-03-12 08:42hgbotResolutionopen => fixed
2024-03-12 08:42hgbotStatusscheduled => closed
2024-03-12 08:42hgbotNote Added: 0161990
2024-03-12 08:42hgbotNote Added: 0161991

Notes
(0161960)
hgbot   
2024-03-11 13:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/115 [^]
(0161964)
hgbot   
2024-03-11 15:34   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1165 [^]
(0161972)
hgbot   
2024-03-11 16:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1503 [^]
(0161977)
hgbot   
2024-03-11 17:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/230 [^]
(0161984)
hgbot   
2024-03-12 08:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 7aa3d2cb4f5d5df2767370085ecdb275fa91e36d
Author: Javier Armendáriz <j.armendariz@orisha.com>
Date: 12-03-2024 07:38:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/7aa3d2cb4f5d5df2767370085ecdb275fa91e36d [^]

Related to ISSUE-54801: Fixing request call to Save Again action in Errors while importing Window

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/SaveDataActionHandler.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/SaveDataOnProcessHandler.java
M web/org.openbravo.warehouse.advancedwarehouseoperations/js/obawo-erp-errors.js
---
(0161985)
hgbot   
2024-03-12 08:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/230 [^]
(0161986)
hgbot   
2024-03-12 08:41   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a1f971d96d768efa3c7a4ee29c94b3c927206f60
Author: Javier Armendáriz <j.armendariz@orisha.com>
Date: 12-03-2024 07:41:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a1f971d96d768efa3c7a4ee29c94b3c927206f60 [^]

Related to ISSUE-54801: Refactored clear errors request to pass an object instead of an array as a parameter

---
M src/org/openbravo/retail/posterminal/ClearErrorActionHandler.java
M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java
M src/org/openbravo/retail/posterminal/SaveDataOnProcessHandler.java
M web/org.openbravo.retail.posterminal/js/components/errors.js
---
(0161987)
hgbot   
2024-03-12 08:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1503 [^]
(0161988)
hgbot   
2024-03-12 08:42   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 26f957a246ef24ad3ca1a421ecf9b6c0505b69bc
Author: Javier Armendáriz <j.armendariz@orisha.com>
Date: 11-03-2024 15:30:55
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/26f957a246ef24ad3ca1a421ecf9b6c0505b69bc [^]

Related to ISSUE-54801: CSRF Token not performed on requests on which body is an array

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-remote-call-manager.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseActionHandler.java
---
(0161989)
hgbot   
2024-03-12 08:42   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1165 [^]
(0161990)
hgbot   
2024-03-12 08:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 5a60bf85000d6e0b03b3f405e408b01256db103b
Author: Javier Armendáriz <j.armendariz@orisha.com>
Date: 11-03-2024 13:54:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/5a60bf85000d6e0b03b3f405e408b01256db103b [^]

Fixed ISSUE-54801: Error while closing tills from backoffice

The error was caused because the Close Till request assumes that the request body is only the array of tills
to close, but it can contain additional parameters such as the CSRF Token. For this reason, the request parameters
have been changed to be always an object and put the list of ids as a property of the request object.

---
M src/org/openbravo/retail/sessions/CloseSessionActionHandler.java
M web/org.openbravo.retail.sessions/js/erp/closesessionprocess.js
---
(0161991)
hgbot   
2024-03-12 08:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/115 [^]