Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054768Openbravo ERPA. Platformpublic2024-02-27 08:322024-10-19 09:52
Reportermalsasua 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054768: compilation error: [java] org.postgresql.util.PSQLException: Bad value for type int : 2173831272
DescriptionExecuting update.database command, error is happening when the postgresql OID assigned to functions is higher than max int value (2,147,483,647).

To check what is the OID assigned for each function:
SELECT proname, oid, proconfig FROM pg_proc order by oid desc;


The OID is read in update.database command using getInt function. For this reason, when this value is higher than max INT value, the below error is raised:

[java] org.postgresql.util.PSQLException: Bad value for type int : 2173831272
     [java] at org.postgresql.jdbc.PgResultSet.toInt(PgResultSet.java:2834) ~[postgresql-42.2.2.jre7.jar:42.2.2.jre7]
     [java] at org.postgresql.jdbc.PgResultSet.getInt(PgResultSet.java:2067) ~[postgresql-42.2.2.jre7.jar:42.2.2.jre7]
     [java] at org.apache.commons.dbcp.DelegatingResultSet.getInt(DelegatingResultSet.java:225) ~[commons-dbcp-1.4.jar:1.4]
     [java] at org.apache.commons.dbcp.DelegatingResultSet.getInt(DelegatingResultSet.java:225) ~[commons-dbcp-1.4.jar:1.4]
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlModelLoader$1.fillRow(PostgreSqlModelLoader.java:432) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.fillList(ModelLoaderBase.java:871) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlModelLoader.readFunction(PostgreSqlModelLoader.java:429) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.ModelLoaderBase$28.getRow(ModelLoaderBase.java:661) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.readList(ModelLoaderBase.java:816) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.readFunctions(ModelLoaderBase.java:657) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.ModelLoaderBase.readDatabase(ModelLoaderBase.java:216) ~[dbsourcemanager.jar:?]
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlModelLoader.readDatabase(PostgreSqlModelLoader.java:90) ~[dbsourcemanager.jar:?]
Steps To ReproducePreparation
- create enough database objects (roughly 2,147,483,647)
  - It should be enough to create+drop objects just to drive up oid usage
  - There is be NO need to keep all all those objects at once
  - oid are global per database so type of objects created should not matter

- drop function next_day (to force its recreation)
- run update.database to recreate that function
- check that "SELECT proname, oid, proconfig FROM pg_proc where proname = 'next_day' returns number high enough
Reproducer:
- Run update.database
- Step reading model will read functions and trip over the high value

Note:
- next_day function is just example function to trigger this issue
- Should work for any function being read during 'Reading functions...' step
  I.e. everything not in excludeFilter.xml
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0054980 new Triage Platform Base Audit Trail infrestrucuture is creating temporary tables that could end on getting the limit of elements created in postgresql 
related to defect 0056837 closed AugustoMauch compilation error: [java] org.postgresql.util.PSQLException: Bad value for type int : 2173831272 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-02-27 08:32malsasuaNew Issue
2024-02-27 08:32malsasuaAssigned To => Triage Platform Base
2024-02-27 08:32malsasuaModules => Core
2024-02-27 08:32malsasuaTriggers an Emergency Pack => No
2024-02-27 08:33malsasuaPriorityhigh => urgent
2024-02-27 09:47shuehnerDescription Updatedbug_revision_view_page.php?rev_id=27600#r27600
2024-02-27 09:47shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27602#r27602
2024-02-27 09:52shuehnerNote Added: 0161291
2024-02-27 11:55hgbotNote Added: 0161300
2024-02-27 11:56hgbotNote Added: 0161301
2024-03-18 12:38egoitzRelationship addedrelated to 0054980
2024-09-10 16:56AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2024-09-10 16:57AugustoMauchStatusnew => acknowledged
2024-09-24 17:51hgbotResolutionopen => fixed
2024-09-24 17:51hgbotStatusacknowledged => closed
2024-09-24 17:51hgbotNote Added: 0169545
2024-09-24 17:51hgbotNote Added: 0169546
2024-09-24 17:51hgbotNote Added: 0169547
2024-09-24 17:51hgbotFixed in Version => PR24Q4
2024-09-24 17:51hgbotNote Added: 0169548
2024-10-19 09:52AugustoMauchIssue cloned0056837
2024-10-19 09:53AugustoMauchRelationship addedrelated to 0056837

Notes
(0161291)
shuehner   
2024-02-27 09:52   
Error observed is likely coming from here:
https://gitlab.com/openbravo/product/dbsm/-/blob/master/src/org/apache/ddlutils/platform/postgresql/PostgreSqlModelLoader.java?ref_type=heads#L436 [^]

Where we read list of functions (including their oid)
to later in a loop using this oid to retrieve more data

NOTE:
- We need to check more oid + getInt usage.
- Not just in git master but also against the target version for customer backport (19Q3-ish) of this bug-reprt
- It looks like that older code has another oid-usage not present (or just in different place in git master)
  see same file:_stmt_oids_tables
(0161300)
hgbot   
2024-02-27 11:55   
Merge Request created: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/46 [^]
(0161301)
hgbot   
2024-02-27 11:56   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1153 [^]
(0169545)
hgbot   
2024-09-24 17:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/dbsm [^]
Changeset: e38ac5a01677cb654de360cce040a6b4a96993c3
Author: Asier Lostalé <a.lostale@orisha.com>
Date: 23-09-2024 21:06:14
URL: https://gitlab.com/openbravo/product/dbsm/-/commit/e38ac5a01677cb654de360cce040a6b4a96993c3 [^]

fixes BUG-54768: error reading functions if oid excedes max int value

When oid excedes the maximum value for int in Java, an error is thrown reading
functions from pg catalog.

Changed to read them as long instead of integer.

---
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlModelLoader.java
---
(0169546)
hgbot   
2024-09-24 17:51   
Merge request merged: https://gitlab.com/openbravo/product/dbsm/-/merge_requests/46 [^]
(0169547)
hgbot   
2024-09-24 17:51   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1153 [^]
(0169548)
hgbot   
2024-09-24 17:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 30a202d72fe0343c626c7910a8aac7eab2e9aed1
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 23-09-2024 23:09:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/30a202d72fe0343c626c7910a8aac7eab2e9aed1 [^]

fixes BUG-54768: error reading functions if oid excedes max int value

---
M src-db/database/lib/dbsourcemanager.jar
---