Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0005476 | Openbravo ERP | C. Security | public | 2008-10-09 10:01 | 2009-04-21 11:07 |
|
| Reporter | villind | |
| Assigned To | Hennadzi | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.40 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0005476: Null pointer accress in "CopyFromInvoice" exception handler |
| Description | - Catch block uses un-initialized OBError variable
- Catch block prints stack trace to standard err instead of logging it |
| Steps To Reproduce | |
| Proposed Solution | See the attached patch |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0005478 | | closed | Hennadzi | Null pointer accress in "CopyFromInvoice" exception handler |
|
| Attached Files |  CopyFromInvoice-Nullpointer-fix.diff (777) 2008-10-09 10:01
https://issues.openbravo.com/file_download.php?file_id=312&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2008-10-09 10:01 | villind | New Issue | |
| 2008-10-09 10:01 | villind | Assigned To | => cromero |
| 2008-10-09 10:01 | villind | sf_bug_id | 0 => 2154624 |
| 2008-10-09 10:01 | villind | File Added: CopyFromInvoice-Nullpointer-fix.diff | |
| 2008-10-09 10:01 | villind | Regression testing | => No |
| 2008-10-09 10:05 | svnbot | Checkin | |
| 2008-10-09 10:05 | svnbot | Note Added: 0009476 | |
| 2008-10-09 10:05 | svnbot | Status | new => resolved |
| 2008-10-09 10:05 | svnbot | Resolution | open => fixed |
| 2008-10-09 10:05 | svnbot | svn_revision | => 8445 |
| 2008-10-09 10:12 | cromero | Status | resolved => new |
| 2008-10-09 10:12 | cromero | Resolution | fixed => open |
| 2008-10-09 10:12 | cromero | Status | new => scheduled |
| 2008-10-09 10:12 | cromero | fix_in_branch | => trunk |
| 2008-11-10 13:04 | cromero | Assigned To | cromero => rafaroda |
| 2008-11-13 21:56 | rafaroda | Assigned To | rafaroda => Dowid |
| 2008-11-13 23:56 | rafaroda | Assigned To | Dowid => Hennadzi |
| 2008-12-12 14:36 | svnbot | Checkin | |
| 2008-12-12 14:36 | svnbot | Note Added: 0011245 | |
| 2008-12-12 14:36 | svnbot | Status | scheduled => resolved |
| 2008-12-12 14:36 | svnbot | Resolution | open => fixed |
| 2008-12-12 14:36 | svnbot | svn_revision | 8445 => 11157 |
| 2008-12-12 15:06 | shuehner | Status | resolved => new |
| 2008-12-12 15:06 | shuehner | Resolution | fixed => open |
| 2008-12-12 15:06 | shuehner | Note Added: 0011247 | |
| 2008-12-12 15:07 | shuehner | Note Added: 0011248 | |
| 2008-12-12 15:24 | svnbot | Checkin | |
| 2008-12-12 15:24 | svnbot | Note Added: 0011251 | |
| 2008-12-12 15:24 | svnbot | Status | new => resolved |
| 2008-12-12 15:24 | svnbot | Resolution | open => fixed |
| 2008-12-12 15:24 | svnbot | svn_revision | 11157 => 11159 |
| 2009-04-21 11:07 | psarobe | Status | resolved => closed |
|
Notes |
|
|
(0009476)
|
|
svnbot
|
|
2008-10-09 10:05
|
|
Repository: openbravo
Revision: 8445
Author: villind
Date: 2008-10-09 10:05:04 +0200 (Thu, 09 Oct 2008)
Fixes issue 5476. Proper exception handling in copuFromInvoice.processButton()
---
U branches/bonware/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
---
https://dev.openbravo.com/websvn/openbravo/?rev=8445&sc=1 [^]
|
|
|
|
(0011245)
|
|
svnbot
|
|
2008-12-12 14:36
|
|
Repository: openbravo
Revision: 11157
Author: hennadzi
Date: 2008-12-12 14:36:13 +0100 (Fri, 12 Dec 2008)
Fixed bug 0005476: Null pointer accress in "CopyFromInvoice" exception handler
---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
---
https://dev.openbravo.com/websvn/openbravo/?rev=11157&sc=1 [^]
|
|
|
|
|
|
Your commit only addresses the first line of the issue (fix the NPE) it does not address the better logging. Can you please recheck and compare the commit with the patch attached to the issue? |
|
|
|
|
|
Same note applies to the backport to 2.40 as well. |
|
|
|
(0011251)
|
|
svnbot
|
|
2008-12-12 15:24
|
|
Repository: openbravo
Revision: 11159
Author: hennadzi
Date: 2008-12-12 15:24:49 +0100 (Fri, 12 Dec 2008)
Fixed bug 0005476: Null pointer accress in "CopyFromInvoice" exception handler
---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
---
https://dev.openbravo.com/websvn/openbravo/?rev=11159&sc=1 [^]
|
|