0054755: Drawer re opens itself after finishing cash up

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054755

POS2

POS

public

2024-02-08 18:15

2024-02-23 13:13

Reporter

Lcazaux

Assigned To

SABARINATH P

Priority

high

Severity

trivial

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

24Q1.1

Fixed in Version

24Q1.1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0054755: Drawer re opens itself after finishing cash up

Description

When doing a cash up, if I close my drawer before clicking “finish”, once I do click this button, the POS is closed, but the drawer re-opens itself.

This is wrong and could lead to issues with end-users.

Important remark: It only happens when counted cash is > 0€. If it is let to 0€ → it doesn't happen.

https://drive.google.com/file/d/1gx9Y1e8JdDR7nxSxtwCzy_7XPlWlvnBA/view?usp=drive_link [^]

Steps To Reproduce

Go to the POS
Do some sales, including with cash Payment Method (PM)
Go to cash up windows
Put “match expected” for all the PM including cash
Go to the next step
Close the drawer
Click on "finish" to finalize the cash up
You are logged out of the POS but the drawer re opened itself

Proposed Solution

Once closed during a cash up, the drawer should NEVER re-open itself.

ggi note:
This is related to the old implementation of open drawer in pos2 begginings.

The fix shold be just remove this post hook:
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b9955ab33916fce3234bb57629f9a5240af131eb#a8b5fe5f086f3e0cfd4e221128c3a714a223f8e4_82_84 [^]

Additional Information