Openbravo Issue Tracking System - Retail Modules
View Issue Details
0054727Retail ModulesWeb POSpublic2023-06-29 17:202024-03-18 13:26
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
RR23Q4.3 
No
0054727: Re-triage old issues which as mobile-test test-cases with waitFixOf waiting for them
We have around 41 different issues for which we have some testcases in mobile-test which are annotated with waitFixOf.

That means those test-cases are auto-disabled until the issue has been fixed.

However many of those issues are quite old (from 2015..2021).

We should triage each to decide if it is still valid / interesting.
Depending on the outcome either:
- no action (still valid)
- close issue as wontfix and also remove the test-case with waitForFix (as it is then just dead code)
Search for all unique value for waitFixOr in our mobile-test code

i.e. with something like this
grep -Ir "(waitFixOf" | cut -d'(' -f2 | cut -d')' -f1 | sort | uniq
No tags attached.
blocks defect 0052891 closed shuehner Re-triage old issues which as mobile-test test-cases with waitFixOf waiting for them 
Issue History
2024-02-20 13:34shuehnerTypedefect => backport
2024-02-20 13:34shuehnerTarget Version => RR23Q4.3
2024-03-15 13:30hgbotNote Added: 0162233
2024-03-18 13:26hgbotResolutionopen => fixed
2024-03-18 13:26hgbotStatusscheduled => closed
2024-03-18 13:26hgbotNote Added: 0162271
2024-03-18 13:26hgbotNote Added: 0162272
2024-03-18 13:26hgbotNote Added: 0162273

Notes
(0162233)
hgbot   
2024-03-15 13:30   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/379 [^]
(0162271)
hgbot   
2024-03-18 13:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: f1738c09438134aba2e80cbce33cda033a65685d
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 15-03-2024 13:21:04
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/f1738c09438134aba2e80cbce33cda033a65685d [^]

Fixed ISSUE-54727: Remove obsolete testcase with outdated waitFixOf

mobile-test code has feature to disable a test-case until after the
mantis issue is fixed by adding a waitFixOf annotation.

After triaging those issues delete many as obsolete.
As all those test-cases where disabled (via waitFixOf) no change in
test cases really being executed.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/initialchecks/InitialChecksSuite.java
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/RetailOrderLoaderTest.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/autoserviceprice/AutoServicePriceMultipleLine.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/autoserviceprice/AutoServicePriceRangeDiscount.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/complementaryproducts/I32743_HideComplementaryButtonInReceiptDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/contactinfoforproduct/CompleteReceiptwithContactInfo.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/deliverymodes/deliverymodesissue/DMI_04_AdvancedFiltersInIssueSalesOrder.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/CheckComboDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I34809_WrongCalculationOfComboDependingSequence.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I35583_VerifyComboFixPriceII.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I38074_VerifyComboFixedPriceDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I40831_VerifyDiscountWhenTwoCombosAreApplied.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I39673_VerifyMessageWhenUsingExpiredCoupon.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/CheckTwoFamiliesDiscounts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32421_TwoFamiliesWithSameProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32526_TwoFamiliesWithSameTwoProducts.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/externalbp/ExternalBPMultipleTickets.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/orderpreparationawo/OP_Test24_PickingsWithUngroupedProductWithGroupedServiceRelatedPerProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/orderpreparationawo/OP_Test25_PickingsWithUngroupedProductWithGroupedServiceRelatedUniqueQuantity.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/selfcheckout/BuyOneProduct.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/selfcheckout/SCOCashup.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I31827_Error401WhenCashup.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34252_VerifyCashUpWithoutCache.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/terminal_for_seller/TryToOpenStoreWithSeller.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/SplitLineWithAutomaticPromoTwoFamilyCombos.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32447_FilterByCharacteristicAndStockCriteria.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I32551_FilterByStockAndPriceCriteria.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockcriteria/I34531_FilterWithCombinationAndPatternContain.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpGroupingWithDifferentsBP.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashUpNoGroupingWithDifferentsBP.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I27754_ActiveInactivePaymentType.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28120_SameProductInTwoPacks.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I40197_ApplyDiscountByHours.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I27631_DocumentnoResetAfterChangingPrefix.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I28690_DocumentnoPrefixChangeAndSale.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifyWebPOSAPIs.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I27615_PartiallyPaidLayaway.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateBPandBPLocationAndAssignTicketOffline.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/CreateLayawayOffline.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/quotations/I27631_QuotationnoResetAfterChangingPrefix.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/quotations/I28690_QuotationnoPrefixChangeAndSale.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/HideActionButtons.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30794_NewCustomerAddProductNoAccessRights.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30997_NewCustomerForReceipt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32962_ReceiptCreateAssortmentAndLoaded.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I25623_VerifiedReturnsAvoidMoreThanOrdered.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMChangePricelistInLayaway.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMModifyPricelistSharedPayments.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromoDiscretionaryFixAmt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/splitline/SplitLineWithManualPromoUserDefAmt.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I29106_ConversionRateChange.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35040_RequestDuringChangeRoleAction.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/performance/ScanningPerformance.java
---
(0162272)
hgbot   
2024-03-18 13:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 8b9f9b95cf0e926d7ea240c5b84f2949b579a393
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 15-03-2024 13:21:28
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/8b9f9b95cf0e926d7ea240c5b84f2949b579a393 [^]

Fixed ISSUE-54727: Remove commented out waitFixOf

Remove already commented out waitFixOf annotation.
To avoid it coming up when searching for leftover waitFixOf

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31172_WrongPaymentScheduleDetailsOnLayaways.java
---
(0162273)
hgbot   
2024-03-18 13:26   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/379 [^]