Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054673POS2Corepublic2024-02-14 14:092024-05-13 10:42
ReporterNaroaIriarte 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054673: The exceptions handled in the backoffice should be managed per each developer and not in a general way
DescriptionCurrently, the exceptions generated in the backoffice are handled and this leads to some issues when the developers need to handle themselves in other code parts. This exception handling mechanism should be controlled or erased and let the developers that implement new code handle their exceptions.
Here is an example of the issue:
We are trying to show an error on a dialog but we always get the general popup error too. (image attached)
Steps To Reproduce-
Proposed SolutionErase the code that shows the popup error and let the developers handle their errors or add a parameter that can be set to true if error handling is needed, for example.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052342 closed caristu No error feedback provided in the UI when some requests fail 
related to feature request 0054436 acknowledged NaroaIriarte It should be possible to define the maximum amount for a Gift Certificate 
blocks defect 005536124Q2 scheduled SABARINATH P Undefined error message while refunding a gift card with no sales order line related 
Attached Filespng doubleError.png (64,698) 2024-02-14 14:09
https://issues.openbravo.com/file_download.php?file_id=19464&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-02-14 14:09NaroaIriarteNew Issue
2024-02-14 14:09NaroaIriarteAssigned To => Triage Platform Base
2024-02-14 14:09NaroaIriarteFile Added: doubleError.png
2024-02-14 14:09NaroaIriarteTriggers an Emergency Pack => No
2024-02-14 16:46NaroaIriarteRelationship addedrelated to 0054436
2024-05-06 17:47caristuNote Added: 0164120
2024-05-06 17:49caristuRelationship addedrelated to 0052342
2024-05-08 17:29guilleaerRelationship addedblocks 0055361
2024-05-08 17:34guilleaerRelationship addedblocks 0055330
2024-05-08 17:39guilleaerRelationship deletedblocks 0055330
2024-05-08 17:39guilleaerRelationship deletedblocks 0055361
2024-05-09 12:43guilleaerRelationship addedblocks 0055361
2024-05-13 10:42ucarrionNote Added: 0164479

Notes
(0164120)
caristu   
2024-05-06 17:47   
The logic that handles the display of those messages is centralized here[1]. If it is finally decided to show no message at all in an automatic way, the fix is just a matter of removing the "handleErrorInSuccessfulResponse" function and its usage.

Note that this can cause potential regressions on the code that is currently delegating to this function the display of the error messages. In such cases, the user would stop seeing the errors.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/network/RequestListener.js#L41 [^]
(0164479)
ucarrion   
2024-05-13 10:42   
Putting this issue as 'Gold' because is blocking a fix for ToysRUs. See the related Mantis https://issues.openbravo.com/view.php?id=55361 [^]