Openbravo Issue Tracking System - POS2
View Issue Details
0054671POS2POSpublic2024-02-14 12:582024-03-21 12:33
ruben_jimenez 
ruben_jimenez 
normalminorhave not tried
newopen 
5
 
 
No
0054671: Add digital coupons modules to pos2-modules context definition
org.openbravo.retail.digitalcoupons and org.openbravo.retail.digitalcoupons.sampledata need to be added to the pos2-modules context definition JSON.

Due to the new module org.openbravo.digitalcoupons, some IDs have been changed, causing failures in the CI/CD pipeline. For example: 'Expected to find element: [data-testid="obdico-digitalCouponDialog-addManually"], but never found it.'
at Context.digitalCouponFlowT1
Execute the Cypress test in a pos2-modules environment with the org.openbravo.retail.digitalcoupons and org.openbravo.retail.digitalcoupons.sampledata modules added.
Update the Cypress test as follows:

1- Replace cy.clickPayButton() with cy.get('[data-testid="obpos2ButtonBar2-payButton"]').click() since cy.clickPayButton() has been deleted.

2- Update the test data-testids with the ones added in org.openbravo.retail.digitalcoupons.

3. Update the /src-test/cypress/.eslintrc.json file with the content provided at:
https://gitlab.com/openbravo/devel/pmods/org.openbravo.pos2/-/blob/91193f70b6af8295d52382901870343ff47ca5f0/web-jspack/org.openbravo.pos2/src-test/cypress/.eslintrc.json [^]

4. Update test and function files by removing unnecessary exceptions that are already covered by the .eslintrc.json file.
No tags attached.
Issue History
2024-02-14 12:58ruben_jimenezNew Issue
2024-02-14 12:58ruben_jimenezAssigned To => Triage Platform Base
2024-02-14 12:58ruben_jimenezTriggers an Emergency Pack => No
2024-03-11 10:48AugustoMauchAssigned ToTriage Platform Base => ruben_jimenez
2024-03-21 12:33andre_montenegroNote Added: 0162468
2024-03-21 12:33andre_montenegroProposed Solution updated

Notes
(0162468)
andre_montenegro   
2024-03-21 12:33   
Added more changes to implement to the proposed solution (3 and 4) due a change in the eslintrc.json file for all Cypress folders:

https://gitlab.com/openbravo/devel/pmods/org.openbravo.pos2/-/commit/91193f70b6af8295d52382901870343ff47ca5f0 [^]