0054669: Approvals of actions without inputs are not being persisted in the backend

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054669

POS2

Core

public

2024-02-14 10:55

2024-02-19 11:05

Reporter

AugustoMauch

Assigned To

AugustoMauch

Priority

immediate

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

24Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Packaging and release

Regression date

2023-11-06

Regression introduced in release

main

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/f38f5a036d4dff9b3e9f5f7083a2c0d25ab6b0e6 [^]

Triggers an Emergency Pack

Summary

0054669: Approvals of actions without inputs are not being persisted in the backend

Description

When doing an approval of an action that does not have any user action inputs, the approval is not being persisted in the backend

Steps To Reproduce

In any POS2 enviroment that contains the sampledata (i.e. livebuilds)
1- In the backoffice, update permissions to the VallBlancaUser role, so that it requires approval when executing the "Return Line" action.
2- In the backoffice, update permissions to the The White Valley Group Admin role, so that it can approve the "Return Line" action
3- Log in in the POS with the vallblanca user, make sure the VallBlancaUser role is active
4- Add a line and return it. A popup will be displayed asking for user inputs and approval. Add them (use Openbravo/openbravo in the approval), complete the ticket.
5- Go to the backend, open the Return from Customer window, check the record that was created and check that the Approval History subtab contains info related to the approval that just took place.

So far, this is the expected behaviour. Now:
6- In the backoffice, deactivate all user inputs from the Return Line action in the User Action Input window.
7- Back in POS2, refresh the masterdata so that the changes done in the backoffice are applied. Repeat steps 4 and 5, and notice how in the new Return from Customer record there is no trace about the approval that took place when returning the line

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0054670	24Q1	closed	AugustoMauch	Approvals of actions without inputs are not being persisted in the backend
caused by	feature request	0053576		closed	Triage Platform Base	User Action Inputs improvements
related to	defect	0054699		closed	AugustoMauch	[24Q1] Sales Order Line value is not present in Return From Customer \|\| Approval History under specific flow