0054636: [24Q1] Return Line Reason is set as "undefined" if no input is chosen

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054636

POS2

POS

public

2024-02-02 15:42

2024-02-12 16:24

Reporter

lorenzofidalgo

Assigned To

caristu

Priority

immediate

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

24Q1

Fixed in Version

24Q1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

QA functional test

Regression date

2023-10-17

Regression introduced in release

main

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f35ca078047b33682c70833de0bf1f3d84463b49 [^]

Triggers an Emergency Pack

Summary

0054636: [24Q1] Return Line Reason is set as "undefined" if no input is chosen

Description

At the moment of selecting values in a Return Line, if the POS2 user chooses to insert no input, "undefined" is shown as value inside the ticket instead of an empty value or other proper solution.
This issue has been reproducible in 24Q1 (QA status) and it seems to come from the development that extends the Return Reason functionality. In older versions, the flows differ slightly but, now, the POS2 user receives a wrong value that was not shown previously.
Issue not reproducible in livebuilds 23Q4.1.

Steps To Reproduce

Configuration:
0-Login POS2 backoffice and go to "User Action Input" window.
1-Deactive all records except the following one:
"User Action": "Return Line"
"User Input"": "Return Line Reason".
2-Enter the previous aforementioned (in Step 1) record and set "Mandatory" as False and Active as True.
Save the modifications.

POS2 flow:
1-Login POS2 using CMS-2 terminal and centralmountains as user.
2-Add 1x "Avalanche transceiver" to the ticket.
3-Click the just added product line and, in the overlay, click "Return Line" button.
4-Without choosing value, click OK button. DEFECT: Realise "undefined" is shown as value in the ticket line (check attached images to see current and old behaviour).

Proposed Solution

Additional Information