Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054570POS2Corepublic2024-02-05 10:192024-04-12 11:17
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054570: CRA should be replaced by an alternative, Vite
DescriptionWe're replacing CRA with Vite, after a thorough research. This is due to CRA being in maintenance mode and not receiving updates for a couple years already. And also because webpack is getting slower and slower for developer experience.

Vite: https://vitejs.dev/ [^]
CRA: https://create-react-app.dev/ [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0055167 closed cberner Some labels are not shown properly in the application 
causes defect 0055175 closed cberner ant build with vite fail in arm64 environments (i.e. AWS cloud - Graviton) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-02-05 10:19cbernerNew Issue
2024-02-05 10:19cbernerAssigned To => Triage Platform Base
2024-02-05 10:19cbernerTriggers an Emergency Pack => No
2024-02-05 10:19cbernerAssigned ToTriage Platform Base => cberner
2024-02-05 13:46cbernerStatusnew => scheduled
2024-02-05 15:51hgbotNote Added: 0160263
2024-02-05 15:53hgbotNote Added: 0160264
2024-02-05 15:53hgbotNote Added: 0160265
2024-03-06 18:41hgbotNote Added: 0161790
2024-03-19 18:08hgbotNote Added: 0162386
2024-03-19 18:10hgbotNote Added: 0162387
2024-04-10 11:43hgbotNote Added: 0163027
2024-04-10 11:43hgbotNote Added: 0163028
2024-04-10 11:43hgbotResolutionopen => fixed
2024-04-10 11:43hgbotStatusscheduled => closed
2024-04-10 11:43hgbotNote Added: 0163029
2024-04-10 11:43hgbotFixed in Version => 24Q3
2024-04-10 11:43hgbotNote Added: 0163030
2024-04-10 11:43hgbotNote Added: 0163031
2024-04-10 11:43hgbotNote Added: 0163032
2024-04-10 11:43hgbotNote Added: 0163033
2024-04-10 11:43hgbotNote Added: 0163034
2024-04-10 11:43hgbotNote Added: 0163035
2024-04-10 11:43hgbotNote Added: 0163036
2024-04-10 11:43hgbotNote Added: 0163037
2024-04-10 11:43hgbotNote Added: 0163038
2024-04-10 18:36hgbotNote Added: 0163066
2024-04-11 11:13cbernerRelationship addedcauses 0055167
2024-04-11 17:05cbernerRelationship addedcauses 0055175
2024-04-12 11:17hgbotNote Added: 0163147

Notes
(0160263)
hgbot   
2024-02-05 15:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1357 [^]
(0160264)
hgbot   
2024-02-05 15:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2405 [^]
(0160265)
hgbot   
2024-02-05 15:53   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1127 [^]
(0161790)
hgbot   
2024-03-06 18:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/678 [^]
(0162386)
hgbot   
2024-03-19 18:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/63 [^]
(0162387)
hgbot   
2024-03-19 18:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.ssms/-/merge_requests/125 [^]
(0163027)
hgbot   
2024-04-10 11:43   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 1b85b19a523776fc52852fb00c0727cfdb26d009
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:35:59
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/1b85b19a523776fc52852fb00c0727cfdb26d009 [^]

Related to FR-54570: CRA/webpack should be replaced by an alternative, Vite

---
M babel.config.js
M modules/org.openbravo.client.kernel/eslint-airbnb/eslintrc-airbnb-react.template
M package-lock.json
M package.json
---
(0163028)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1127 [^]
(0163029)
hgbot   
2024-04-10 11:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 84a2a551c5365926ca7ee2d8987d42ce2700680e
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:39:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/84a2a551c5365926ca7ee2d8987d42ce2700680e [^]

Related to FR-54570: CRA/webpack should be replaced by an alternative, Vite

---
M web-jspack/org.openbravo.pos2/package-lock.json
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerGrid/CustomerGrid.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialogForm/CustomerMultiTabDialogForm.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialogHeader/CustomerMultiTabDialogHeader.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerCellRender/CustomerCellRender.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerNotification/CustomerNotification.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/TicketBPNotifications.scss
---
(0163030)
hgbot   
2024-04-10 11:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: caf9fcbe55725b3b7362b0d5accb6ae898d5cccc
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:37:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/caf9fcbe55725b3b7362b0d5accb6ae898d5cccc [^]

Fixes FR-54570: CRA/webpack should be replaced by an alternative, Vite

This MR includes the changes required to switch the CRA technology to
Vite and several other changes to make the things that previously worked
with CRA out of the box work with Vite.

More info is provided in the MR and related documentation.

---
---
(0163031)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1357 [^]
(0163032)
hgbot   
2024-04-10 11:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 1008e62687cff9c24ea8d2fd8ccb70b7bfdf07dd
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:40:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/1008e62687cff9c24ea8d2fd8ccb70b7bfdf07dd [^]

Related to FR-54570: CRA/webpack should be replaced by an alternative, Vite

This includes changes required for vite to work as expected, they should
be transparent from other dependencies of mobile.core(that are not core2).

---
M web/org.openbravo.mobile.core/app/external-device/printing/PrintTemplateStore.js
M web/org.openbravo.mobile.core/app/integration/remote-server/RemoteServerController.js
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/app/model/persistence/indexeddb/IndexedDBController.js
---
(0163033)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/678 [^]
(0163034)
hgbot   
2024-04-10 11:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.ssms [^]
Changeset: 5419a375e5e8e1e43009932b6c861e31682e5ec9
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:41:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.ssms/-/commit/5419a375e5e8e1e43009932b6c861e31682e5ec9 [^]

Related to FR-54570: CRA/webpack should be replaced by an alternative, Vite

It includes scss changes to remove several warnings related to the
change of CRA to Vite.

---
M web-jspack/org.openbravo.ssms/src/components/ProductLineDetailDialog/ProductLineDetailDialog.scss
M web-jspack/org.openbravo.ssms/src/components/TaskDetailDialog/TaskDetailDialog.scss
M web-jspack/org.openbravo.ssms/src/components/TaskDetailRowView/TaskSummary/TaskSummary.scss
---
(0163035)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2405 [^]
(0163036)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.ssms/-/merge_requests/125 [^]
(0163037)
hgbot   
2024-04-10 11:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: d163b8b26f702127be22286dffa62f876dde6223
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 11:42:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/d163b8b26f702127be22286dffa62f876dde6223 [^]

Related to FR-54570: CRA/webpack should be replaced by an alternative, Vite

Includes some scss changes that triggered warnings when changing from
CRA to Vite.

---
M web-jspack/org.openbravo.events.client/src/components/EventsLoginDialog/EventsLoginDialog.scss
---
(0163038)
hgbot   
2024-04-10 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/63 [^]
(0163066)
hgbot   
2024-04-10 18:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b9735fa000fb78f089526b6e3be75b9f633f16e2
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 10-04-2024 18:34:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b9735fa000fb78f089526b6e3be75b9f633f16e2 [^]

Related to FR-54570: Fix error related with REACT_APP_SERVER_PATHS

REACT_APP_SERVER_PATHS gave an error related with JSON type because it
was not properly wrapped in a JSON.stringify.

---
M web-jspack/org.openbravo.core2/vite.config.js
---
(0163147)
hgbot   
2024-04-12 11:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 181cd698a80c3c5ed74ba58981034da9b00551af
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 12-04-2024 11:16:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/181cd698a80c3c5ed74ba58981034da9b00551af [^]

Related to FR-54570: merge-converage script not being launched in package.json

It was missing the .js at the end, it is being checked against the
filename at the end of the merge-coverage.js script.

---
M web-jspack/org.openbravo.core2/package.json
---