Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0054548 | POS2 | POS | public | 2024-02-01 18:56 | 2024-04-19 07:20 |
|
| Reporter | Lcazaux | |
| Assigned To | sreehari | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 24Q3 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0054548: [Cash Up - Keep Amount] Configuration not taken into account properly |
| Description | If I set my store with a configuration “Allow variable amount = Yes” it is not considered in the POS → KO. It should display a line in the Keep amount window when doing a cash up even if no other boxes are checked related to it: currently, there is no line displayed if only this is set. The only way to have a line displayed is to put “Allow not to move =Yes” but this will allow:
1/ to put a variable amount
2/ to put a fixed amount
3/ to put all the cash total
This is wrong, there is one checkbox for each of these options, so they should interact separately.
When I do cash up, according to my configuration, I must have the right line with the right option showed.
https://drive.google.com/file/d/1m3_TZkW8KjWgc2CJvKt89fyN2bv42hNQ/view?usp=sharing [^] |
| Steps To Reproduce | - Backoffice
- Window Touchpoint Type
- Subtab Payment Method
- "cash"
- Allow variable amount = Yes
- Put the rest of the keep amount options to "No"
- Go to the POS and do a refresh master data
- Do some sales
- Do a cash up
- A line must appear with a field where it is possible to enter a variable amount --> this is not working right now |
| Proposed Solution | --> Each of the options must work independently from each others
When I do cash up, according to my configuration, I must have the right line with the right option showed. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-02-01 18:56 | Lcazaux | New Issue | |
| 2024-02-01 18:56 | Lcazaux | Assigned To | => Retail |
| 2024-02-01 18:56 | Lcazaux | Triggers an Emergency Pack | => No |
| 2024-02-01 18:57 | Lcazaux | Description Updated | bug_revision_view_page.php?rev_id=27451#r27451 |
| 2024-02-05 11:23 | sreehari | Assigned To | Retail => sreehari |
| 2024-02-06 12:28 | sreehari | Status | new => scheduled |
| 2024-02-09 10:52 | guilleaer | Note Added: 0160538 | |
| 2024-02-16 09:23 | sreehari | Note Added: 0160837 | |
| 2024-02-21 13:52 | hgbot | Note Added: 0161028 | |
| 2024-02-21 13:53 | hgbot | Note Added: 0161029 | |
| 2024-04-09 13:02 | Leyre | Note Added: 0162986 | |
| 2024-04-16 12:45 | hgbot | Note Added: 0163275 | |
| 2024-04-16 12:45 | hgbot | Note Added: 0163276 | |
| 2024-04-16 12:45 | hgbot | Note Added: 0163277 | |
| 2024-04-19 07:19 | hgbot | Note Added: 0163423 | |
| 2024-04-19 07:19 | hgbot | Resolution | open => fixed |
| 2024-04-19 07:19 | hgbot | Status | scheduled => closed |
| 2024-04-19 07:19 | hgbot | Fixed in Version | => 24Q3 |
| 2024-04-19 07:19 | hgbot | Note Added: 0163424 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163425 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163426 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163427 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163428 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163429 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163430 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163431 | |
| 2024-04-19 07:20 | hgbot | Note Added: 0163432 | |
|
Notes |
|
|
|
Recap of the correct behavior depending on the configuration:
Keep fixed amount can be configured with:-> Allow variable amount -> This is what should or should not prevent to change that amount-> Allow not to move -> This is what should or should not allow you to keep the amount you have counted.
So:
A/ If keep fixed amount 200 and allow variable amount = false
and
Allow Not To move is false
--> the step is not shown and the cash to keep is the minimum between (the counted and the configured as cash to keep)
B/ If keep fixed amount 200 and allow variable amount = true
and
Allow Not To move is false
-> The default step should be shown with cash to keep = minimum between (the counted amount and the configured cash to keep) but the cashier can change it to any value below the counted amount.
C/ If keep fixed amount 200 and allow variable amount = true
and
Allow Not to move is true
--> Yes should show the step that will appear with cash to keep = minimum between (the counted amount and the configured cash to keep) but the cashier can change it to any value less than or equal to the counted amount.
Example: If keep amount = 200€ but counted amount = 150€ → the window “Keep Amount” must display 150€ but the cashier can change it to any value.
D/ if keep fixed amount 200 and allow variable amount = false
and
Allow Not to move is true
-> It should show the step that will appear with cash to keep = minimum between (the counted amount and the configured cash to keep) but the cashier can change it only to a value equal to the counted amount. |
|
|
|
|
|
|
|
(0161028)
|
|
hgbot
|
|
2024-02-21 13:52
|
|
|
|
|
(0161029)
|
|
hgbot
|
|
2024-02-21 13:53
|
|
|
|
|
(0162986)
|
|
Leyre
|
|
2024-04-09 13:02
|
|
Hello Team.
Any update on this ticket? Pending to fix the problem in Sabor a España.
Thanks. |
|
|
|
(0163275)
|
|
hgbot
|
|
2024-04-16 12:45
|
|
|
|
|
(0163276)
|
|
hgbot
|
|
2024-04-16 12:45
|
|
|
|
|
(0163277)
|
|
hgbot
|
|
2024-04-16 12:45
|
|
|
|
|
(0163423)
|
|
hgbot
|
|
2024-04-19 07:19
|
|
|
|
|
(0163424)
|
|
hgbot
|
|
2024-04-19 07:19
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f36775c9fd0387be81323a11c0e459922e796b64
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f36775c9fd0387be81323a11c0e459922e796b64 [^]
Fixes ISSUE-54548: Fixed Cashup Config Functionalities similar to POS
*Added allowvariableamount for selecting variable amount
*Added readOnly Logic for Amount to Keep input columns
*Additional Checks to set amountToKeep value when keepfixedamount or allowdontmove are enabled
---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
---
|
|
|
|
(0163425)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
|
|
|
(0163426)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f691ed88bb366ddd6c1acc3e6aa1fe6456df350b
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f691ed88bb366ddd6c1acc3e6aa1fe6456df350b [^]
Fixes ISSUE-54548: Added condition to show move everything button
*when Allow move everything enabled move everything
*fixed case when 'Allow Not to Move' then enabled to keep nothing
*fixed formatString to validate string if length > 1
*disabled keypad based on allowmoveeverything & allowdontmove case when specific payment is selected
*added canKeepCash logic to filter availablePaymentMethods
*Skipped step 2 when there are no availablePaymentMethods
---
A web-jspack/org.openbravo.pos2/src/model/user-interface/utils/canKeepCash.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/utils/getValueFromInput.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
---
|
|
|
|
(0163427)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a2b7c11f60412e840428eed3ef5c3a673c47d4eb
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a2b7c11f60412e840428eed3ef5c3a673c47d4eb [^]
Fixes ISSUE-54548: Fixed Test Failures
*added combination test cases for flags keepfixedamount, allowvariableamount, allowdontmove, allowmoveeverything
*added test cases for setCountedAmount & matchCountedWithExpected
*fixed cypress failure, used seperate cy.window() for validating step 2 cashupMode
*added additional button Keep 0, for keeping 0 when disabling keypad
---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/mock/PaymentMethodsInfoMock2.config.json
M web-jspack/org.openbravo.pos2/src-test/cypress/functions/countMoney.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/__test__/SelectCashToKeepStep.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/TerminalPaymentsMock4.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/MatchCountedWithExpected.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetCountedAmount.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/mock/PaymentMethodsInfoMock.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/mock/index.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/canKeepCash.js
---
|
|
|
|
(0163428)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c3ae4f5ebc7931d459a852f68aa10684d5708713
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c3ae4f5ebc7931d459a852f68aa10684d5708713 [^]
Fixes ISSUE-54548: Added Step validation during cashup
*when cashup initialized proceeding to step2 without validating amount in step 1, results in empty step2 appearance, fixed that
*fixed case when keep 0 shouldn't appear, case 7 & 14 keep 0 button will appear
*input & keypad remains disabled and also Keep 0 button appears only when allowvariableamount - 'N'
---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetSelectedPaymentMethod.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
---
|
|
|
|
(0163429)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4cad07889fafaf97050d8a56322f5abc8604be99
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4cad07889fafaf97050d8a56322f5abc8604be99 [^]
Fixes ISSUE-54548: Created New function validateCashToKeepStep
*the new function handles the buttons in cash to keep step
*and skipstep, defaultAmount and disable input keypad
*case 7, keep 0 wont appear as allowvariableamount & allowmoveeverything is 'N'
*fixed test failure, and added tests for validateCashToKeepStep function
*added logic for displayKeepTotalCounted, displayKeepFixedAmount, defaultValueVariableAmountKeep & added tests accordingly
*moved canKeepAll and canKeepFixedAmount function to validateCashToKeepStep
*updated validateCashToKeepStep params and tests
*fixed case 5 & 12 for not show keep counted button
---
A web-jspack/org.openbravo.pos2/src/model/user-interface/utils/__test__/validateCashToKeepStep.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/utils/validateCashToKeepStep.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/__test__/SelectCashToKeepStep.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/PaymentMethodsInfoMock4.config.json
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/TerminalPaymentsMock4.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/canKeepCash.js
---
|
|
|
|
(0163430)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 62e704256729344aa4666389723636c729c4ec36
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/62e704256729344aa4666389723636c729c4ec36 [^]
Fixes ISSUE-54548: Applied Code Review Changes Applied
*updated test cases
*fixed SelectCashToKeepStep test failure added required values to config files, removed duplicate canKeepCash function
---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/PaymentMethodsInfoMock4.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/__test__/validateCashToKeepStep.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/canKeepCash.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/utils/validateCashToKeepStep.js
---
|
|
|
|
(0163431)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 36cf0d80ec36811d1cd3c1b75bcc0bf92342c473
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 18-04-2024 22:58:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/36cf0d80ec36811d1cd3c1b75bcc0bf92342c473 [^]
Fixes ISSUE-54548: Modifying the function name and params
* CODE REVIEW POINTS
* - renamed the function from validateCashToKeepStep to getCashToKeepConfig
* - changed the individual params to single object of { paymentMethod, countPerAmount, counted }
* - used cashToKeep instead amount
* - removed canKeepCash method and used skipStep from getCashToKeepConfig, added validation for countpaymentincashup
* - handled countPerAmount within getCashToKeepConfig function
---
A web-jspack/org.openbravo.pos2/src/model/user-interface/utils/__test__/getCashToKeepConfig.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/utils/getCashToKeepConfig.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectCashToKeepStep/SelectCashToKeepStep.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetSelectedPaymentMethod.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSelectedPaymentMethod.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/utils/__test__/validateCashToKeepStep.test.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/utils/canKeepCash.js
---
|
|
|
|
(0163432)
|
|
hgbot
|
|
2024-04-19 07:20
|
|
|