0054498: Cross dependency to org.openbravo.retail.discounts

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054498

Modules

Openbravo Business API

public

2024-01-30 10:37

2024-01-30 11:28

Reporter

vmromanos

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0054498: Cross dependency to org.openbravo.retail.discounts

Description

In Promotion entity mapping Inwards, the xUnits property mapping instance is included in the Business API module. However, this property belongs org.openbravo.retail.discounts so it shouldn't be added to Business API module.

In fact the Retail API module does already include this property, so I think we just need to delete it

Steps To Reproduce

This is how I detected the problem

In a minimum environment, without retail stuff, try to access swagger. An error is thrown.

After removing the xUnits property mapping instance, you can access to swagger.

This is my environment:
* openbravo
* modules/org.openbravo.api
* modules/org.openbravo.events.core:
* modules/org.openbravo.externaldata.integration
* modules/org.openbravo.service.external.integration
* modules/org.openbravo.service.openapi

Proposed Solution

Remove the xUnits property mapping instance. Attached proposed file

Nice to have: Try to automate this check at compilation time to raise the problem in CI.

Additional Information

Tags

No tags attached.

Relationships

related to

feature request

0054499

acknowledged

Triage Platform Conn

Mechanism to avoid property mapping definitions causing incorrect module dependencies

Attached Files