Openbravo Issue Tracking System - POS2 | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0054485 | POS2 | POS | public | 2024-01-29 10:50 | 2024-01-31 11:35 |
| Reporter | caristu | ||||
| Assigned To | Retail | ||||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0054485: printProductLabel action is implemented with a non pure function | ||||
| Description | The printProductLabel action of org.openbravo.pos2.product.label.printing module is implemented with a non pure function, because the function causes side effects: it is registering a template if it is not registered yet. See here[1]. As stated in the documentation[2], actions must be implemented as pure functions. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/blame/master/web-jspack/org.openbravo.pos2.product.label.printing/src/model/messages/actions/PrintProductLabel.js#L28 [^] [2] http://wiki.openbravo.com/wiki/StateController#Design_principles_of_the_StateController [^] | ||||
| Steps To Reproduce | . | ||||
| Proposed Solution | Move the template existence and registration part to an action preparation | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2024-01-29 10:50 | caristu | New Issue | |||
| 2024-01-29 10:50 | caristu | Assigned To | => Retail | ||
| 2024-01-29 10:50 | caristu | Triggers an Emergency Pack | => No | ||
| 2024-01-29 10:50 | caristu | Description Updated | bug_revision_view_page.php?rev_id=27409#r27409 | ||
| 2024-01-29 10:51 | caristu | Summary | printProductLabel action is using a non pure function => printProductLabel action is implemented with a non pure function | ||
| 2024-01-29 10:51 | caristu | Description Updated | bug_revision_view_page.php?rev_id=27410#r27410 | ||
| 2024-01-31 11:23 | caristu | Proposed Solution updated | |||
| 2024-01-31 11:35 | caristu | Issue cloned | 0054519 | ||
| There are no notes attached to this issue. |