Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054434POS2POSpublic2024-01-23 14:312024-02-09 08:13
Reporterjorgewederago 
Assigned Tojorgewederago 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054434: The POS user must be able to manually renew the loyalty subscription for a given customer
DescriptionIt should be possible to renew a customer subscription from POS based on the rules defined for a each category
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-23 14:31jorgewederagoNew Issue
2024-01-23 14:31jorgewederagoAssigned To => Retail
2024-01-23 14:31jorgewederagoTriggers an Emergency Pack => No
2024-01-23 14:33hgbotNote Added: 0159650
2024-01-23 14:40jorgewederagoStatusnew => scheduled
2024-01-23 14:41jorgewederagoAssigned ToRetail => jorgewederago
2024-01-29 12:32hgbotNote Added: 0159859
2024-02-01 16:29hgbotNote Added: 0160105
2024-02-08 11:49hgbotNote Added: 0160420
2024-02-08 11:49hgbotNote Added: 0160421
2024-02-08 11:49hgbotNote Added: 0160422
2024-02-08 11:52hgbotResolutionopen => fixed
2024-02-08 11:52hgbotStatusscheduled => resolved
2024-02-08 11:52hgbotNote Added: 0160424
2024-02-08 11:52hgbotNote Added: 0160425
2024-02-08 11:52hgbotNote Added: 0160426
2024-02-08 11:52hgbotNote Added: 0160427
2024-02-08 11:52hgbotNote Added: 0160428
2024-02-08 11:52hgbotNote Added: 0160429
2024-02-08 11:52hgbotNote Added: 0160430
2024-02-08 11:52hgbotNote Added: 0160431
2024-02-08 11:52hgbotNote Added: 0160432
2024-02-08 11:52hgbotNote Added: 0160433
2024-02-08 11:52hgbotNote Added: 0160434
2024-02-08 11:52hgbotNote Added: 0160435
2024-02-08 11:58hgbotNote Added: 0160437
2024-02-08 12:00aaroncaleroStatusresolved => closed
2024-02-09 08:13hgbotNote Added: 0160518

Notes
(0159650)
hgbot   
2024-01-23 14:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/14 [^]
(0159859)
hgbot   
2024-01-29 12:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/51 [^]
(0160105)
hgbot   
2024-02-01 16:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2393 [^]
(0160420)
hgbot   
2024-02-08 11:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4a8b24dab4a55e10d5ceb45af2d95294445287ec
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 08-02-2024 11:48:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4a8b24dab4a55e10d5ceb45af2d95294445287ec [^]

Related to FR-54434: Allow multiple buttons in CustomerMultiTabDialog's left toolbar

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialog.jsx
---
(0160421)
hgbot   
2024-02-08 11:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b88989d392aa6f3bef36f03e88de69796bc31f87
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 08-02-2024 11:48:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b88989d392aa6f3bef36f03e88de69796bc31f87 [^]

Related to FR-54434: Adding new styles for the left buttons

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialog.scss
---
(0160422)
hgbot   
2024-02-08 11:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: de719b33d4b7e83f9d95f47717627bc23e04fc36
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 08-02-2024 11:48:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/de719b33d4b7e83f9d95f47717627bc23e04fc36 [^]

Related to FR-54434: Merge branch 'fr/54434'

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialog.scss
---
(0160424)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 1191be36228ea6cf9177f6d1bcb019853d94ce0a
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 05-02-2024 09:32:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/1191be36228ea6cf9177f6d1bcb019853d94ce0a [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer

---
M src-db/database/model/tables/OBLP_CATEGORY.xml
M src-db/database/model/tables/OBLP_SUBSCRIPTION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0160425)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 9e2690f65d62ae30dd9194f876a6df66cd5a821a
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 05-02-2024 09:32:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/9e2690f65d62ae30dd9194f876a6df66cd5a821a [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer
Removing default value for category type
Adding new fields for subscription reminder
Adding code to the event handler to ensure proper configurations

---
M src-db/database/model/tables/OBLP_CATEGORY.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java
---
(0160426)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 99881da0d75d8362509fd434e34e7514d399c9fc
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 07-02-2024 15:30:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/99881da0d75d8362509fd434e34e7514d399c9fc [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer
*Adding missing description & help

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0160427)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 0284f3eef888d7425992ecfccca061c09ee0f9c6
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 08-02-2024 11:51:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/0284f3eef888d7425992ecfccca061c09ee0f9c6 [^]

Fixed FR-54434: Added Category Renewal configuration. Merge branch 'fr/54434'

---
M src-db/database/model/tables/OBLP_CATEGORY.xml
M src-db/database/model/tables/OBLP_SUBSCRIPTION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/loyalty/programs/eventhandler/CategoryEventHandler.java
---
(0160428)
hgbot   
2024-02-08 11:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/14 [^]
(0160429)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 9a8f38c13a038c2cca3c4dfb05e1b7667238fa20
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 08-02-2024 10:22:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/9a8f38c13a038c2cca3c4dfb05e1b7667238fa20 [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer

---
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/RenewCategory.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/utils/loyaltyUtils.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/loyalty/programs/master/LoyaltySubscriptionsProperties.java
M src/org/openbravo/retail/loyalty/programs/process/LoyaltySubscriptionsLoader.java
M src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionManager.java
M src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionParameters.java
M src/org/openbravo/retail/loyalty/programs/term/LoyaltyProgramCategoryProperties.java
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.scss
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormFooter.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormPortrait.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/prepareLoyaltyData.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/ob-init.js
---
(0160430)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 08b1b4aebe1a3be58224b5d4c62a50acdae18acb
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 08-02-2024 10:22:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/08b1b4aebe1a3be58224b5d4c62a50acdae18acb [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer
*Adding code to show alerts when the expiration date is close
*Adding new message

---
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormPortraitFooter.config.json
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/showLoyaltyWarning.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/RenewCategory.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/ob-init.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/utils/loyaltyUtils.js
---
(0160431)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: f6a884fa3de26f0321daa3d9655bf07b061f2ffc
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 08-02-2024 10:22:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/f6a884fa3de26f0321daa3d9655bf07b061f2ffc [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer

Created configurationSet to hold the loyalty form buttons configuration
Disabled Renew Loyalty button in landscape mode if expiry date is not defined
Fixed date comparison in Renewal Reminder popup to ignore the time part of dates

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormFooter.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormPortraitFooter.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/showLoyaltyWarning.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/ob-init.js
---
(0160432)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 561d9d85570925228e1982d9cbda2e86abcfedab
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 08-02-2024 10:22:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/561d9d85570925228e1982d9cbda2e86abcfedab [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer

Use formatTimeWithCustomTimeFormat to display expiryDate with proper formatting

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/RenewCategory.js
---
(0160433)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: e7afeadd2dc05b471407914af6ac7b864ad874f2
Author: Jorge Wederago <jorge.wederago@openbravo.com>
Date: 08-02-2024 10:22:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/e7afeadd2dc05b471407914af6ac7b864ad874f2 [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer
*Fixed issue related to a null pointer when creating a loyalty and there are no expiry rules for it

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/prepareLoyaltyData.js
---
(0160434)
hgbot   
2024-02-08 11:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 42cd20bc2d3916a925a96ee6c64f1d15a0fe63ac
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 08-02-2024 11:52:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/42cd20bc2d3916a925a96ee6c64f1d15a0fe63ac [^]

Fixed FR-54434: The POS user must be able to manually renew the loyalty subscription for a given customer
Merge branch 'fr/54434'

---
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormPortraitFooter.config.json
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/showLoyaltyWarning.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/RenewCategory.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/utils/loyaltyUtils.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/loyalty/programs/master/LoyaltySubscriptionsProperties.java
M src/org/openbravo/retail/loyalty/programs/process/LoyaltySubscriptionsLoader.java
M src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionManager.java
M src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionParameters.java
M src/org/openbravo/retail/loyalty/programs/term/LoyaltyProgramCategoryProperties.java
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.scss
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormFooter.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyFormPortrait.config.json
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/prepareLoyaltyData.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/ob-init.js
---
(0160435)
hgbot   
2024-02-08 11:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/51 [^]
(0160437)
hgbot   
2024-02-08 11:58   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2393 [^]
(0160518)
hgbot   
2024-02-09 08:13   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: df9bb34765c956ffef197c240d511a7b2811669e
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 09-02-2024 08:13:03
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/df9bb34765c956ffef197c240d511a7b2811669e [^]

Related to FR-54334, FR-54434: Updated sampledata

---
M referencedata/sampledata/Retail_Test/OBLP_CATEGORY.xml
M referencedata/sampledata/Retail_Test/OBPOS_TERMINALTYPE.xml
---