Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054410Retail ModulesWeb POSpublic2023-11-06 12:362024-01-22 11:07
Reporterifernandez 
Assigned Toifernandez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR24Q1Fixed in VersionRR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054410: Some tests fail without org.openbravo.test.mobile.sampledata
DescriptionCI run with:

merged.json

-= 'clone of white-valley'

+= retail.pack white-valley

https://builds.openbravo.com/view/modules/job/mod-simple/85390 [^]

How to re-run

mod-simple

build with params

paste that full json into REPO_REVISIONS

put /usr/lib/jvm/java-11-openjdk-amd64/ into JAVA_HOMe

=> Build

Note: => No email this way, but allows to run 'any json' without pushing it

My notes on (some not all) discount module errors:

merged
-= clone of WV (aka test.mobile.sampledata)
+= pack sampledata

junit of discount module fail
some with missing
[C_ExtBP_Config_Property#612BB567A0FB4A1FABF229F1A2254B66]

that gets shipped with
openbravo/ci/modules/org.openbravo.test.mobile.sampledata/referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
but also
openbravo/ci/modules/org.openbravo.retail.samplebpintegration/referencedata/standard/Sample_Integration_Configuration.xml
this IS PRESENT in this workspace

what about rest of those many junit?
all same?
or more?

also discounts.propertycondition => src-test/**/CRMUtils.java
uses that hardcoded id
also pos2 __mock__ uses that hardcoded id several times

Note:

that job run is still without pos2 (just 'normal sampledata'
Steps To ReproduceN/A.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0053863 closed ifernandez Some tests fail without org.openbravo.test.mobile.sampledata 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-22 10:51aferrazTypedefect => backport
2024-01-22 10:51aferrazTarget Version => RR24Q1
2024-01-22 10:58hgbotNote Added: 0159578
2024-01-22 10:59hgbotResolutionopen => fixed
2024-01-22 10:59hgbotStatusscheduled => closed
2024-01-22 10:59hgbotFixed in Version => RR24Q1
2024-01-22 10:59hgbotNote Added: 0159579
2024-01-22 10:59hgbotNote Added: 0159580
2024-01-22 11:03hgbotNote Added: 0159581
2024-01-22 11:03hgbotNote Added: 0159582
2024-01-22 11:03hgbotNote Added: 0159583
2024-01-22 11:06hgbotNote Added: 0159584
2024-01-22 11:07hgbotNote Added: 0159585
2024-01-22 11:07hgbotNote Added: 0159586

Notes
(0159578)
hgbot   
2024-01-22 10:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/133 [^]
(0159579)
hgbot   
2024-01-22 10:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 977ae383dc6e063bbebc717f9acf551672764330
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-01-2024 09:59:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/977ae383dc6e063bbebc717f9acf551672764330 [^]

Fixes ISSUE-54410: Some tests fail without org.openbravo.test.mobile.sampledata

---
M src-test/org/openbravo/retail/discounts/test/base/model/OfferCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/base/model/Product.java
M src-test/org/openbravo/retail/discounts/test/base/model/ProductCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAllXGiftAllYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAllXGiftAnyYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAllYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAnyYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I32533_DiscountsByProductCharacteristic.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I40666_VerifyTotalDiscountWithNonGroupedProductTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I43502_DiscountsByProductCharacteristic.java
---
(0159580)
hgbot   
2024-01-22 10:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/133 [^]
(0159581)
hgbot   
2024-01-22 11:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/merge_requests/7 [^]
(0159582)
hgbot   
2024-01-22 11:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo [^]
Changeset: 282213c9b9fc7045378b631c6305efdd20e57fc2
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-01-2024 10:03:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/commit/282213c9b9fc7045378b631c6305efdd20e57fc2 [^]

Fixes ISSUE-54410: Some tests fail without org.openbravo.test.mobile.sampledata

---
M src-test/org/openbravo/discount/twofamiliescombo/test/unittests/CheckTwoFamiliesDiscountsTest.java
M src-test/org/openbravo/discount/twofamiliescombo/test/unittests/I32526_TwoFamiliesWithSameTwoProductsTest.java
---
(0159583)
hgbot   
2024-01-22 11:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discount.twofamiliescombo/-/merge_requests/7 [^]
(0159584)
hgbot   
2024-01-22 11:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/43 [^]
(0159585)
hgbot   
2024-01-22 11:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 0d61f481c8f4fc02add0a2f4f5f85e441f84e91a
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-01-2024 10:07:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/0d61f481c8f4fc02add0a2f4f5f85e441f84e91a [^]

Fixes ISSUE-54410: Some tests fail without org.openbravo.test.mobile.sampledata

---
M src-test/org/openbravo/discounts/combo/test/unittests/CheckComboFixPriceDiscountsTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I34809_WrongCalculationOfComboDependingSequenceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I35583_VerifyComboFixPriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I35583_VerifyComboFixPriceTest2.java
M src-test/org/openbravo/discounts/combo/test/unittests/I39513_VerifyMultiComboFixedPriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I39831_VerifyComboFixedPriceDiscountAppliedToProductWithSamePriceTest.java
M src-test/org/openbravo/discounts/combo/test/unittests/I40197_ComboApplyDiscountByHoursTest.java
---
(0159586)
hgbot   
2024-01-22 11:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/43 [^]