0054363: Approvals are not working for "Apply Discretionary and Optional Discount" user action under some specific circumstances

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054363

POS2

POS

public

2024-01-16 14:49

2024-02-12 07:41

Reporter

lmonreal

Assigned To

sreehari

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

24Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

2023-10-19

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7a7835ad560cc129128f19fb6147dc25ba3949f2 [^]

Triggers an Emergency Pack

Summary

0054363: Approvals are not working for "Apply Discretionary and Optional Discount" user action under some specific circumstances

Description

The user action "Apply Discretionary and Optional Discount" whose internal code is "OBPOS2_SetLineDiscounts" is not managing approvals correctly

Steps To Reproduce

The user action "Apply Discretionary and Optional Discount" which internal code is "OBPOS2_SetLineDiscounts" is not working

PRE:
Configure POS2 to use vallblanca manual role using vallbalnca user

- Login to the office using Openbravo/openbravo and connect to "White valley"
- In backoffice go to user vallblanca and select "VallBlancaManual" as the default role to be used for POS2 (Header -> more information -> default POS Role)
- Go to the role "VallBlancaManual" and add the following user actions to allow to use POS2 normally
    - Finish Initial Count
    - Standard initial count
    - Validate Cashup count and advance to next step
    - SwitchToLineDiscountPanel
    - SetDefaultSchema

- Additionaly configure the user action "Apply Discretionary and Optional Discount" as:
  - Confirmation Required: False
  - Approval: Approval Required
  - Input Request Type: Never
  - Active: yes

- Go to the role "Group - Admin" (the one used by demouser) and add the user actions "Apply Discretionary and Optional Discount" to allow to approve the usage of it with below information.
  - Confirmation Required: False
  - Approval: Can Use and Approve
  - Input Request Type: Never
  - Active: yes

STEPS TO REPRODUCE
1 Login in pos
2 Add two items to the order
3 press in one item
4 In the popover press "Discounts"
5 Having selected one line
  - Select "disc_fixed_5_perc"
  - press apply
    Error 1 -> KO! Approval does not appear
6 Remove order
7 Add two items to the new order
8 press in one item
9 In the popover press "Discounts"
10 Having selected two lines
  - Select "disc_fixed_5_perc"
  - press apply
    error 2 -> KO! Approval does not appear

Note:
If in the back office the discount "disc_fixed_5_perc" is marked as "Approval Required = true" and we repeat the above steps (after login in pos2 and executing refresh master data)
Error 1 is not reproducible -> approval is shown -> Can be approved by using "demouser/openbravo"

This is wrong because this scenario reveals that approval only works well when a discount with approval is being used.

  Error 2 becomes different: Now A first popup appears asking for data "Data required" and after pressing "next" the correct approval appears

Summary:
1. When a user action to apply a discretionary discount requires approval it should appear without depending on the discount that is applied
2. When user action to apply a discretionary discount does not require approval but we are using at least one discount that requires approval Approval should appear
3. The Data required popup which appears when several lines are selected should not appear

Proposed Solution

According to the spec of RM-4672 (https://docs.google.com/document/d/1LabC70jbdRc2fIxC_2ODDpzUazjphCyGv8AUalrf9nU/edit [^])
Approval only will be shown when
1. User action is configured to show approval
2. Any discount involved is marked as "approval required"

User inputs should appear
- together with approval if approval conditions (explained above)
- alone if approval conditions are not meet (explained above)

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0054513	24Q1	closed	sreehari	Approvals are not working for "Apply Discretionary and Optional Discount" user action under some specific circumstances
caused by	feature request	0053601		closed	caristu	Request user action approval separately from reasons
has duplicate	defect	0054504		closed	Triage Platform Base	[24Q1] There is a popup for approvals that does not give enough information and does not allow to type in its text field