Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054334POS2POSpublic2024-01-12 14:252024-02-13 09:20
Reporterjustin_patterson 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054334: Provide the ability to set or update the subscription category manually from the POS
DescriptionProvide the ability to set or update the subscription category manually from the POS, both when creating the subscription, and from a specific action button after the subscription has been created.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-12 14:25justin_pattersonNew Issue
2024-01-12 14:25justin_pattersonAssigned To => Retail
2024-01-12 14:25justin_pattersonTriggers an Emergency Pack => No
2024-01-12 14:38hgbotNote Added: 0159273
2024-01-12 14:39hgbotNote Added: 0159274
2024-01-12 14:40hgbotNote Added: 0159275
2024-01-17 16:48hgbotNote Added: 0159426
2024-02-08 16:44hgbotResolutionopen => fixed
2024-02-08 16:44hgbotStatusnew => resolved
2024-02-08 16:44hgbotNote Added: 0160497
2024-02-08 16:44hgbotNote Added: 0160499
2024-02-08 16:44hgbotNote Added: 0160500
2024-02-08 16:44hgbotNote Added: 0160501
2024-02-08 16:44aaroncaleroStatusresolved => closed
2024-02-09 08:13hgbotNote Added: 0160517
2024-02-09 08:13hgbotNote Added: 0160519
2024-02-12 12:43hgbotNote Added: 0160618
2024-02-12 12:49hgbotNote Added: 0160619
2024-02-13 09:20hgbotNote Added: 0160673
2024-02-13 09:20hgbotNote Added: 0160674

Notes
(0159273)
hgbot   
2024-01-12 14:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/46 [^]
(0159274)
hgbot   
2024-01-12 14:39   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/46 [^]
(0159275)
hgbot   
2024-01-12 14:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/47 [^]
(0159426)
hgbot   
2024-01-17 16:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/13 [^]
(0160497)
hgbot   
2024-02-08 16:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 3a6479203ec35b8a407aaf569cc5b944eb0e5fad
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 08-02-2024 12:42:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/3a6479203ec35b8a407aaf569cc5b944eb0e5fad [^]

Fixes FR-54334: The POS user must be able to manually update the loyalty category for a given customer

[JIRA 9357/9367]
-Modified SaveSubscriptionManager.java to update Subscription
Category when updating a Subscription
-Added new User Actions
-Exposed new property approvalRequired for Loyalty Program Categories
-Added new logic to prepareLoyaltyData to use a card or subscription
object to extract Loyalty data if a subscription exists
-Added new UpdateLoyaltyCategory popup which allows a user to change a
Loyalty subscription's Category
-Added new button to Business Partner View window which triggers new
popup
-Added new hook to SynchronizeNewLoyaltySubscription to check if a Loyalty Category change must be approved
when it is updated
-Added new ComboBox component to LoyaltyForm.jsx that allows the update
of a Loyalty Subscription's Category
-Added AD_MESSAGES
-Added styling
-Added tests

---
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyForm/__test__/LoyaltyForm.test.jsx
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/UpdateCategoryPopup/UpdateCategoryPopup.jsx
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/UpdateCategoryPopup/UpdateCategoryPopup.scss
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/UpdateCategoryPopup/__test__/UpdateCategoryPopup.test.jsx
A web-jspack/org.openbravo.retail.loyalty.programs/src/components/UpdateCategoryPopup/index.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/FinishUpdateCategory.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/ShowUpdateCategory.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/UpdateLoyaltyCategory.js
A web-jspack/org.openbravo.retail.loyalty.programs/src/model/user-interface/actions/ShowUpdateCategoryPopup.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M src/org/openbravo/retail/loyalty/programs/process/SaveSubscriptionManager.java
M src/org/openbravo/retail/loyalty/programs/term/LoyaltyProgramCategoryProperties.java
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyForm/LoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/prepareLoyaltyData.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/SynchronizeNewLoyaltySubscription.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/user-actions/__test__/SynchronizeLoyaltySubscription.test.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.retail.loyalty.programs/src/ob-init.js
M web/org.openbravo.retail.loyalty.programs/app/model/masterdata/LoyaltyCardModel.js
---
(0160499)
hgbot   
2024-02-08 16:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/47 [^]
(0160500)
hgbot   
2024-02-08 16:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/13 [^]
(0160501)
hgbot   
2024-02-08 16:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: e042a847381782a77d75a1d4a4463e6ef6dcb4f6
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 08-02-2024 12:41:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/e042a847381782a77d75a1d4a4463e6ef6dcb4f6 [^]

Fixes FR-54334: The POS user must be able to manually update the loyalty category for a given customer
    [JIRA 9367]
    -initial commit

---
A src-db/database/model/modifiedTables/OBPOS_TERMINALTYPE.xml
A src-db/database/model/triggers/OBLP_APPROVAL_TRG.xml
M src-db/database/model/tables/OBLP_CATEGORY.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0160517)
hgbot   
2024-02-09 08:13   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: df9bb34765c956ffef197c240d511a7b2811669e
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 09-02-2024 08:13:03
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/df9bb34765c956ffef197c240d511a7b2811669e [^]

Related to FR-54334, FR-54434: Updated sampledata

---
M referencedata/sampledata/Retail_Test/OBLP_CATEGORY.xml
M referencedata/sampledata/Retail_Test/OBPOS_TERMINALTYPE.xml
---
(0160519)
hgbot   
2024-02-09 08:13   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 07cf8ed39541a728101e5cc4c0c8f341ada947c5
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 09-02-2024 08:13:35
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/07cf8ed39541a728101e5cc4c0c8f341ada947c5 [^]

Related to FR-54334: Updated sampledata

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0160618)
hgbot   
2024-02-12 12:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 739480ad6f0200b3b0e12b3095898f83e67a2d68
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 12-02-2024 12:43:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/739480ad6f0200b3b0e12b3095898f83e67a2d68 [^]

Related to FR-54334: Updated field position

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0160619)
hgbot   
2024-02-12 12:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/54 [^]
(0160673)
hgbot   
2024-02-13 09:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 4b43a355dd2309807ed8acf41ab2d13e3dac490a
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 12-02-2024 12:48:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/4b43a355dd2309807ed8acf41ab2d13e3dac490a [^]

Related to FR-54334: Fixed minor issues

Updated css of Update Category popup in portrait
(Re)generate expiry date when updating the category
Properly disable the Update Category button in the loyalty tab

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/MultiTabLoyaltyForm/MultiTabLoyaltyForm.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/UpdateCategoryPopup/UpdateCategoryPopup.scss
M web-jspack/org.openbravo.retail.loyalty.programs/src/model/loyalty/actions/prepareLoyaltyData.js
---
(0160674)
hgbot   
2024-02-13 09:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/54 [^]