Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054331Openbravo ERPA. Platformpublic2024-01-12 12:372024-01-25 11:07
Reporterablasco 
Assigned Toablasco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR24Q1Fixed in VersionPR24Q1 
Merge Request Statusapproved
Review Assigned Tocberner
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date2023-01-12
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/101e14051c3e4b30e354085f0593feb5bb84c41b [^]
Triggers an Emergency PackNo
Summary0054331: Revert related with Fully support Java 21 LTS caused by proc:full compiler Argument
DescriptionCompiler warnings appears due to "Annotation Processing" message during compilation. Solved with -proc:full compiler Argument but invalid flag can be taken sometimes.

https://bugs.openjdk.org/browse/JDK-8308346 [^]

Results in Compilation.
[javac] error: invalid flag:
    [javac] Usage: javac <options> <source files>
    [javac] use --help for a list of possible options
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0053971 closed ablasco Fully support Java 17 LTS and Java 21 LTS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-12 12:37ablascoNew Issue
2024-01-12 12:37ablascoAssigned To => ablasco
2024-01-12 12:37ablascoOBNetwork customer => No
2024-01-12 12:37ablascoModules => Core
2024-01-12 12:37ablascoRegression date => 2023-01-12
2024-01-12 12:37ablascoRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/101e14051c3e4b30e354085f0593feb5bb84c41b [^]
2024-01-12 12:37ablascoTriggers an Emergency Pack => No
2024-01-12 12:38ablascoSummaryFully support Java 17 LTS and Java 21 LTS - proc:full compiler Argument => Revert related with Fully support Java 21 LTS caused by proc:full compiler Argument
2024-01-12 13:06ablascoRelationship addedcaused by 0053971
2024-01-12 13:08hgbotMerge Request Status => open
2024-01-12 13:08hgbotNote Added: 0159264
2024-01-12 13:24cbernerNote Added: 0159267
2024-01-12 13:25hgbotMerge Request Statusopen => approved
2024-01-12 13:26hgbotNote Added: 0159270
2024-01-12 13:26hgbotNote Added: 0159271
2024-01-12 13:33cbernerStatusnew => scheduled
2024-01-25 11:07ablascoStatusscheduled => resolved
2024-01-25 11:07ablascoFixed in Version => PR24Q1
2024-01-25 11:07ablascoFixed in SCM revision => a0dde2bb41ee7314160eec07633be54a45e26368
2024-01-25 11:07ablascoResolutionopen => fixed
2024-01-25 11:07ablascoReview Assigned To => cberner
2024-01-25 11:07ablascoStatusresolved => closed

Notes
(0159264)
hgbot   
2024-01-12 13:08   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1101 [^]
(0159267)
cberner   
2024-01-12 13:24   
On additional note, these are some details that shuener has found that we should also think about when redoing the MR:

- Why does this error happen now but not in CI + for us
- Why had to revert same code in mobile-test (maybe same)
- Can we make the condition (apply for 21+22) more future proof (should by >17)
- Which javac entries in our various build.xml do we want to cover?
  - All?
  - Or just the ones we know need this
(0159270)
hgbot   
2024-01-12 13:26   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c7990302886b11cac6cb718acc284d61efe6fb6c
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 12-01-2024 13:07:20
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c7990302886b11cac6cb718acc284d61efe6fb6c [^]

Related to ISSUE-54331: Reverts proc:full flag in compiler argument

This reverts commit 101e14051c3e4b30e354085f0593feb5bb84c41b, reversing
changes made to d02e72d511f5057314b341bb1bab9effc4796840.

---
M build.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseActionHandler.java
M src-core/build.xml
M src-test/build.xml
M src-trl/build.xml
M src-util/buildvalidation/build.xml
M src-util/modulescript/build.xml
M src-wad/build.xml
M src/build.xml
---
(0159271)
hgbot   
2024-01-12 13:26   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1101 [^]