0054298: Some tests fail without org.openbravo.test.mobile.sampledata

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054298

Retail Modules

Web POS

public

2024-01-10 16:47

2024-11-08 07:26

Reporter

aferraz

Assigned To

Bimla_vm

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0054298: Some tests fail without org.openbravo.test.mobile.sampledata

Description

If we run discount engine tests in try-pos2, there are some tests failing due to missing CRM configuration.

Once this is fixed, we should be able to add discount engine tests to try-pos2 execution:
diff --git a/retail/pos2-modules.json b/retail/pos2-modules.json
index f7a2a7b..286a77c 100644
--- a/retail/pos2-modules.json
+++ b/retail/pos2-modules.json
@@ -607,6 +607,22 @@
                "ver": "master"
            },
            "javapackage": "org.openbravo.taxes"
+ },
+ {
+ "method": "git",
+ "params": {
+ "url": "https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts", [^]
+ "ver": "master"
+ },
+ "javapackage": "org.openbravo.discounts"
+ },
+ {
+ "method": "git",
+ "params": {
+ "url": "https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests", [^]
+ "ver": "master"
+ },
+ "javapackage": "org.openbravo.retail.discounts.tests"
         }
     ],
     "deps": [{

Steps To Reproduce

Add https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^] and https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests [^] modules to pos2-modules.json inside mods section and run try-pos2.

org.openbravo.discounts.propertycondition junit tests fail with following error:
No row with the given identifier exists: [C_ExtBP_Config_Property#612BB567A0FB4A1FABF229F1A2254B66]

https://builds.openbravo.com/job/try-pos2-checks-modules-pgsql/3445/ [^]

Proposed Solution

Add needed configuration to run the test inside the test or in org.openbravo.retail.sampledata.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0053863	closed	ifernandez	Retail Modules	Some tests fail without org.openbravo.test.mobile.sampledata
related to	defect	0050558	closed	caristu	Retail Modules	org.openbravo.discounts.propertycondition tests are not executed in CI
related to	defect	0051867	closed		Retail Modules	Adapt OMS tests to work with retail pack sampledata
related to	defect	0057060	scheduled	Bimla_vm	POS2	Some definitions of the default CRM connector configuration needed for discounts must be adjusted