Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054298Retail ModulesWeb POSpublic2024-01-10 16:472024-11-08 07:26
Reporteraferraz 
Assigned ToBimla_vm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054298: Some tests fail without org.openbravo.test.mobile.sampledata
DescriptionIf we run discount engine tests in try-pos2, there are some tests failing due to missing CRM configuration.

Once this is fixed, we should be able to add discount engine tests to try-pos2 execution:
diff --git a/retail/pos2-modules.json b/retail/pos2-modules.json
index f7a2a7b..286a77c 100644
--- a/retail/pos2-modules.json
+++ b/retail/pos2-modules.json
@@ -607,6 +607,22 @@
                "ver": "master"
            },
            "javapackage": "org.openbravo.taxes"
+ },
+ {
+ "method": "git",
+ "params": {
+ "url": "https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts", [^]
+ "ver": "master"
+ },
+ "javapackage": "org.openbravo.discounts"
+ },
+ {
+ "method": "git",
+ "params": {
+ "url": "https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests", [^]
+ "ver": "master"
+ },
+ "javapackage": "org.openbravo.retail.discounts.tests"
         }
     ],
     "deps": [{
Steps To ReproduceAdd https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^] and https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.discounts.tests [^] modules to pos2-modules.json inside mods section and run try-pos2.

org.openbravo.discounts.propertycondition junit tests fail with following error:
No row with the given identifier exists: [C_ExtBP_Config_Property#612BB567A0FB4A1FABF229F1A2254B66]

https://builds.openbravo.com/job/try-pos2-checks-modules-pgsql/3445/ [^]
Proposed SolutionAdd needed configuration to run the test inside the test or in org.openbravo.retail.sampledata.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0053863 closed ifernandez Retail Modules Some tests fail without org.openbravo.test.mobile.sampledata 
related to defect 0050558 closed caristu Retail Modules org.openbravo.discounts.propertycondition tests are not executed in CI 
related to defect 0051867 closed  Retail Modules Adapt OMS tests to work with retail pack sampledata 
related to defect 0057060 closed Bimla_vm POS2 Some definitions of the default CRM connector configuration needed for discounts must be adjusted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-10 16:47aferrazNew Issue
2024-01-10 16:47aferrazAssigned To => Retail
2024-01-10 16:47aferrazOBNetwork customer => No
2024-01-10 16:47aferrazTriggers an Emergency Pack => No
2024-01-10 16:47aferrazIssue generated from0053863
2024-01-10 16:50aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=27319#r27319
2024-01-10 16:50aferrazProposed Solution updated
2024-01-10 16:52aferrazRelationship addedrelated to 0053863
2024-01-11 14:00shuehnerIssue Monitored: shuehner
2024-01-12 13:49aferrazDescription Updatedbug_revision_view_page.php?rev_id=27333#r27333
2024-10-08 07:58Bimla_vmAssigned ToRetail => Bimla_vm
2024-10-08 08:56Bimla_vmStatusnew => scheduled
2024-10-23 21:24aferrazRelationship addedrelated to 0050558
2024-10-23 23:29aferrazRelationship addedrelated to 0051867
2024-11-07 13:03hgbotMerge Request Status => open
2024-11-07 13:03hgbotNote Added: 0171626
2024-11-07 13:20hgbotMerge Request Statusopen => approved
2024-11-07 13:26hgbotResolutionopen => fixed
2024-11-07 13:26hgbotStatusscheduled => closed
2024-11-07 13:26hgbotFixed in Version => RR25Q1
2024-11-07 13:26hgbotNote Added: 0171630
2024-11-07 13:26hgbotNote Added: 0171631
2024-11-07 13:26hgbotNote Added: 0171632
2024-11-07 16:00hgbotFixed in VersionRR25Q1 => 23Q4
2024-11-07 16:00hgbotNote Added: 0171648
2024-11-08 07:26hgbotNote Added: 0171670
2024-11-11 17:37marvintmRelationship addedrelated to 0057060

Notes
(0171626)
hgbot   
2024-11-07 13:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/125 [^]
(0171630)
hgbot   
2024-11-07 13:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: b77375ea74d55178fb778c91f21f5742ed165d93
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 07-11-2024 12:03:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/b77375ea74d55178fb778c91f21f5742ed165d93 [^]

Fixed ISSUE-54298: Add missing items to retail sampledata

---
A referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG.xml
A referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
A src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
---
(0171631)
hgbot   
2024-11-07 13:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 8af7ba13ab59392deb58378b04ffff17944ba03d
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 07-11-2024 12:03:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/8af7ba13ab59392deb58378b04ffff17944ba03d [^]

Fixed ISSUE-54298: updated the retail sampledata

---
M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml
---
(0171632)
hgbot   
2024-11-07 13:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/125 [^]
(0171648)
hgbot   
2024-11-07 16:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration [^]
Changeset: ce039d950772f6578cc51b0528efe0c6e88c55fa
Author: meriem azaf <m.azaf@orisha.com>
Date: 07-11-2024 15:00:34
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.samplebpintegration/-/commit/ce039d950772f6578cc51b0528efe0c6e88c55fa [^]

Fixes ISSUE-54298: Move some messages to retail.sampledata

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0171670)
hgbot   
2024-11-08 07:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: fbe408b7cf2eee50aad24150ae1a5d090276936f
Author: meriem azaf <m.azaf@orisha.com>
Date: 08-11-2024 06:26:26
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/fbe408b7cf2eee50aad24150ae1a5d090276936f [^]

Fixes ISSUE-54298: Add missing messages and a db prefix

---
A src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
---