Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0054271Openbravo ERPA. Platformpublic2024-01-08 22:512024-02-11 22:32
mtaal 
Triage Platform Base 
normalminorhave not tried
closedfixed 
5
 
 
Core
No
0054271: core2: Data Grid RowRenderer - pass selected property to cell renderer
Pass the selected property onto the cell renderer so that the cell is aware that it is part of a selected row and can render differently if selected or not.

The proposed change is here [1].

[1]
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowRender.jsx?ref_type=heads#L102 [^]
See description
Passing the selected property is much simpler than trying to keep some global state and checking it. The selected property is also passed to the row and it helps to also be available to the cells of the row.
No tags attached.
Issue History
2024-01-08 22:51mtaalNew Issue
2024-01-08 22:51mtaalAssigned To => Triage Platform Base
2024-01-08 22:51mtaalModules => Core
2024-01-08 22:51mtaalTriggers an Emergency Pack => No
2024-01-08 22:51mtaalSummarycore2: Data Grid RowRenderer => core2: Data Grid RowRenderer - pass selected property to cell renderer
2024-01-08 22:53mtaalDescription Updatedbug_revision_view_page.php?rev_id=27304#r27304
2024-01-08 23:06hgbotNote Added: 0158965
2024-02-11 22:32hgbotNote Added: 0160598
2024-02-11 22:32hgbotResolutionopen => fixed
2024-02-11 22:32hgbotStatusnew => closed
2024-02-11 22:32hgbotFixed in Version => 24Q2
2024-02-11 22:32hgbotNote Added: 0160599

Notes
(0158965)
hgbot   
2024-01-08 23:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1320 [^]
(0160598)
hgbot   
2024-02-11 22:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1320 [^]
(0160599)
hgbot   
2024-02-11 22:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a5caff8793dec8cd1759c146f23b0e5edcedbc80
Author: Martin Taal <martin.taal@openbravo.com>
Date: 11-02-2024 21:30:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a5caff8793dec8cd1759c146f23b0e5edcedbc80 [^]

Fixed ISSUE-54271: Pass the selected property to the cell renerer

---
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseRowRender.jsx
---