Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054247POS2POSpublic2024-01-03 15:232024-01-17 12:30
Reporterlmonreal 
Assigned Tokousalya_r 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054247: Pricelists without taxes UI label 'Discount (NaN.00€) and product line price 0 crossed
Description‘Price Includes Tax’=false triggers a label 'Discount (NaN.00€)' in every ticket line in POS [*]


Also the product line has a 0 price crossed. It should not be displayed

See in the following video the configuration done to reproduce it in livebuilds

Video:https://drive.google.com/file/d/15qeZAVTVCTozCaC3vxXPFWdpcU6kuP8m/view [^]
Steps To ReproduceI add product A to the ticket

A price of “0€” is crossed, and the price displayed is 20€
Proposed SolutionNot display the 0 crossed and the discount label
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005436924Q1 closed kousalya_r Pricelists without taxes UI label 'Discount (NaN.00€) and product line price 0 crossed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-01-03 15:23lmonrealNew Issue
2024-01-03 15:23lmonrealAssigned To => aferraz
2024-01-03 15:23lmonrealTriggers an Emergency Pack => No
2024-01-05 13:42lmonrealSummaryPricelists without taxes UI label 'Discount (NaN.00€) => Pricelists without taxes UI label 'Discount (NaN.00€) and product line price 0 crossed
2024-01-05 13:42lmonrealDescription Updatedbug_revision_view_page.php?rev_id=27296#r27296
2024-01-05 13:42lmonrealProposed Solution updated
2024-01-05 15:26hgbotNote Added: 0158896
2024-01-08 09:47aferrazAssigned Toaferraz => kousalya_r
2024-01-12 09:45hgbotResolutionopen => fixed
2024-01-12 09:45hgbotStatusnew => closed
2024-01-12 09:45hgbotFixed in Version => 24Q2
2024-01-12 09:45hgbotNote Added: 0159246
2024-01-12 09:45hgbotNote Added: 0159247
2024-01-17 12:29aferrazStatusclosed => new
2024-01-17 12:29aferrazResolutionfixed => open
2024-01-17 12:29aferrazFixed in Version24Q2 =>
2024-01-17 12:29aferrazStatusnew => scheduled
2024-01-17 12:30aferrazStatusscheduled => resolved
2024-01-17 12:30aferrazResolutionopen => fixed
2024-01-17 12:30aferrazNote Added: 0159408
2024-01-17 12:30aferrazStatusresolved => closed
2024-01-17 12:30aferrazNote Edited: 0159408bug_revision_view_page.php?bugnote_id=0159408#r27361

Notes
(0158896)
hgbot   
2024-01-05 15:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2328 [^]
(0159246)
hgbot   
2024-01-12 09:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2328 [^]
(0159247)
hgbot   
2024-01-12 09:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7b70aea9bae925c432c6e4410cebf9579db3a6c4
Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com>
Date: 12-01-2024 08:45:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7b70aea9bae925c432c6e4410cebf9579db3a6c4 [^]

Fixes ISSUE-54247: NaN fix in discount label, gross List Price is not available when price includes tax is unchecked

---
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/__test__/TicketLineDiscount.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrediscountPrice/__test__/TicketLinePrediscountPrice.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrediscountPrice/TicketLinePrediscountPrice.jsx
---
(0159408)
aferraz   
2024-01-17 12:30   
Reopened to create backport for 24Q1 0054369 and closed again.