Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
0054224Openbravo LocalizationsOtherspublic2023-12-28 09:022024-02-06 13:04
tonialcaide 
tonialcaide 
normalmajorhave not tried
closedfixed 
5
 
 
approved
No
0054224: Errors when testing the org.openbravo.pos2.marketingsurvey.sampledata module
Error found
===========

We have detected errors in module org.openbravo.pos2.marketingsurvey.sampledata when running the mod-translations job:

https://builds.openbravo.com/job/mod-translations/1587/console [^]

https://builds.openbravo.com/job/mod-simple/87973/consoleFull [^]

https://builds.openbravo.com/job/mod-simple/87973/testReport/ [^]

https://builds.openbravo.com/job/mod-simple/87973/testReport/org.openbravo.test.reducedtranslation/ReducedTranslationExportTests/expectedEmptyTranslationFilesAbsent/ [^]

Caused by: org.postgresql.util.PSQLException: ERROR: column t.istranslated does not exist
  Position: 8

Root cause
===========

Marketing surveys are masterdata, like products, and are therefore not exported like other translations (e.g. AD_Element, etc.). This table has been designed so that clients can manually enter the translation of the surveys. But this translation is not put into a module and then distributed, so it does not need the isTranslated flag... But now we see that the translation export engine doesn't know how to work well in this situation.

Possible fix
===========

To avoid problems, add a new column “istranslated” to the table “obms_marketing_survey_trl”, with the same definition like the column “istranslated” in the table “m_product_trl”

It's not necessary put the field in the window, just to add the column

JIRA
===========
https://openbravo.atlassian.net/browse/RM-10763 [^]
Go to mod-translations job: https://builds.openbravo.com/view/all/job/mod-translations/build?delay=0sec [^]

Put your email (or empty) in the FAILURE_EMAIL field

Put localization/translations-53557.json in the CONFIG_FILE_NAME field

Run the job and check the log
No tags attached.
Issue History
2023-12-28 09:02tonialcaideNew Issue
2023-12-28 09:02tonialcaideAssigned To => tonialcaide
2023-12-28 09:02tonialcaideOBNetwork customer => No
2023-12-28 12:38hgbotMerge Request Status => open
2023-12-28 12:38hgbotNote Added: 0158686
2024-01-31 21:55hgbotMerge Request Statusopen => approved
2024-02-06 13:04hgbotResolutionopen => fixed
2024-02-06 13:04hgbotStatusnew => closed
2024-02-06 13:04hgbotNote Added: 0160297
2024-02-06 13:04hgbotNote Added: 0160298

Notes
(0158686)
hgbot   
2023-12-28 12:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/21 [^]
(0160297)
hgbot   
2024-02-06 13:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey [^]
Changeset: 69a5e938e9e83b5161ac731ec3bd5087ac2f65b4
Author: Toni Alcaide <antonio.alcaide@openbravo.com>
Date: 06-02-2024 12:04:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/commit/69a5e938e9e83b5161ac731ec3bd5087ac2f65b4 [^]

Fixes ISSUE-54224: Added istranslated column to table obms_marketing_survey_trl

---
M src-db/database/model/tables/OBMS_MARKETING_SURVEY_TRL.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0160298)
hgbot   
2024-02-06 13:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/21 [^]