Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054203POS2POSpublic2023-12-22 12:262024-02-28 09:55
Reporterjustin_patterson 
Assigned Toaaroncalero 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054203: RM-8641 - Implement Burn Gift Certificate rule in ReactPOS
DescriptionThe objective of this development is to migrate the the Burn Gift Certificates for Loyalty Programs functionality to ReactPOS
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-12-22 12:26justin_pattersonNew Issue
2023-12-22 12:26justin_pattersonAssigned To => Retail
2023-12-22 12:26justin_pattersonTriggers an Emergency Pack => No
2023-12-22 12:33hgbotNote Added: 0158515
2024-01-26 09:19hgbotNote Added: 0159809
2024-01-26 09:20hgbotNote Added: 0159810
2024-02-28 09:42hgbotNote Added: 0161346
2024-02-28 09:42aaroncaleroAssigned ToRetail => aaroncalero
2024-02-28 09:42aaroncaleroStatusnew => scheduled
2024-02-28 09:53hgbotNote Added: 0161347
2024-02-28 09:53hgbotNote Added: 0161348
2024-02-28 09:54hgbotNote Added: 0161349
2024-02-28 09:54hgbotNote Added: 0161350
2024-02-28 09:54hgbotNote Added: 0161351
2024-02-28 09:55hgbotResolutionopen => fixed
2024-02-28 09:55hgbotStatusscheduled => closed
2024-02-28 09:55hgbotNote Added: 0161352
2024-02-28 09:55hgbotNote Added: 0161353
2024-02-28 09:55hgbotNote Added: 0161354
2024-02-28 09:55hgbotNote Added: 0161355
2024-02-28 09:55hgbotNote Added: 0161356

Notes
(0158515)
hgbot   
2023-12-22 12:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/merge_requests/20 [^]
(0159809)
hgbot   
2024-01-26 09:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/merge_requests/8 [^]
(0159810)
hgbot   
2024-01-26 09:20   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/358 [^]
(0161346)
hgbot   
2024-02-28 09:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2456 [^]
(0161347)
hgbot   
2024-02-28 09:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate [^]
Changeset: 2df589b5edc8ec6e81876a310f428930b477852a
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 28-02-2024 09:45:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/commit/2df589b5edc8ec6e81876a310f428930b477852a [^]

Related to FR-54203: Disabled JUnit tests if sampledata is not available

---
M src-test/org/openbravo/loyalty/burn/giftcertificate/test/GiftCertificateTest.java
---
(0161348)
hgbot   
2024-02-28 09:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/merge_requests/8 [^]
(0161349)
hgbot   
2024-02-28 09:54   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5474a96b51bcbeb31d6fb4c4ee37b72a34a1247f
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 28-02-2024 09:39:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5474a96b51bcbeb31d6fb4c4ee37b72a34a1247f [^]

Related to FR-54203: Allow adding custom text to Payment Provider payment buttons

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetPaymentExtraLabelProperties.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/PaymentProvider.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
---
(0161350)
hgbot   
2024-02-28 09:54   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fa8f4abb87b78b7d7c7445194fa7fd3cdabdce7c
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 28-02-2024 09:44:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fa8f4abb87b78b7d7c7445194fa7fd3cdabdce7c [^]

Related to FR-54203: Allow adding custom text to Payment Provider payment buttons

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetPaymentExtraLabelProperties.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.scss
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/PaymentProvider.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
---
(0161351)
hgbot   
2024-02-28 09:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2456 [^]
(0161352)
hgbot   
2024-02-28 09:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate [^]
Changeset: 0dd8c69f4d33cf5d1d90ade2c796416c6990297f
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 26-02-2024 16:08:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/commit/0dd8c69f4d33cf5d1d90ade2c796416c6990297f [^]

Fixes FR-54203: Implement Burn Gift Certificate rule in ReactPOS
(JIRA 8641)
-Created new List Reference for Provider OBRLPGC_BurnGiftCertificateProvider
-Created new Payment Method Type Burn Gift Certificate Provider
-Implented new class OBRLPGCPaymentProvider extending class PaymentProvider
-Implemented method processPayment() which creates a gift ceritifcate
from available earned loyalty points, consumes the gift
certificate, and triggers the logic to add a payment from the consumed
gift certificate
-Implemented method processVoid() which restores points to a loyalty
subscription from payment made with gift certificate from burned loyalty
points
-Implemented utility class with logic that gets gift certificate burn
rules using information from a loyalty subscription
-Implemented confirmation dialog which displays information about a
user's loyalty points if the user is subscribed to a loyalty program and
has enough available loyalty points to convert into a gift certificate
and allows the user to redeem these points
-Added supporting logic for new components and actions
-Added AD_MESSAGES

---
A src-db/database/sourcedata/OBC2_USER_ACTION.xml
A src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/AvailablePointsPopup.jsx
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/AvailablePointsPopup.scss
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/__test__/AvailablePointsPopup.test.jsx
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/index.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/OBRLPGCPaymentProvider.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/__test__/OBRLPGCPaymentProvider.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/actions/__test__/checkLoyaltyBeforeOpenPopup.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/actions/checkLoyaltyBeforeOpenPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/user-actions/FinishAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/user-actions/ShowAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/user-interface/UIExtension.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/user-interface/actions/ShowAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/ob-init.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/utilities/__test__/utils.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/utilities/utils.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0161353)
hgbot   
2024-02-28 09:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate [^]
Changeset: b6219a0e6ff379a8466ad22bb7009e0894508feb
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 28-02-2024 09:41:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/commit/b6219a0e6ff379a8466ad22bb7009e0894508feb [^]

Fixed FR-54203: Implement Burn Gift Certificate rule in ReactPOS

---
A src-db/database/sourcedata/OBC2_USER_ACTION.xml
A src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/AvailablePointsPopup.jsx
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/AvailablePointsPopup.scss
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/__test__/AvailablePointsPopup.test.jsx
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/AvailablePointsPopup/index.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/OBRLPGCPaymentProvider.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/components/__test__/OBRLPGCPaymentProvider.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/actions/__test__/checkLoyaltyBeforeOpenPopup.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/actions/checkLoyaltyBeforeOpenPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/user-actions/AddLoyaltyPointsActionPostHook.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/user-actions/FinishAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/loyalty/user-actions/ShowAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/user-interface/UIExtension.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/model/user-interface/actions/ShowAvailablePointsPopup.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/ob-init.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/utilities/__test__/utils.test.js
A web-jspack/org.openbravo.retail.loyalty.burn.giftcertificate/src/utilities/utils.js
M .gitignore
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0161354)
hgbot   
2024-02-28 09:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/merge_requests/20 [^]
(0161355)
hgbot   
2024-02-28 09:55   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: e2e0cc21abc971b09f3305b9db12c2a4ae2f2c52
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 28-02-2024 09:37:53
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/e2e0cc21abc971b09f3305b9db12c2a4ae2f2c52 [^]

Related to FR-54203: Fixed message in Burn Gift Certificates tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/giftcertificates/REDPTS060_SimplifiedFlowEnabledOnlyIfOneSubscriptionWithAvailablePoints.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/giftcertificates/REDPTS070_SimplifiedFlowConsumeJustNeededPointsWhenAmountToPayIsLowerThanAvailableInSubscription.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/giftcertificates/REDPTS080_ManualTotalAmountEnteredAndPaymentWithAvailablePoints.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/giftcertificates/REDPTS090_ManualAmountEnteredAtKeyboardExceedsAvailablePoints.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/giftcertificates/REDPTS120_CancelOrderIfOverpaymentExceedsPaidInCashAndThereIsLoyaltyPayments.java
---
(0161356)
hgbot   
2024-02-28 09:55   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/358 [^]