0054104: Error when I create the invoice from the shipment

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054104

Openbravo ERP

07. Sales management

public

2023-12-12 12:07

2024-01-08 09:45

Reporter

sofidossant

Assigned To

AtulOpenbravo

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

PR24Q1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

82229

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0054104: Error when I create the invoice from the shipment

Description

The problem arises when I have this case:
Order with 1 line of quantity 2
I create the shipment from the create line from button, I add the order line, but twice, I should have 2 lines left in shipment with quantity 1.
And then when completing and creating the invoice, the following error is created:
"It is not possible to complete the invoice FO1025318 line 20. Order No. B2B1002923: Invoiced Quantity cannot be higher than Ordered Quantity."

The error is in the function
src-db/database/model/functions/C_INVOICE_POST.xml

Steps To Reproduce

I create an order with 1 line of quantity 2
I create the shipment from the create line from button, I add the order line, but twice, I should have 2 lines left in shipment with quantity 1.
And then when completing and creating the invoice, the following error is created:
"It is not possible to complete the invoice FO1025318 line 20. Order No. B2B1002923: Invoiced Quantity cannot be higher than Ordered Quantity."

Video
https://drive.google.com/file/d/1tyKw34gbiN09UKjvIM9eVPfynazKFaGj/view?usp=sharing [^]

Proposed Solution

The error is in the function
src-db/database/model/functions/C_INVOICE_POST.xml

In the part:
FOR CurLines IN
          (SELECT * FROM C_INVOICELINE WHERE C_INVOICE_ID=v_Record_ID ORDER BY line)
        LOOP
          IF (CurLines.C_OrderLine_ID IS NOT NULL) THEN
            --Check that qty pending to invoice is higher or equal to the qty being invoiced
            SELECT o.documentno, ABS(ol.qtyordered) - ABS(ol.qtyinvoiced + CurLines.QtyInvoiced), p.isquantityvariable
              INTO v_ODocumentNo, v_NewPendingToInvoice, v_Isquantityvariable
            FROM c_order o, c_orderline ol
            LEFT JOIN m_product p ON p.m_product_id = ol.m_product_id
            WHERE o.c_order_id = ol.c_order_id
              AND ol.c_orderline_id = CurLines.c_orderline_id;
            IF (v_Isquantityvariable <> 'Y' AND v_NewPendingToInvoice <0) THEN
              v_Message := '@NotPossibleCompleteInvoice@' || ' ' || v_DocumentNo;
              v_Message := v_Message || ' ' || '@line@' || ' ' || CurLines.line || '. ';
              v_Message := v_Message || '@OrderDocumentno@' || ' ' || v_ODocumentNo;
              v_Message := v_Message || ': ' || '@QtyInvoicedHigherOrdered@' || '.';
              RAISE_APPLICATION_ERROR(-20000, v_Message);
            END IF;

We need to check the sum of quantity too.

Additional Information